Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

Thanks for the additional review comments. Responses in-line below. Updated webrev: http://cr.openjdk.java.net/~vinnie/8144093/webrev.02/ > On 1 Dec 2015, at 01:32, Bradford Wetmore wrote: > > > On 11/29/2015 4:08 PM, Vincent Ryan wrote: > > > Following on from Brad

Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

throw new SSLProtocolException( >> +"Invalid " + type + " extension: too short"); > Can you print the len value here ? > >> +if (remaining != 0) { >> +throw new SSLProtocolException( >> +

Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

gt; applicationProtocols field until you confirm the values are valid, and then > assign it to applicationProtocols. > > ExtensionType.java > > 47 new ArrayList(15); > > nit - you can use diamond operator above > > --Sean > > On 11/29/2015 07:08 PM,

Re: Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

t writeRecord(ByteBuffer[] appData, >int offset, int length, ByteBuffer netData) throws IOException { >... > if (...) { >... >// set connection ALPN value >applicationProtocol = >handshaker.getHandshakeApplicationProtocol(); >... > } > }

Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

Hello, Following on from Brad’s recent email, here is the full webrev of the API and the implementation classes for ALPN: http://cr.openjdk.java.net/~vinnie/8144093/webrev.00/ In adds the implementation classes (sun/security/ssl) to the

Re: code review request: 6911951: NTLM should be a supported Java SASL mechanism

The SASL component looks good Max. Michael/Chris: have you any comments on the NTLM changes? On 25/08/2010 06:23, Weijun Wang wrote: > Ping again. > > The webrev is updated: >http://cr.openjdk.java.net/~weijun/6911951/webrev.01/ > > The CCC is about to be finalized: >http://ccc.sfbay.

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 78d91c4223cb Author:vinnie Date: 2010-03-01 17:54 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/78d91c4223cb 6921001: api/java_security/IdentityScope/IdentityScopeTests.html#getSystemScope fails starting from b78 JDK7 Reviewed-by: mullan ! src/share/classes/java

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 117b245b5bb9 Author:vinnie Date: 2010-01-21 23:59 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/117b245b5bb9 6763530: Cannot decode PublicKey (Proider SunPKCS11, curve prime256v1) Reviewed-by: andrew ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java !

hg: jdk7/tl/jdk: 6876158: Remove dependencies on Signer, Certificate, Identity, IdentityScope classes from java.security pkg

Changeset: 327adb1c2224 Author:vinnie Date: 2009-12-07 17:06 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/327adb1c2224 6876158: Remove dependencies on Signer, Certificate, Identity, IdentityScope classes from java.security pkg Reviewed-by: alanb, mullan ! src/share/classe

hg: jdk7/tl/jdk: 6906854: SSL/Krb5 testcase should not use a fixed port number

Changeset: bc12627832e0 Author:vinnie Date: 2009-12-03 21:30 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bc12627832e0 6906854: SSL/Krb5 testcase should not use a fixed port number Reviewed-by: alanb ! test/ProblemList.txt ! test/sun/security/krb5/auto/SSL.java

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 561186928899 Author:vinnie Date: 2009-12-02 17:06 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/561186928899 6906510: Fix testcase for 6894643: Separate out dependency on Kerberos Reviewed-by: weijun ! test/sun/security/krb5/auto/SSL.java Changeset: 79d91585d7d7

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 7475a2e71c40 Author:vinnie Date: 2009-11-12 23:00 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7475a2e71c40 6894643: Separate out dependency on Kerberos Reviewed-by: alanb, xuelei ! make/sun/security/other/Makefile ! src/share/classes/com/sun/jndi/ldap/ext/Start

hg: jdk7/tl/jdk: 6885204: JSSE should not require Kerberos to be present

Changeset: 54118c8e0ebe Author:vinnie Date: 2009-10-05 23:42 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/54118c8e0ebe 6885204: JSSE should not require Kerberos to be present Reviewed-by: wetmore, alanb ! src/share/classes/com/sun/net/ssl/internal/www/protocol/https/Deleg

hg: jdk7/tl/jdk: 6884175: CR cleanup for 6840752: Provide out-of-the-box support for ECC algorithms

Changeset: 845fefff00a4 Author:vinnie Date: 2009-09-21 23:01 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/845fefff00a4 6884175: CR cleanup for 6840752: Provide out-of-the-box support for ECC algorithms Reviewed-by: wetmore ! make/sun/security/ec/Makefile ! make/sun/securi

hg: jdk7/tl/jdk: 6872048: bad private keys are generated for 2 specific ECC curves

Changeset: dd997cc0c823 Author:vinnie Date: 2009-08-24 18:37 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dd997cc0c823 6872048: bad private keys are generated for 2 specific ECC curves Reviewed-by: wetmore ! src/share/native/sun/security/ec/ec.c ! test/sun/security/ec/Test

hg: jdk7/tl/jdk: 3 new changesets

Changeset: 1ff7163fc5f7 Author:vinnie Date: 2009-08-11 16:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ff7163fc5f7 6840752: Provide out-of-the-box support for ECC algorithms Reviewed-by: alanb, mullan, wetmore ! make/sun/security/Makefile + make/sun/security/ec/FILES_c