Re: RFR[15] JDK-8238740: java/net/httpclient/whitebox/FlowTestDriver.java would not specify a TLS protocol

Could this simple patch be reviewed? John On 2020/3/2 16:08, sha.ji...@oracle.com wrote: Hi, java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/FlowTest.java would not use a specific TLS protocol, instead just use the default TLS protocol, exactly TLSv1.3 now. diff -r 4a5a7dc9

RFR[15] JDK-8238740: java/net/httpclient/whitebox/FlowTestDriver.java would not specify a TLS protocol

Hi, java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/FlowTest.java would not use a specific TLS protocol, instead just use the default TLS protocol, exactly TLSv1.3 now. diff -r 4a5a7dc9d05c test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/FlowTest.jav

Re: 8239052: java/net/httpclient/whitebox/SSLEchoTubeTestDriver.java failed with BufferUnderflowException against TLSv1.3

Hi Daniel, Not a review, but just a minor suggestion. 273 params.setProtocols(new String[]{"TLSv1.3"}); // TODO: This is essential. Needs to be protocol impl If this test doesn't concern a specific TLS protocol, this configuration could be removed. The default TLS protocol, exactly TLS

RFR[15] JDK-8239025: ProblemList java/net/httpclient/HandshakeFailureTest.java due to JDK-8238990

Hi, java/net/httpclient/HandshakeFailureTest.java should be in the problem list until JDK-8238990 is resolved. diff -r 87651cb03ebc test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt    Thu Feb 13 13:43:09 2020 -0800 +++ b/test/jdk/ProblemList.txt    Fri Feb 14 07:05:39 2020 +0800 @@ -627,

RFR[15] JDK-8234718: java/net/httpclient tests should cover TLSv1.3

Hi, java/net/httpclient/HandshakeFailureTest.java should cover TLSv1.3 as well. java/net/httpclient/ShortResponseBody.java would not specify a TLS protocol. Please note the value of the system property jdk.internal.httpclient.debug in HandshakeFailureTest.java is changed to false due to JDK-823

Re: RFR[15] 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

Hi Daniel, Would it be possible to include a comment in Cert.java that contains the command you used to generate the certificates? That will be a great help to future maintainers if the certificates ever needs to be re-generated (e.g. to update the expiry date etc...) I'll do that. Please re

Re: RFR[15] 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

Hi Daniel, On 2020/2/7 19:29, Daniel Fuchs wrote: Hi John, Looks good to me. Thanks for taking care of this! I'm glad to see the binary files go away :-) Thanks for your review! Would it be possible to include a comment in Cert.java that contains the command you used to generate the certifi

RFR[15] 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

Hi, java/net/httpclient/ssltest/CertificateTest.java shouldn't use a specific TLS version. And it would be better not to use binary key store files. Since DSA is not supported by TLSv1.3, this fix also updates the certificates to use RSA. Webrev: http://cr.openjdk.java.net/~jjiang/8238677/web

Re: RFR[12] JDK-8211978: move testlibrary/jdk/testlibrary/SimpleSSLContext.java and testkeys to network testlibrary

Please review the updated webrev: http://cr.openjdk.java.net/~jjiang/8211978/webrev.01/ AbstractSSLTubeTest.java and FlowTest.java now use the same internal.net.http.SimpleSSLContext.java In addition, it looks the original jdk/testlibrary/SimpleSSLContext.java could accept an alternative keyst

Re: RFR[12] JDK-8211978: move testlibrary/jdk/testlibrary/SimpleSSLContext.java and testkeys to network testlibrary

At least, the inner SimpleSSLContext classes in AbstractSSLTubeTest.java and FlowTest.java could be combined. I'm doing it. Best regards, John Jiang On 2018/10/15 17:21, Daniel Fuchs wrote: Hi Max, These tests are whitebox tests - the tests classes are patched into the java.net.http module, a

RFR[12] JDK-8211978: move testlibrary/jdk/testlibrary/SimpleSSLContext.java and testkeys to network testlibrary

Hi, This patch moves test/jdk/lib/testlibrary/jdk/testlibrary/SimpleSSLContext.java to test/lib/jdk/test/lib/net/SimpleSSLContext.java. Webrev: http://cr.openjdk.java.net/~jjiang/8211978/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8211978 Best regards, John Jiang