Re: RFR: JDK-8260925: HttpsURLConnection does not work with other JSSE provider. [v6]

2021-03-04 Thread Kumar Srinivasan
On Thu, 4 Mar 2021 05:16:02 GMT, Xue-Lei Andrew Fan wrote: >> Vyom Tewari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added a comment that host has bees set previously > > Thank you. I have no more comment. Shouldn't there be a regr

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (core libraries)

2020-05-07 Thread Kumar Srinivasan
ok to me. I did notice the \n endings for the messages that Brent pointed out. Best Kumar Srinivasan On May 6, 2020, at 9:43 PM, Mikael Vidstedt mailto:mikael.vidst...@oracle.com>> wrote: I have always wondered what “solinux” is supposed to mean - though not enough to actual

Re: RFR: JDK-8179697: Fix Html5 errors in java.naming, java.logging, jdk.httpserver, jdk.net, jdk.sctp

2017-05-11 Thread Kumar Srinivasan
ge Specification section, and others have it changed to Package Specification. best regards, -- daniel On 10/05/2017 19:57, Kumar Srinivasan wrote: Hello, Please review HTML5 related changes to the above modules, please note there are no changes to the verbiage. Thanks Kumar Webrev: http://cr.

RFR: JDK-8179697: Fix Html5 errors in java.naming, java.logging, jdk.httpserver, jdk.net, jdk.sctp

2017-05-10 Thread Kumar Srinivasan
Hello, Please review HTML5 related changes to the above modules, please note there are no changes to the verbiage. Thanks Kumar Webrev: http://cr.openjdk.java.net/~ksrini/8179697/webrev.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8179697

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

2014-01-16 Thread Kumar Srinivasan
Roger, one more thing, shouldn't the parameters be unique ? I think Martin had me do this for all macros in the java launcher for example please see this changeset, I recently pushed. http://hg.openjdk.java.net/jdk9/dev/jdk/rev/6c50c972a101 Kumar On 1/16/2014 9:30 AM, Kumar Srinivasan

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

2014-01-16 Thread Kumar Srinivasan
Hi Roger, Its confusing to use a JNU_ prefixed macro on a method not involvng jni, why not rename these to modulo JNU_ ? I am cc'ing Alex as he has a related bug fix in his queue for pack's jni code. Kumar Hi Alan, The macros are generally useful even without being used on a method that in

hg: jdk7/tl/jdk: 6367077: Purge LD_LIBRARY_PATH usage from the launcher; ...

2009-11-30 Thread kumar . srinivasan
Changeset: de45eac5670e Author:ksrini Date: 2009-11-20 11:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de45eac5670e 6367077: Purge LD_LIBRARY_PATH usage from the launcher 6899834: (launcher) remove the solaris libjvm.so symlink Summary: Fixes other related issues as well