Sorry for the typo. I mean that I am waiting for jdk 9 repo to be open.
-Dan
On 12/12/2013 07:54 PM, Dan Xu wrote:
Thanks for the review. The fix is for 9 not 8. I am waiting for jdk 8
repo to be open.
-Dan
On 12/12/2013 02:49 AM, Michael McMahon wrote:
Yes, looks good Dan. I presume this
Thanks for the review. The fix is for 9 not 8. I am waiting for jdk 8
repo to be open.
-Dan
On 12/12/2013 02:49 AM, Michael McMahon wrote:
Yes, looks good Dan. I presume this is going into 9 rather than 8
though...?
Michael.
On 12/12/13 05:14, Dan Xu wrote:
Hi All,
Please review the fix
Hi All,
Please review the fix for the JNI pending exception issue in
src/solaris/native/sun/net/spi/DefaultProxySelector.c. I have refactored
the code so that JNI calls will only be run when previous JNI calls
succeed. Therefore, it is impossible for an unsafe JNI call to happen.
Please help
Hi Chris,
Thanks for your detailed explanation. I understand the issue now.
Thanks!
-Dan
On Mon 09 Dec 2013 02:09:52 AM PST, Chris Hegarty wrote:
On 08/12/13 17:39, Dan Xu wrote:
On 12/08/2013 01:34 AM, Chris Hegarty wrote:
On 07/12/2013 18:12, Dan Xu wrote:
...
Just so I understand
On 12/08/2013 01:34 AM, Chris Hegarty wrote:
On 07/12/2013 18:12, Dan Xu wrote:
...
Just so I understand, did you use a JNI global when caching the
reference?
-Alan
Hi Alan,
What is a JNI global?
http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html#wp1242
On 12/07/2013 02:57 AM, Alan Bateman wrote:
On 07/12/2013 01:22, Dan Xu wrote:
Hi All,
When working on
src/solaris/native/sun/net/spi/DefaultProxySelector.c, previously I
tried to cached a jobject (The cached java object is
java.net.Proxy.NO_PROXY, which is a special type of Proxy.) as a
Hi All,
When working on src/solaris/native/sun/net/spi/DefaultProxySelector.c,
previously I tried to cached a jobject (The cached java object is
java.net.Proxy.NO_PROXY, which is a special type of Proxy.) as a global
static variable, no_proxy, in this c file. Its value is initialized in
the i
Changeset: a74d6aa51654
Author:dxu
Date: 2013-11-21 14:16 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a74d6aa51654
7065902: (file) test/java/nio/file/Files/Misc.java fails on Solaris 11 when run
as root
Reviewed-by: alanb
! test/java/nio/file/Files/Misc.java
Changeset: 81708985c0a2
Author:dxu
Date: 2013-11-21 14:23 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81708985c0a2
8028628: java/nio/channels/FileChannel/Size.java failed once in the same binary
run
Reviewed-by: alanb, chegar, mchung, lancea
! test/java/nio/channels/File
Changeset: f496565c4eec
Author:dxu
Date: 2013-11-19 13:22 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f496565c4eec
8028631: Improve the test coverage to the pathname handling on unix-like
platforms
Summary: Add GeneralSolaris.java testcase and fix the concurrency issue
Re
Thank you, Chris. Others look good to me. Thanks for helping solve this
hard problem!
-Dan
On 11/11/2013 02:41 AM, Chris Hegarty wrote:
Thanks Dan,
I'll make the changes before pushing.
-Chris.
On 09/11/2013 05:43, Dan Xu wrote:
Hi Chris,
In deleteFileWithRetry0(), the following
etes, i.e. the file no longer exists.
Updated webrev ( with only the diff from the previous ) :
http://cr.openjdk.java.net/~chegar/fileUtils.02/webrev/
Thanks,
-Chris.
On 08/11/2013 02:26, Dan Xu wrote:
On 11/07/2013 11:04 AM, Alan Bateman wrote:
On 07/11/2013 14:59, Chris Hegarty wrote:
Given bo
On 11/07/2013 11:04 AM, Alan Bateman wrote:
On 07/11/2013 14:59, Chris Hegarty wrote:
Given both Michael and Alan's comments. I've update the webrev:
http://cr.openjdk.java.net/~chegar/fileUtils.01/webrev/
1) more descriptive method names
2) deleteXXX methods return if interrupted, leaving t
Changeset: 6ea1f9d8ec78
Author:dxu
Date: 2013-11-06 13:25 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ea1f9d8ec78
8025698: (fs) Typo in exception thrown by encode() in UnixPath.java
Reviewed-by: dxu, mduigou, henryjen, weijun
Contributed-by: ajuc...@gmail.com
! src/solar
Changeset: 6d1f3ba68db2
Author:dxu
Date: 2013-11-04 15:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d1f3ba68db2
8027612: java/io/File/MaxPathLength.java fails intermittently in the clean-up
stage
Reviewed-by: chegar
! test/java/io/File/MaxPathLength.java
Changeset: 6a6faa00acc4
Author:dxu
Date: 2013-11-01 14:40 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a6faa00acc4
8027624: com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again
Reviewed-by: wetmore
! test/com/sun/crypto/provider/KeyFactory/TestProviderL
Changeset: e93de88661ab
Author:dxu
Date: 2013-10-31 11:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e93de88661ab
8027155: test/java/io/File/NulFile.java failing when test run in othervm mode
Reviewed-by: mchung, alanb
! test/java/io/File/NulFile.java
Changeset: c9562ac9b812
Author:dxu
Date: 2013-10-23 22:30 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9562ac9b812
7122887: JDK ignores Gnome3 proxy settings
Summary: Fix GConf and add to use GProxyResolver to handle network proxy
resolution
Reviewed-by: chegar
! src/sol
-Dan
On 10/23/2013 11:28 AM, Dan Xu wrote:
You are right, Chris. The java class objects initialization should be
in the init method. I will update it now. Thanks for the review!
-Dan
On 10/23/2013 11:21 AM, Chris Hegarty wrote:
Hi Dan,
Firstly, thank you for working on this. This is really
vaClass to
Java_sun_net_spi_DefaultProxySelector_getSystemProxy. I think it
should be in Java_sun_net_spi_DefaultProxySelector_init, so it is
executed just once.
-Chris.
On 10/22/2013 08:30 PM, Dan Xu wrote:
Hi All,
Please review the fix towards gnome proxy settings. In the recent Gnome
versions, it has phased out GConf and swithed to use
Hi All,
Please review the fix towards gnome proxy settings. In the recent Gnome
versions, it has phased out GConf and swithed to use GSettings to handle
all the system configurations. But in JDK, we are still use GConf-based
proxy resolution, which generates wrong results in the latest linux
Changeset: cb373cf43294
Author:dxu
Date: 2013-10-11 09:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb373cf43294
8025712: (props) Possible memory leak in java_props_md.c / ParseLocale
Reviewed-by: naoto, chegar
! src/solaris/native/java/lang/java_props_md.c
Changeset: 754db1268be1
Author:dxu
Date: 2013-09-27 17:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/754db1268be1
8025128: File.createTempFile fails if prefix is absolute path
Summary: Use only the file name from the supplied prefix for backward
compatibility
Reviewed-by
Changeset: 5b01c851bb1d
Author:dxu
Date: 2013-08-30 16:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b01c851bb1d
8023765: Improve MaxPathLength.java testcase and reduce its test load
7160013: java/io/File/MaxPathLength.java fails
Reviewed-by: alanb
! test/ProblemList.tx
Changeset: 5bf4f285
Author:dxu
Date: 2013-08-29 10:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bf4f285
4792059: test/java/io/pathNames/GeneralSolaris.java fails on symbolic links
Summary: Exclude the possible usage of linked files or directories in the test
Rev
Changeset: 8a7d9cc2f41c
Author:dxu
Date: 2013-08-22 11:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7d9cc2f41c
8023430: Replace File.mkdirs with Files.createDirectories to get
MaxPathLength.java failure details
Reviewed-by: alanb
! test/ProblemList.txt
! test/java/io
Changeset: 2fd841fccb2e
Author:dxu
Date: 2013-08-19 12:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2fd841fccb2e
8023203: Wrap RandomAccessFile.seek native method into a Java helper method
Reviewed-by: alanb, chegar
! make/java/java/mapfile-vers
! makefiles/mapfiles/lib
Changeset: 0d27309a87e0
Author:dxu
Date: 2013-08-15 14:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d27309a87e0
8017109: Cleanup overrides warning in
src/solaris/classes/sun/print/AttributeClass.java
Reviewed-by: jgodinez
! src/solaris/classes/sun/print/AttributeClass
Changeset: 5bb196aa183c
Author:dxu
Date: 2013-08-15 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bb196aa183c
4858457: File.getCanonicalPath() throws IOException when invoked with "nul"
(win)
Reviewed-by: alanb
! src/windows/native/java/io/canonicalize_md.c
! test/j
Changeset: 03822f2389bf
Author:dxu
Date: 2013-08-09 10:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/03822f2389bf
8021977: Opening a file using java.io can throw IOException on Windows
Summary: Remove IOException related error-handling code for backward
compatibility
Rev
Changeset: d1c82d5bee3f
Author:dxu
Date: 2013-08-07 12:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1c82d5bee3f
8022554: Fix Warnings in sun.invoke.anon Package
Reviewed-by: darcy, mduigou, lancea
! src/share/classes/sun/invoke/anon/ConstantPoolPatch.java
Changeset: 1d21ff5c2b3f
Author:dxu
Date: 2013-08-06 18:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d21ff5c2b3f
8022478: Fix Warnings In sun.net.www.protocol.http Package
Reviewed-by: darcy
! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java
! src/share/c
Hi All,
Please review the [serial] warning fix inside sun.net.www.protocol.http
package.
Webrev: http://cr.openjdk.java.net/~dxu/8022478/webrev/
Thanks,
-Dan
Changeset: 4b8b811059db
Author:dxu
Date: 2013-08-06 14:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b8b811059db
8022410: Fix Javac Warnings in com.sun.security.auth Package
Reviewed-by: darcy
! src/share/classes/com/sun/security/auth/PolicyFile.java
! src/share/classes
Changeset: 10d2a4b1e576
Author:dxu
Date: 2013-07-11 13:40 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/10d2a4b1e576
8017212: File.createTempFile requires unnecessary "read" permission
Summary: Directly call FileSystem method to check a file existence. Also
reviewed by tom.
Changeset: eabcb85fcabc
Author:bpb
Date: 2013-06-24 14:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eabcb85fcabc
6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1
throws ArrayOutOfBoundsException
Summary: For zero value ensure than an unpadded z
Changeset: f6d72c4f6bf1
Author:dxu
Date: 2013-06-19 13:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6d72c4f6bf1
8016592: Clean-up Javac Overrides Warnings In
javax/management/NotificationBroadcasterSupport.java
Summary: Add hashCode() methods to ListenerInfo and Wildca
Changeset: 4a66dd1d7eea
Author:dxu
Date: 2013-06-10 11:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a66dd1d7eea
8013827: File.createTempFile hangs with temp file starting with 'com1.4'
8011950: java.io.File.createTempFile enters infinite loop when passed invalid
data
R
Changeset: f522bbdf2859
Author:dxu
Date: 2013-05-31 13:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f522bbdf2859
8015628: Test Failure in closed/java/io/pathNames/GeneralSolaris.java
Reviewed-by: alanb
! test/java/io/pathNames/General.java
! test/java/io/pathNames/Gener
Changeset: e59d7f0f36f7
Author:ewang
Date: 2013-05-28 22:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e59d7f0f36f7
8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently
Reviewed-by: dxu, alanb
Contributed-by: yiming.w...@oracle.com
! test/java/io/pa
Changeset: 3b1450ee2bb9
Author:dxu
Date: 2013-05-17 12:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b1450ee2bb9
8011136: FileInputStream.available and skip inconsistencies
Summary: Correct the behavior of available() and update related java specs for
available() and sk
Changeset: bd118033e44c
Author:dxu
Date: 2013-05-06 14:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd118033e44c
8003992: File and other classes in java.io do not handle embedded nulls properly
Summary: Have every file operation done with File, FileInputStream,
FileOutp
Changeset: 785f3a04ee05
Author:dxu
Date: 2013-04-05 17:15 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/785f3a04ee05
8011602: jobjc build failure on Mac
Summary: Remove @Native annotation from
macosx/native/jobjc/src/core/java/com/apple/jobjc/Coder.java
Reviewed-by: mchung,
Changeset: 7b1189bf1d7b
Author:dxu
Date: 2013-04-04 15:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b1189bf1d7b
8000406: change files using @GenerateNativeHeader to use @Native
Summary: Use @Native annotation to mark constants interested by native codes
Reviewed-by: ala
Changeset: 49602f599c08
Author:dxu
Date: 2013-03-27 09:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49602f599c08
8010837: FileInputStream.available() throw IOException when encountering
negative available values
Summary: Remove the check in the native code to allow nega
Changeset: ef0c60b93a17
Author:dxu
Date: 2013-03-13 14:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef0c60b93a17
8001334: Remove use of JVM_* functions from java.io code
Summary: Replace JVM_* functions with direct system calls in java io area
Reviewed-by: alanb, uta, ma
Changeset: 30e30ef6077e
Author:dxu
Date: 2013-03-01 14:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30e30ef6077e
8006645: TEST_BUG: java/nio/file/Files/CopyAndMove.java failing intermittently
(sol)
Summary: Fix test failures and update java doc of Files.move
Reviewed-by
47 matches
Mail list logo
