Redirecting to net-dev
On Sat, Jan 22, 2022 at 11:00 AM Alan Bateman
wrote:
> On 22/01/2022 08:40, Thomas Stüfe wrote:
> > Hi Micheal,
> >
> > welcome, and thank you for your contribution!
> >
> > I opened a bug id for you to track this:
> > https://bugs.
Looks good to me. Thanks for checking.
Cheers, Thomas
On Fri, Aug 28, 2020 at 1:25 PM Alexander Scherbatiy <
alexander.scherba...@bell-sw.com> wrote:
> Hello,
>
> Could you review the updated fix:
>http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/
>
> - moving shared code to net_util_
Looks good.
Cheers, Thomas
On Wed, Sep 11, 2019 at 4:29 PM Baesken, Matthias
wrote:
> Hello, please review this small fix .
>
> It adds a missing ReleaseStringUTFChars in an early return case in
> function Java_java_net_NetworkInterface_getByName0
>
> (unix only) .
>
>
>
> Bug/webrev :
Thanks, Christoph!
On Tue, Mar 26, 2019, 9:41 AM Langer, Christoph
wrote:
> Hi Thomas,
>
>
>
> looks good 😊
>
>
>
> Christoph
>
>
>
> *From:* net-dev *On Behalf Of *Thomas
> Stüfe
> *Sent:* Montag, 25. März 2019 14:15
> *To:* net-dev
> *Subj
Hi all,
please review this tiny fix to a windows 32 build warning:
Issue: https://bugs.openjdk.java.net/browse/JDK-8221406
cr:
http://cr.openjdk.java.net/~stuefe/webrevs/8221406-windows32-buildfixes-networkinterface_winxp.c/webrev.00/webrev/
Thanks, Thomas
Hi all,
Following David's suggestion, I withdraw this bug and will open issues for
each area separately.
Cheers, Thomas
On Mon, Mar 25, 2019 at 1:44 PM Thomas Stüfe
wrote:
> Hi David,
>
> Updating vs2017 did not help :/
>
> Cheers, Thomas
>
> On Mon, Mar 25, 20
Hi David,
Updating vs2017 did not help :/
Cheers, Thomas
On Mon, Mar 25, 2019 at 8:17 AM David Holmes
wrote:
> Hi Thomas,
>
> On 25/03/2019 5:01 pm, Thomas Stüfe wrote:
> > Hi David,
> >
> > (added net-dev, awt-dev, security-dev since part of these fixes are in
>
Hi David,
(added net-dev, awt-dev, security-dev since part of these fixes are in
their territory)
On Mon, Mar 25, 2019 at 1:34 AM David Holmes
wrote:
> Hi Thomas,
>
> A few queries, comments and concerns ...
>
> On 25/03/2019 6:58 am, Thomas Stüfe wrote:
> > Hi all,
> &
Thanks for clarifying!
Thomas
On Wed, Sep 26, 2018, 14:20 Baesken, Matthias
wrote:
> Hi Thomas, I think your understanding is correct :
>
> "#ifdef "
>
> or
>
> "#if defined()"
>
> Are ok while
>
> "#if "
>
> or
>
> "#elif "
>
> Lead to the compile error on gcc with current warnings.
>
> Best
On Wed, Sep 26, 2018 at 11:51 AM, Alan Bateman wrote:
>
>
> On 26/09/2018 10:24, Baesken, Matthias wrote:
>>
>>
>> Hello, please review this small build fix .
>>
>> After the recent changes to the gcc compile flags with 8211029,
>> most of our Linux builds stopped working .
>>
>> Error :
t;
> Bug :
>
> https://bugs.openjdk.java.net/browse/JDK-8210147
>
> Thanks , Matthias
>
>
>
>> -Original Message-
>> From: Thomas Stüfe
>> Sent: Mittwoch, 29. August 2018 11:22
>> To: Baesken, Matthias
>> Cc: net-dev
>> Subject: Re: 82
rds, Thomas
>
> Btw I opened a bug :
>
> https://bugs.openjdk.java.net/browse/JDK-8210147
>
> for the issues .
>
> Best regards, Matthias
>
>
>
>> -Original Message-
>> From: Thomas Stüfe
>> Sent: Dienstag, 28. August 2018 18:33
>> To: Ba
IcmpCloseHandle(hIcmpFile);
> 329NET_ThrowNew(env, WSAGetLastError(), "Unable to allocate memory");
> 330return JNI_FALSE;
> 331}
>
>
Yes, this may be wrong if WSAGetLastError() uses GetLastError()
internally, so I would move the WSAGetLastError()
Hi Matthias,
not strictly necessary, since WSAGetLastError() only refers to socket
calls and GetIntField() is unlikely to call socket functions...
However, I think your proposal is fine for code cleanliness sake.
Best Regards, Thomas
On Tue, Aug 28, 2018 at 2:13 PM, Baesken, Matthias
wrote:
> H
+1. Please fix this for Linux! Thanks.
On Mon, Jul 2, 2018 at 11:03 AM, Langer, Christoph
wrote:
> Hi Matthias,
>
> forwarding to serviceability-dev, because debugging is usually discussed
> there.
>
> Yes, I would think this coding should be fixed, too. Can you open a bug and
> prepare a chang
Hi Matthias,
On Fri, Jun 22, 2018 at 3:08 PM, Baesken, Matthias
wrote:
> Hello Alan, Thomas , I adjusted the line lengths and created a new webrev
> :
>
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8205342.1/
>
>
>
> I considered replacing the 100 for error_msg_buf size by a define
t;
> Best regards, Matthias
>
>> -Original Message-
>> From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
>> Sent: Mittwoch, 20. Juni 2018 10:26
>> To: Baesken, Matthias
>> Cc: net-dev@openjdk.java.net
>> Subject: Re: RFR: 820534
Hi Matthias,
thanks, good catch about the leak.
But could you not just simply free the error_msg_buf after the call to
JNU_ThrowByName?
JNU_ThrowByName copies the message string, so no need to keep it alive
afterwards:
diff -r e810abb27deb
src/java.base/windows/native/libnet/NetworkInterface_wi
[2] http://pubs.opengroup.org/onlinepubs/009695399/functions/gethostname.html
> [3] http://man7.org/linux/man-pages/man3/getnameinfo.3.html
> [4] http://pubs.opengroup.org/onlinepubs/9699919799/functions/getnameinfo.html
>
>
>> -Original Message-
>> From: vyom t
On Fri, Apr 27, 2018 at 5:57 AM, vyom tewari wrote:
> Hi Christoph,
>
>
> On Tuesday 24 April 2018 04:45 PM, Langer, Christoph wrote:
>
> Hi Vyom,
>
> I think, it is intentional to handle case where return "hostname" is to
> large to
> fit in array. if you see the man page(http://man7.org/linux/
On Fri, Apr 27, 2018 at 7:02 AM, Thomas Stüfe wrote:
> Hi Christoph,
>
> code change makes sense. +1 on the "sizeof()" arg change.
>
> I would prefer it though if you would move the zero-termination out of
> the if/else altogether.
Disregard this last comment. What
Hi Christoph,
code change makes sense. +1 on the "sizeof()" arg change.
I would prefer it though if you would move the zero-termination out of
the if/else altogether.
Best Regards, Thomas
On Tue, Apr 24, 2018 at 11:38 AM, Langer, Christoph
wrote:
> Hi,
>
>
>
> please help reviewing a small c
Thanks guys!
I requested a fix for jdk9. Lets see how that goes.
Best Regards, Thomas
On Wed, May 17, 2017 at 5:17 PM, Vyom Tewari wrote:
> Hi Thomas,
>
> fix look good to me, but i am not jdk10 reviewer.
>
> Thanks,
>
> Vyom
>
>
> On Tuesday 16 May 2017 06:20 P
Hi all,
may I have a review for this tiny fix:
Issue: https://bugs.openjdk.java.net/browse/JDK-8180424
webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8180424-another-build-issue-on-aix-after-8034174/webrev.00/webrev/
The prototypes for NET_RecvFrom and NET_Accept do not match their
implement
much interest. I will refrain from filing a JIRA issue to track
> potential
> changes in the VM for this. Others are welcome to do so, if they wish. I
> suggest that we simply continue to pass a valid JNIEnv, since it is not
> much extra effort to do so. ( this can be refactore
00
> +++ b/src/share/vm/prims/jvm.hTue Apr 18 08:40:25 2017 +0530
> @@ -119,6 +119,9 @@
> JNIEXPORT jlong JNICALL
> JVM_NanoTime(JNIEnv *env, jclass ignored);
>
> +JNIEXPORT jlong
> +JVM_CurrentTimeNano();
> +
> JNIEXPORT jlong JNICALL
> JVM_GetNanoTimeAdjustment(JNIEnv
Hi Vyom,
Thank you for fixing this!
In addition to Rogers remarks:
aix_close.c:
Could you please also update the SAP copyright?
style nit:
+//nanoTimeout has to be >= 1 millisecond to iterate again.
I thought we use old C style comments? Could you please leave a space
between commen
On Fri, Dec 23, 2016 at 4:57 PM, Chris Hegarty
wrote:
>
> On 23 Dec 2016, at 15:06, Thomas Stüfe wrote:
>
> On Fri, Dec 23, 2016 at 11:25 AM, Volker Simonis > wrote:
>
>> On Thu, Dec 22, 2016 at 9:41 PM, Thomas Stüfe
>> wrote:
>> > ...
>> > 1)
On Fri, Dec 23, 2016 at 11:25 AM, Volker Simonis
wrote:
> On Thu, Dec 22, 2016 at 9:41 PM, Thomas Stüfe
> wrote:
> > Hi Arno,
> >
> > good job, this is a nice addition!
> >
> > Some remarks/questions (not a full review):
> >
> > 1) The naming o
Hi Arno,
good job, this is a nice addition!
Some remarks/questions (not a full review):
1) The naming of the unix...DefaultProxySelector.c is confusing. Could we
rename it to gnome/../DefaultProxySelector?
2) DefaultProxySelector.java
- style nit: "that list will most of the time" -> "that lis
30 matches
Mail list logo
