On Wed, 8 Jun 2022 17:49:38 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> clean up Calendar
Running tests and awaiting review from security team. Our internal test system
is backlogged an
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Reviewers for i18n, net, nio, and security, please review call site changes in
your areas.
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> java.xml.crypto's usage downgrade grammar to 1.8
I've also written a relea
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> java.xml.crypto's usage downgrade grammar to 1.8
Marked as reviewed by sma
On Thu, 14 Apr 2022 20:16:38 GMT, Sean Mullan wrote:
>>> Are the changes necessary for this part?
>>
>> @seanjmullan no, they are just performance refinement.
>>
>> If you really that wanna 100% sync ,
>>
>> I can use the old 1.8 api to migrate that part, and make a mirror pr to that
>> part
On Thu, 14 Apr 2022 19:53:45 GMT, Bradford Wetmore wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add `@LastModified: Apr 2022` to DocumentCache
>
> I learned something new about HashMap today...
>
> I looked at jav
On Wed, 13 Apr 2022 20:06:34 GMT, Naoto Sato wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes in:
>> src/java.desktop
>> src/java.management
>> src/jdk.internal.vm.ci
>> src/jdk.jfr
>> src/jdk.
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.base/unix/classes/java/lang/ProcessEnvironmen
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.xml/share/classes/com/sun/org/apache/xerces/i
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.xml/share/classes/com/sun/org/apache/xalan/in
On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
src/java.base/share/classes/java/lang/Character.java l
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in:
> src/java.desktop
> src/java.management
> src/jdk
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote:
>> Here are the code changes for the "Deprecate finalizers in the standard Java
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
>> review.
>>
>> This change makes the indicated deprecations, and updates the API
On Tue, 5 Jan 2021 21:02:21 GMT, Joe Darcy wrote:
> Back in JDK 16, two unintended default constructors were identified and
> deprecated for removal. The time has come to remove them.
>
> Please also review the corresponding CSRs:
>
> JDK-8258521 Remove terminally deprecated constructor in GSS
On Sun, 4 Oct 2020 11:55:50 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> I believe this changes is useful and still actual:
> 1. improve code to make it easier to read.
> 2. performance should be improved a bit too
I’ll
On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore wrote:
>> Ok, sorry for the distraction.
>
> Our local Santuario maintainer says:
>
> In general, changes to Apache Santuario should also be made at Apache so we
> stay in sync.
Hi @doom369, I hope we didn't end up wasting too much of your tim
On 5/23/19 6:39 AM, Langer, Christoph wrote:
big thanks for your great updates here. This all looks a lot cleaner:
http://cr.openjdk.java.net/~clanger/webrevs/8223553.3/
Great, glad to help. While I'm still unsure about the underlying reasons for
this disagreement between the compilers, th
Hi Christoph,
I'm still not entirely sure why this is so, but the introduction of a local
variable in MethodHandles.java seems to make things work for Eclipse. Addition
of a local variable seems to be minimally invasive, so it makes sense to see if
this technique can be applied to other cases.
On 5/14/19 9:16 PM, Martin Buchholz wrote:
src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java
Regarding the change in this particular file, I'd suggest the following:
diff -r 006dadb903ab -r 92e1fdce45e0
src/java.base/share/classes/java/util/concurrent/ConcurrentS
Hi Daniel,
Thanks for looking at this old bug.
I'm concerned about the approach of looking in the filesystem to determine how
to parse the URL. If that's the case, then it's no longer possible to look at
just the URL string and determine what it represents. Instead, it's possible
that differe
Changeset: 6c343d3d2721
Author:smarks
Date: 2013-12-13 18:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c343d3d2721
8027536: rmic: add deprecation warning message when generating JRMP static
stubs/skeletons
Reviewed-by: mchung, dmocek
! src/share/classes/sun/rmi/rmic/M
Changeset: c6b6b515cf4f
Author:smarks
Date: 2013-12-03 18:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6b6b515cf4f
8029489: StringJoiner spec for setEmptyValue() and length() is malformatted
Reviewed-by: darcy, lancea, mduigou
! src/share/classes/java/util/StringJoiner
Changeset: accd6ffd4b3f
Author:smarks
Date: 2013-12-03 15:52 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/accd6ffd4b3f
8028757: CharSequence.subSequence improperly requires a "new" CharSequence be
returned
Reviewed-by: alanb, darcy, mduigou
! src/share/classes/java/lang/C
Changeset: df819e356901
Author:tyan
Date: 2013-12-03 14:36 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df819e356901
7190106: java/rmi/reliability/benchmark fails intermittently because of use of
fixed port
Reviewed-by: smarks, mduigou
! test/ProblemList.txt
! test/java/r
Changeset: 4bc37b6c4133
Author:smarks
Date: 2013-11-21 16:02 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bc37b6c4133
7174936: several String methods claim to always create new String
Reviewed-by: dholmes, bchristi, alanb, lancea
! src/share/classes/java/lang/String.java
Changeset: 19d2e9649138
Author:smarks
Date: 2013-11-19 15:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19d2e9649138
8028638:
java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails
Reviewed-by: lancea
! test/java/rmi/testlibrary/RMID.java
Changeset: f6012ca3bdd3
Author:smarks
Date: 2013-11-12 16:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6012ca3bdd3
8028027: serialver should emit declaration with the 'private' modifier
Reviewed-by: darcy, mchung, alanb, chegar
! src/share/classes/sun/tools/serialver/S
Changeset: 1ea1b24c1a04
Author:smarks
Date: 2013-10-30 18:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ea1b24c1a04
8023863: deprecate support for statically-generated stubs from RMI (JRMP)
4449028: exportObject() javadoc should specify behavior for null socket
factorie
Changeset: 8ea272253285
Author:smarks
Date: 2013-10-25 14:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8ea272253285
5063500: Formatter spec says "char" is not an integral type
7126305: Wrong Unicode value specified for format conversion character 'd'
8027287: incorrect e
Changeset: 808b9ef4f667
Author:smarks
Date: 2013-10-24 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/808b9ef4f667
8023862: deprecate HTTP proxying from RMI
Reviewed-by: mchung
! src/share/classes/java/rmi/server/RMISocketFactory.java
! src/share/classes/java/rmi/serve
Changeset: 9fbf35589211
Author:smarks
Date: 2013-10-22 14:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fbf35589211
8026427: deprecate obsolete APIs from java.rmi
Reviewed-by: alanb, dfuchs
! src/share/classes/java/rmi/RMISecurityManager.java
! src/share/classes/java/rm
Changeset: 6731ea9123f2
Author:smarks
Date: 2013-09-09 14:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6731ea9123f2
8023447: change specification to allow RMI activation to be optional
Reviewed-by: darcy, alanb, olagneau
! src/share/classes/java/rmi/activation/Activatab
Changeset: 7496ec8bab76
Author:smarks
Date: 2013-08-22 15:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7496ec8bab76
8022445: fix RMISocketFactory example to avoid using localhost
Reviewed-by: chegar, alanb
! src/share/classes/java/rmi/server/RMISocketFactory.java
Changeset: 8c50c27418d3
Author:smarks
Date: 2013-08-07 16:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c50c27418d3
8022479: clean up warnings from sun.tools.asm
Reviewed-by: lancea, darcy
! src/share/classes/sun/tools/asm/Assembler.java
! src/share/classes/sun/tools/as
Changeset: 31e923842d49
Author:smarks
Date: 2013-08-06 14:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31e923842d49
8022440: suppress deprecation warnings in sun.rmi
Reviewed-by: mduigou
! src/share/classes/sun/rmi/runtime/Log.java
! src/share/classes/sun/rmi/server/Act
Changeset: 12c1b78acf9a
Author:lagergren
Date: 2013-08-06 12:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12c1b78acf9a
8022412: Fixed warnings in java.util root, except for HashMap
Reviewed-by: mduigou, darcy
Contributed-by: marcus.lagerg...@oracle.com
! src/share/class
Changeset: 31759750ff63
Author:smarks
Date: 2013-08-05 19:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31759750ff63
8020854: change RMI javadocs to specify that remote objects are exported to the
wildcard address
Reviewed-by: rgallard, alanb
! src/share/classes/java/rm
On 8/2/13 2:37 AM, Chris Hegarty wrote:
On 01/08/2013 22:18, Stuart Marks wrote:
SocketAddress overloads. Two of them were within methods that declared
"throws Exception." The third was within a try/catch block that catches
IOException. None of the three cases would suffe
On 7/31/13 2:39 PM, Matthew Hall wrote:
On Wed, Jul 31, 2013 at 02:38:26PM -0700, Stuart Marks wrote:
The alternative is to add "@throws SocketException never" to the
javadoc, just to get rid of the doclint warning, but this has the
consequence of requiring people to keep dead c
On 7/29/13 7:28 AM, Chris Hegarty wrote:
There are two remaining doclint warnings in the java.net package.
>:javac -Xdoclint:all/protected src/share/classes/java/net/DatagramPacket.java
src/share/classes/java/net/DatagramPacket.java:142: warning: no @throws for
java.net.SocketException
pu
Changeset: 09a77a1bdbc3
Author:henryjen
Date: 2013-07-30 15:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09a77a1bdbc3
8020977: StringJoiner merges with itself not as expected
Reviewed-by: psandoz, chegar, mduigou, smarks
! src/share/classes/java/util/StringJoiner.java
!
On 6/27/13 4:58 PM, Brad Wetmore wrote:
Chris (and Michael),
As my part of the "intermittently failing test cleanup," I'm looking into a
test of yours that has been intermittently failing.
It's bug:
https://jbs.oracle.com/bugs/browse/JDK-8017333
The open URL to view this bug is:
ht
Changeset: 6729f7ef94cd
Author:smarks
Date: 2013-06-27 13:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6729f7ef94cd
8019224: add exception chaining to RMI CGIHandler
Reviewed-by: darcy
! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java
Changeset: b9587f41fd55
Author:smarks
Date: 2013-06-18 17:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9587f41fd55
8016780: README-builds.html misses crucial requirement on bootstrap JDK
Reviewed-by: dholmes, chegar
! README-builds.html
Changeset: c18f28312c49
Author:smarks
Date: 2013-01-22 18:30 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c18f28312c49
8005646: TEST_BUG:
java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup leaves
process running
Reviewed-by: mchung
! test/java/rmi/activ
Changeset: 79fed1733d4a
Author:jgish
Date: 2013-01-17 15:09 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79fed1733d4a
8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't
retry enough times
Summary: Increase number of retries to twice the number
Changeset: 13ff1089e625
Author:jgish
Date: 2013-01-10 15:09 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13ff1089e625
8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures
Summary: Remove file-deletion code at cleanup which conflicts with jtreg cleanup
Changeset: 797e8a3dcd51
Author:smarks
Date: 2013-01-07 18:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/797e8a3dcd51
7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails
intermittently
Summary: Tighten up JavaVM test library API, and adjust tests to ma
Changeset: 92c3b24a8e9a
Author:smarks
Date: 2013-01-04 16:10 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92c3b24a8e9a
8005683: ProblemList.txt updates (01/2013)
Reviewed-by: mchung, alanb
Contributed-by: amy...@oracle.com
! test/ProblemList.txt
Changeset: cc78ceb99284
Author:jgish
Date: 2012-12-28 16:56 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc78ceb99284
8005118: Javadoc styles are inconsistent
Summary: use a common javadoc style in the String classes
Reviewed-by: darcy
! src/share/classes/java/lang/Abstrac
Changeset: 0cfcba56cfa7
Author:jgish
Date: 2012-12-28 18:32 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cfcba56cfa7
8005594: Fix to 8003265 breaks build
Summary: backout changeset 4472a641b4dc
Reviewed-by: smarks, wetmore
! src/share/classes/com/sun/jndi/dns/DnsContext.j
Changeset: 60adb69bf043
Author:smarks
Date: 2012-12-20 20:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60adb69bf043
8005290: remove -showversion from RMI test library subprocess mechanism
Reviewed-by: jgish, chegar, dmocek
! test/java/rmi/testlibrary/JavaVM.java
! test/
Changeset: 56fd5479a98f
Author:jgish
Date: 2012-12-12 15:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56fd5479a98f
8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete
file (win)
Summary: Failure to delete test log file should be a warning instea
Changeset: a971516029ab
Author:jgish
Date: 2012-12-05 21:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a971516029ab
8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception
not reported
Reviewed-by: alanb, dmocek, smarks
! test/java/rmi/testlibrary
Changeset: 7ccf93c60c4d
Author:smarks
Date: 2012-11-29 14:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ccf93c60c4d
8004134: More ProblemList.txt updates (11/2012)
Reviewed-by: alanb
Contributed-by: amy...@oracle.com
! test/ProblemList.txt
Changeset: 83d9f30ebeed
Author:smarks
Date: 2012-11-28 17:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83d9f30ebeed
8004131: move jdi tests out of core testset
Reviewed-by: alanb, chegar
! make/jprt.properties
Changeset: ab1ab9b148dd
Author:smarks
Date: 2012-11-28 17:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/ab1ab9b148dd
8004131: move jdi tests out of core testset
Reviewed-by: alanb, chegar
! make/jprt.properties
Changeset: 1f7c783e4f13
Author:dxu
Date: 2012-08-31 13:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f7c783e4f13
7193406: Clean-up JDK Build Warnings in java.util, java.io
Summary: Clean-up JDK Build Warnings in java.util, java.io Packages
Reviewed-by: smarks, darcy, kha
Changeset: f9b11772c4b2
Author:smarks
Date: 2012-08-30 18:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9b11772c4b2
7195099: update problem list with RMI test failures
Reviewed-by: alanb
! test/ProblemList.txt
Changeset: 8a82e5f9c47f
Author:dmocek
Date: 2012-08-02 18:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a82e5f9c47f
7187876: ClassCastException in TCPTransport.executeAcceptLoop
Reviewed-by: dholmes, smarks
! src/share/classes/sun/rmi/transport/tcp/TCPTransport.java
Changeset: 018e555a7a07
Author:dmocek
Date: 2012-07-27 16:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/018e555a7a07
7186111: fix bugs in
java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup
Reviewed-by: smarks, jgish
! test/java/rmi/activation/Activatio
Changeset: 89129c0737f1
Author:dmocek
Date: 2012-07-18 10:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89129c0737f1
7184943: fix failing test
com/sun/jndi/rmi/registry/RegistryContext/UnbindIdempotent.java
7184946: fix failing test
com/sun/jndi/rmi/registry/RegistryCon
Changeset: b6f78869c66d
Author:dmocek
Date: 2012-07-17 11:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b6f78869c66d
7142596: RMI JPRT tests are failing
Summary: Changed RMI tests to use random port numbers for the RMI Registry and
RMID so the tests can be run concurrent
Changeset: 4ad204cc7433
Author:smarks
Date: 2012-07-05 15:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad204cc7433
7123972: test/java/lang/annotation/loaderLeak/Main.java fails intermittently
Reviewed-by: dholmes, smarks
Contributed-by: Eric Wang
! test/ProblemList.tx
Changeset: 97eb7a4b1fdd
Author:smarks
Date: 2012-07-05 15:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/97eb7a4b1fdd
6948101: java/rmi/transport/pinLastArguments/PinLastArguments.java failing
intermittently
Reviewed-by: dholmes, smarks
Contributed-by: Eric Wang
! test/
Changeset: b2fc66012451
Author:smarks
Date: 2012-07-02 14:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2fc66012451
7176907: additional warnings cleanup in java.util, java.util.regexp,
java.util.zip
Reviewed-by: forax, khazra, smarks
Contributed-by: Mani Sarkar
! src/
Changeset: 9df29b658145
Author:smarks
Date: 2012-06-29 16:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9df29b658145
7170938: (str) incorrect wording in doc for String.subSequence
Reviewed-by: forax, mduigou
Contributed-by: Joe Bowbeer
! src/share/classes/java/lang/Stri
Changeset: e309917fb9af
Author:dbhole
Date: 2012-05-24 19:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e309917fb9af
7117230: clean up warnings in java.text
Reviewed-by: jrose, smarks
! src/share/classes/java/text/AttributedCharacterIterator.java
! src/share/classes/java
Changeset: f131d4361faf
Author:olagneau
Date: 2012-05-11 14:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f131d4361faf
7144861: speed up RMI activation tests
Reviewed-by: alanb, smarks, dholmes, dmocek
! test/java/rmi/activation/checkusage/CheckUsage.java
! test/java/rmi
Changeset: 19c6ad447258
Author:dmocek
Date: 2012-04-04 15:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19c6ad447258
7159130: add java/rmi/transport/pinClientSocketFactory to problem list
Reviewed-by: smarks
! test/ProblemList.txt
Changeset: 445ada5e6b4a
Author:smarks
Date: 2012-02-12 21:56 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/445ada5e6b4a
7143230: fix warnings in java.util.jar, sun.tools.jar, zipfs demo, etc.
Reviewed-by: alanb, chegar, lancea, smarks
Contributed-by: Mani Sarkar , Michael Ba
Changeset: 3a7ea63302f8
Author:smarks
Date: 2011-12-29 16:39 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a7ea63302f8
7122061: add -Xlint:all -Werror to warning-free build steps
Reviewed-by: chegar, alanb, dholmes, ohair
! make/com/sun/demo/jvmti/hprof/Makefile
! make/com
Changeset: abbca81a98a7
Author:smarks
Date: 2011-12-17 08:21 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abbca81a98a7
7122235: stop the build if javac fails
Reviewed-by: chegar, dholmes, mcimadamore, ohair
! make/common/Rules.gmk
Changeset: 9bb7c3b97384
Author:smarks
Date: 2011-12-08 14:57 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bb7c3b97384
7118546: fix warnings in javax.xml.crypto, javax.script
Reviewed-by: mullan
! src/share/classes/javax/script/ScriptException.java
! src/share/classes/java
Changeset: 4f0f9f9c4892
Author:smarks
Date: 2011-12-07 12:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f0f9f9c4892
7117249: fix warnings in java.util.jar, .logging, .prefs, .zip
Reviewed-by: alanb, dholmes, forax, sherman, smarks
Contributed-by: Prasannaa , Martijn Verb
Changeset: 77f6d4360f4b
Author:smarks
Date: 2011-12-06 10:14 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77f6d4360f4b
7116997: fix warnings in java.util.PropertyPermission
Reviewed-by: smarks
Contributed-by: Brandon Passanisi
! src/share/classes/java/util/PropertyPermiss
Changeset: f4fe86bba8a2
Author:smarks
Date: 2011-12-05 16:30 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4fe86bba8a2
7116993: fix warnings in java.applet
Reviewed-by: art, smarks
Contributed-by: Danesh Dadachanji
! src/share/classes/java/applet/Applet.java
Changeset: 0e3f706741ca
Author:smarks
Date: 2011-12-01 16:14 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e3f706741ca
7116890: additional warnings fixes for java.io
Reviewed-by: alanb, smarks
Contributed-by: Sebastian Sickelmann
! src/share/classes/java/io/ExpiringCache.
Changeset: 43a630f11af6
Author:smarks
Date: 2011-11-30 13:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6
7116322: enhance javac make rule with a little bit of instrumentation
Reviewed-by: dholmes, ohair
! make/common/Rules.gmk
Changeset: 3f66f9ca1ba5
Author:smarks
Date: 2011-08-12 14:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f66f9ca1ba5
7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list
Reviewed-by: weijun, alanb
! test/ProblemList.txt
Changeset: 00f3997e6aeb
Author:smarks
Date: 2011-04-20 16:30 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/00f3997e6aeb
6896297: (rmi) fix ConcurrentModificationException causing TCK failure
Reviewed-by: alanb, dholmes, peterjones
! src/share/classes/sun/rmi/log/ReliableLog
Changeset: f326a018fd3f
Author:smarks
Date: 2011-03-24 17:26 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f326a018fd3f
7029680: fix test/sun/misc/Version/Version.java build parsing
Reviewed-by: ohair
! test/sun/misc/Version/Version.java
Changeset: 192bbf6cd5de
Author:smarks
Date: 2011-03-17 18:50 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/192bbf6cd5de
7022382: convert pack200 library code to use try-with-resources
Reviewed-by: ksrini
! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
! sr
Changeset: 98d2d57d9e73
Author:smarks
Date: 2011-03-01 15:05 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98d2d57d9e73
7022624: use try-with-resources in java.io tests
Reviewed-by: alanb
! test/java/io/File/SetLastModified.java
! test/java/io/FileOutputStream/AtomicAppend.
Changeset: 8887cb2f5d19
Author:smarks
Date: 2011-02-25 02:06 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8887cb2f5d19
7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: alanb, dholmes, sherman
! src/share/classes/java/util/jar/JarFile.java
! te
Changeset: b74f1b830484
Author:smarks
Date: 2011-02-24 22:26 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b74f1b830484
7022383: add reference to CR for ReadLongZipFileName test to problem list
Reviewed-by: ohair
! test/ProblemList.txt
Changeset: 84e339f1033b
Author:smarks
Date: 2011-02-22 15:34 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/84e339f1033b
7021209: convert lang, math, util to use try-with-resources
Reviewed-by: alanb, darcy, naoto
! src/share/classes/java/lang/Package.java
! src/share/classe
Changeset: 5bf920749b97
Author:smarks
Date: 2011-02-18 12:43 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5bf920749b97
7018385: update javax.sql classes to use try-with-resources
Reviewed-by: alanb, lancea, darcy
! src/share/classes/javax/sql/rowset/serial/SerialClob.java
Changeset: 6e33b377aa6e
Author:smarks
Date: 2011-02-16 18:22 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e33b377aa6e
7018392: update URLJarFile.java to use try-with-resources
Reviewed-by: alanb, chegar, hawtin
! src/share/classes/sun/net/www/protocol/jar/URLJarFile.java
Webrev is here:
http://cr.openjdk.java.net/~smarks/reviews/7018392/webrev.0/
This uses try-with-resources to close the InputStream reliably, and it uses
Files.copy() to avoid dealing directly with an OutputStream.
We had also discussed the circumstances when the temp file should be removed.
Changeset: d61d9bf190f5
Author:smarks
Date: 2011-01-14 15:31 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d61d9bf190f5
7012003: diamond conversion for ssl
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/CipherSuite.java
! src/share/classes/sun/security/ssl/Cipher
Changeset: a5a22f93e4c5
Author:smarks
Date: 2011-01-12 13:52 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5a22f93e4c5
7008713: diamond conversion of kerberos5 and security tools
Reviewed-by: weijun
! src/share/classes/sun/security/krb5/Config.java
! src/share/classes/sun/
Changeset: 6d0217114886
Author:smarks
Date: 2011-01-11 13:42 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6d0217114886
7011095: revert diamond changes from 6880112 that occur in method args
Reviewed-by: darcy, alanb
! src/share/classes/com/sun/java/util/jar/pack/BandStruct
Changeset: 2a0ff59928de
Author:smarks
Date: 2011-01-10 17:06 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a0ff59928de
7005608: diamond conversion of JCA and crypto providers
Reviewed-by: wetmore
! src/share/classes/java/security/Security.java
! src/share/classes/sun/secur
Changeset: 3dbc783a8073
Author:smarks
Date: 2011-01-07 15:39 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3dbc783a8073
7008728: diamond conversion of basic security, permissions, authentication
Reviewed-by: mullan
! src/share/classes/com/sun/security/auth/PolicyFile.java
!
Changeset: 449dfb061fde
Author:smarks
Date: 2010-12-20 13:47 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/449dfb061fde
6880112: Project Coin: Port JDK core library code to use diamond operator
Reviewed-by: darcy, lancea, alanb, briangoetz, mduigou, mchung
! src/share/class
96 matches
Mail list logo
