On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by the serviceability team
> (`java.instrument java.management.rmi java.management jdk.attach
> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
> jdk.jdwp.agent jdk.jstatd jdk.
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote:
> Reduce noise in test output by adding the @SuppressWarnings("removal")
> annotation (which has already been widely applied).
Marked as reviewed by sspitsyn (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7328
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Marked as reviewed by sspitsyn (Reviewer).
-
PR: https
On Thu, 18 Feb 2021 21:43:00 GMT, Alex Menkov wrote:
> The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
> The failures are caused by network configuration changes during test
> execution ("global" IPv6 addresses disappears from interface).
> To minimize chances of intermittent
Hi guys,
We need a couple of partial reviews for this enhancement:
- From the net-dev to check IPv6-addresses related part.
It does not need to be a thorough review.
We need another pair of eyes to check for obvious typos or misses.
Included Chris H. to mailing list in hope for some as
Hi Alex,
Thank you for creating the CSR!
I've added myself as a reviewer and corrected a couple of places.
Feel free to change my changes if necessary. :)
It would be nice to get one more CSR review if possible, so I've added
the net-dev mailing list.
I hope to finish the webrev review soon.
Hi Alex,
Thank you for the update!
One more round of minor formatting change requests for better
readability. :)
#1:
http://cr.openjdk.java.net/~amenkov/IPv6/webrev.03/src/jdk.jdi/share/classes/com/sun/tools/jdi/SocketTransportService.java.udiff.html
+ port = Integer.decode(h
Hi Alex,
Great debugging feature!
While I'm still reading all the details, could you, please, fix some
minor format issues?
http://cr.openjdk.java.net/~amenkov/IPv6/webrev.02/src/jdk.jdi/share/classes/com/sun/tools/jdi/SocketTransportService.java.udiff.html
+ * If host is a literal IPv6 addre
+1 (if you still need it)
Thanks,
Serguei
On 9/26/18 4:41 AM, David Holmes wrote:
That all seems fine to me.
Thanks for fixing.
David
On 26/09/2018 5:48 AM, Langer, Christoph wrote:
Hi Matthias,
looks good (and trivial). Ccing serviceability-dev because of change
in libjdwp.
Best regard
