On Thu, 25 Feb 2021 11:05:07 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes "no comment" warnings generated by
>> `javadoc -Xdoclint` for `java.base/java.net`
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last re
On Wed, 28 Oct 2020 17:07:04 GMT, Chris Hegarty wrote:
>> Igor Ignatyev has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - use UTC TZ for RFC3659_DATETIME_FORMAT
>> - run TestFtpTimeValue with different user.timezone
>
> Marked as review
On Wed, 28 Oct 2020 15:25:06 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this small and trivial fix?
>>
>> `sun/net/ftp/imp/FtpClient::dateFormats` is an array of `SimpleDateFormat`
>> which are shared among all instances of `FtpClient`. the fact that
>> `SimpleDateForm
On Wed, 28 Oct 2020 11:10:33 GMT, Daniel Fuchs wrote:
>> Igor Ignatyev has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - remove \n from MDTM response before parsing
>> - added leading 0 to the test
>> - use DateTimeFormatter instead
ThreadLocalURI.uriEncoderTest avgt 25 336.660 ± 2.997 ns/op
webrev:
https://cr.openjdk.java.net/~ryadav/webrev_8245308/webrev.01/index.html
- rahul
On 27/08/2020 15:58, Daniel Fuchs wrote:
Hi Rahul,
The code changes look good to me but the uriDecoderTest needs
some working. The reason is that the
/JDK-8245308
webrev: https://cr.openjdk.java.net/~ryadav/webrev_8245308/index.html
- rahul
Hi Chris,
Thanks for the feedback, this improves the test, i have included your
feedback and updated webrev.
- rahul
On 18/08/2020 14:28, Chris Hegarty wrote:
Rahul,
On 18 Aug 2020, at 10:21, Rahul Yadav wrote:
...
Issue: https://bugs.openjdk.java.net/browse/JDK-8251715
webrev: http
Good point Daniel, i have included the feedback , updated webrev.
- rahul
On 18/08/2020 10:39, Daniel Fuchs wrote:
Hi Rahul,
Looks fine to me - but just one detail in the test: maybe you should
use `expectThrows` rather than `assertThrows` and then double check
that the exception you get is
UncheckedIOException instead of InternalError,
in this case, when `SSLContext.getDefault()` fails due to unavailability
of underlying resources.
Issue: https://bugs.openjdk.java.net/browse/JDK-8251715
webrev: http://cr.openjdk.java.net/~ryadav/webrev_8251715/index.html
- rahul
/~ryadav/webrev_8248006/index.html
csr : https://bugs.openjdk.java.net/browse/JDK-8251198
- rahul
throw illegal("URI must not contain a fragment: " + uri);
352 return uri;
353 }
354
- rahul
On 26/06/2020 14:38, Pavel Rappo wrote:
Rahul,
Won't that start retaining the URL fragment? From
https://tools.ietf.org/html/rfc6455#section-3
Fragment identifiers a
://bugs.openjdk.java.net/browse/JDK-8245245
webrev: http://cr.openjdk.java.net/~ryadav/webrev_8245245/index.html
- rahul
://bugs.openjdk.java.net/browse/JDK-8245245
webrev: http://cr.openjdk.java.net/~ryadav/webrev_8245245/index.html
- rahul
/~ryadav/webrev_8247675/index.html
- rahul
Hi Daniel,
I have updated the copyright notice.
On 15/06/2020 16:23, Daniel Fuchs wrote:
Hi Rahul,
Sorry I didn't catch that earlier, but your test has the
wrong copyright notice. We do not have the "Classpath"
exception in tests.
best regards,
-- daniel
On 15/06/2020 11:
Hi Chris, Daniel
Thank you for the comments.
I have included the feedback and updated webrev.
http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html
- rahul
On 15/06/2020 10:28, Daniel Fuchs wrote:
Hi Rahul,
On 15/06/2020 09:52, Chris Hegarty wrote:
On 12 Jun 2020, at 17:55, Rahul
Hi Alan,
Thank you for the feedback.
I have updated the webrev.
http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html
- rahul
On 12/06/2020 16:57, Alan Bateman wrote:
On 12/06/2020 15:56, Rahul wrote:
Hello,
Request to have my fix reviewed for the issue:
JDK-8245307 : Update
ThreadLocal to be thread safe.
Issue: https://bugs.openjdk.java.net/browse/JDK-8245307
webrev: http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html
- rahul
ThreadLocal to be thread safe.
Issue: https://bugs.openjdk.java.net/browse/JDK-8245307
webrev: http://cr.openjdk.java.net/~ryadav/webrev_8245307/index.html
- rahul
Thanks Daniel
I would proceed with the push if there are no further comments.
On 13/05/2020, 12:39, "Daniel Fuchs" wrote:
Hi Rahul,
That looks good to me thanks!
I am still teetering on whether we should also have altered the
specification of WSHandshakeExce
by the websocket server
as part of the
websocket exception when the handshake is rejected by websocket server.
Issue: https://bugs.openjdk.java.net/browse/JDK-8244652
Webrev:
http://cr.openjdk.java.net/~ryadav/webrev_8244652/webrev.00/index.html
- rahul
Thanks Daniel , webrev updated.
- rahul
On 06/05/2020 16:16, Daniel Fuchs wrote:
Hi Rahul,
LGTM.
111 WebSocketHandshakeException wse =
(WebSocketHandshakeException) t;
112 out.println("Status code is " +
wse.getResponse().statusCod
Hi Pavel,
Thank you for the comment, the webrev has been updated.
webrev : http://cr.openjdk.java.net/~ryadav/webrev_8240666/webrev.00/index.html
- rahul
On 06/05/2020, 14:26, "Pavel Rappo" wrote:
An assertion of the form
assertEquals(true, ((String)wse.getRespo
discarding it,
when the handshake is rejected by the websocket server.
Issue: https://bugs.openjdk.java.net/browse/JDK-8240666
Webrev:
http://cr.openjdk.java.net/~ryadav/webrev_8240666/webrev.00/index.html
--rahul
Hi Chris,
Thank you for letting know, will update.
-- rahul
From: Chris Hegarty
Date: Monday 27 April 2020 at 17:00
To: Rahul , OpenJDK Network Dev list
Subject: Re: RFR 8242999: http/2 client may not handle continuation frames
correctly
Rahul,
On 27 Apr 2020, at 14:04, Rahul
Thanks for the review comments.
I have updated the webrev :
http://cr.openjdk.java.net/~pconcannon/rayayada/8242999/webrevs/webrev.01/
On 27/04/2020, 12:42, "Daniel Fuchs" wrote:
Hi Rahul,
That looks very good!
Thanks for taking that on.
Not related t
after a header
frame, this was not being handled earlier.
Issue: https://bugs.openjdk.java.net/browse/JDK-8242999
Webrev:
http://cr.openjdk.java.net/~pconcannon/rayayada/8242999/webrevs/webrev.00/
--rahul
Thanks for the review Daniel.
I have created a release note.
RN : https://bugs.openjdk.java.net/browse/JDK-8242387
--Rahul
On 08/04/2020, 16:00, "Daniel Fuchs" wrote:
Good work Rahul!
I am not sure whether that deserves a CSR (probably not) but we may
want
://bugs.openjdk.java.net/browse/JDK-8239594
Webrev:
http://cr.openjdk.java.net/~jboes/rayayada/webrevs/8239595/webrev.01/
-- Rahul
On 27/03/2020, 16:23, "net-dev on behalf of Xuelei Fan"
wrote:
On 3/27/2020 5:52 AM, Chris Hegarty wrote:
> Xuelei,
&g
The current fix does not affect the scenarios discussed earlier(that is
a broader discussion,may be a different bug/enhancement).
The scenarios would be vaild even if the fix would not have been in place.
-Rahul
On 27/03/2020 17:50, Chris Hegarty wrote:
Thank you for these clarifications. We
.00/
-- Rahul
.
Issue: https://bugs.openjdk.java.net/browse/JDK-8240921
Webrev:
http://cr.openjdk.java.net/~pconcannon/rayayada/8240921/webrevs/webrev.00/
- Rahul
.
Issue: https://bugs.openjdk.java.net/browse/JDK-8240921
Webrev:
http://cr.openjdk.java.net/~pconcannon/rayayada/8240921/webrev/webrev.00
<http://cr.openjdk.java.net/~pconcannon/rayayada/8240921/webrev/webrev.00,>
- Rahul
.
Issue: https://bugs.openjdk.java.net/browse/JDK-8240921
Webrev:
http://cr.openjdk.java.net/~pconcannon/rayayada/8240921/webrev/webrev.00,
- Rahul
34 matches
Mail list logo
