The test started failing after JDK-8243099.
JBS: https://bugs.openjdk.java.net/browse/JDK-8245518
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8245518/webrev.00/open/webrev/
Cheers,
Mikael
ld be fixed in webrev.01.
Cheers,
Mikael
>
>> On May 6, 2020, at 9:43 PM, Mikael Vidstedt > <mailto:mikael.vidst...@oracle.com>> wrote:
>>
>>
>> I have always wondered what “solinux” is supposed to mean - though not
>> enough to actually ask a
> On May 6, 2020, at 11:41 PM, Alan Bateman wrote:
>
> On 07/05/2020 05:56, Mikael Vidstedt wrote:
>> :
>>
>> * File follow-up enhancement for the removal of SO_FLOW_SA and
>> jdk.net.SocketFlow
> I've created JDK-8244582 to track this, we should
SocketImpl stuff is good as-is
Cheers,
Mikael
> On May 3, 2020, at 10:12 PM, Mikael Vidstedt
> wrote:
>
>
> Please review this change which implements part of JEP 381:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
> webrev:
> http://cr.openjdk.java.net/~mikae
> On May 5, 2020, at 5:42 AM, Daniel Fuchs wrote:
>
> Hi Mikael,
>
> I spotted another place where a residual reference to Solaris
> remains in a comment:
> src/java.base/unix/native/libnet/PlainSocketImpl.c
>
> 857 #if defined(_AIX)
> 858 if (errno == EINVAL) {
> 859 //
5/4/20 4:49 AM, Alan Bateman wrote:
>> On 04/05/2020 06:12, Mikael Vidstedt wrote:
>>> Please review this change which implements part of JEP 381:
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
>>> webrev:
>>> http://cr.openjdk.java.
> On May 4, 2020, at 9:27 AM, naoto.s...@oracle.com wrote:
>
> Hi Mikael,
>
> I took a look at i18n related files. It looks good overall.
>
> One nit in java/nio/charset/Charset/DefaultCharsetTest.java: If the test is
> only applicable to linux (@requires os.family == "linux" in jtreg tag af
> On May 4, 2020, at 2:33 PM, Brent Christian
> wrote:
>
> Hi,
>
> Looks fine to me. I have just one minor observation:
>
> src/java.base/share/native/libjli/emessages.h
>
> *** 92,102
> #define JRE_ERROR5 "Error: Failed to start a %d-bit JVM process from a
> %d-bit JVM."
> !
Thank you for reviewing, Max!
Cheers,
Mikael
> On May 4, 2020, at 7:22 AM, Weijun Wang wrote:
>
> There are several security-related files (name.contains("security")) and they
> all look fine.
>
> --Max
>
>
>> On May 4, 2020, at 1:12 PM, Mikae
Alan, thank you for the review! New webrev coming. Meanwhile comments inline..
> On May 4, 2020, at 1:49 AM, Alan Bateman wrote:
>
> On 04/05/2020 06:12, Mikael Vidstedt wrote:
>> Please review this change which implements part of JEP 381:
>>
>> JBS: https://bugs.
Please review this change which implements part of JEP 381:
JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/corelibs/open/webrev/
JEP: https://bugs.openjdk.java.net/browse/JDK-8241787
Note: When reviewing this, please
11 matches
Mail list logo
