Integrated: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-08 Thread Masanori Yano
On Wed, 2 Feb 2022 08:31:08 GMT, Masanori Yano wrote: > I added socket connection check same as IPv6_supported(). > Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 > uninstall`), and set property `-Djava.net.preferIPv4S

Re: RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-07 Thread Masanori Yano
On Wed, 2 Feb 2022 12:32:13 GMT, Alan Bateman wrote: >> I added socket connection check same as IPv6_supported(). >> Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 >> uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, >> java.net.InetAddress.PLATFORM_LOOKU

RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-02 Thread Masanori Yano
I added socket connection check same as IPv6_supported(). Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, java.net.InetAddress.PLATFORM_LOOKUP_POLICY.characteristics is always set to 1(IPv4), because IPv4_su

Withdrawn: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-10-28 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. This pull request has been closed without being i

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-10-28 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. Thank you for your reply. I understand we have no need t

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-10-18 Thread Masanori Yano
On Mon, 27 Sep 2021 08:04:23 GMT, Alan Bateman wrote: >> It’s a good idea to ask the Microsoft folks about that, but I don't know the >> way to ask. Could you tell me how to do it? >> >> As you say, CreateFile function is used in other parts of the JDK, but it >> have a significant impact to f

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-10-06 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. I inquired of the Microsoft Technical Support about thi

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-27 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. It’s a good idea to ask the Microsoft folks about that, bu

Integrated: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-09-24 Thread Masanori Yano
On Fri, 27 Aug 2021 08:37:46 GMT, Masanori Yano wrote: > Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-22 Thread Masanori Yano
On Thu, 16 Sep 2021 10:33:09 GMT, Daniel Fuchs wrote: >> I pushed a fix to run the test in othervm mode. Please test again. > > Meanwhile I did some experiment and was puzzled by the fact that the new test > still failed intermittently - while the corresponding > SctpMultiChannel/CloseDescripto

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v4]

2021-09-22 Thread Masanori Yano
> Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) Masanori Yano has updated the pull request i

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-17 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. Thank you for your comment. According to Microsoft

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v3]

2021-09-14 Thread Masanori Yano
> Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) Masanori Yano has updated the pull request i

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-14 Thread Masanori Yano
On Mon, 13 Sep 2021 13:18:10 GMT, Daniel Fuchs wrote: >> Masanori Yano has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

2021-09-13 Thread Masanori Yano
> Please review this change to the Unix implementations of > sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() > to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a > check for the ST_KILLED state.) Masanori Yano has updated the pull request with

Re: RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-09-13 Thread Masanori Yano
On Thu, 2 Sep 2021 14:24:24 GMT, Daniel Fuchs wrote: >> Please review this change to the Unix implementations of >> sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() >> to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a >> check for the ST_KILLED state.) > >

RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-10 Thread Masanori Yano
Could you please review the 8233674 bug fixes? This problem is caused by the antivirus software opening the file for a short time, so CreateFile() should be retried. - Commit messages: - 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file Chan

RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

2021-08-27 Thread Masanori Yano
Please review this change to the Unix implementations of sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a check for the ST_KILLED state.) - Commit messages: - 8238274: (sctp) JDK-7118373 is not