Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.

2009-08-22 Thread Mark Wielaard
Hi Andrew, On Fri, 2009-08-21 at 20:35 +0100, Andrew John Hughes wrote: > 2009/8/21 Mark Wielaard : > > On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: > >> This change was integrated prematurely. I've rolled it back in the > >> jdk7/tl/jdk repository. &g

Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.

2009-08-21 Thread Mark Wielaard
Hi Mark, On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: > This change was integrated prematurely. I've rolled it back in the > jdk7/tl/jdk repository. If at all possible, please don't do this. It plays havoc with already checked out repos and/or automatic clones/backups. You force peopl

Re: Setting public TestEnv defaults for net/nio tests needing hosts

2009-06-04 Thread Mark Wielaard
Hi Alan, On Thu, 2009-06-04 at 17:58 +0100, Alan Bateman wrote: > It's been on my list to forward-port the TestEnv and test updates to > jdk7 (just haven't got to it yet). Thanks. > The idea with that was that jtreg > would be run with a properties file that listed the hosts that the tests >

Re: Setting public TestEnv defaults for net/nio tests needing hosts

2009-06-04 Thread Mark Wielaard
Hi, On Sun, 2008-11-16 at 00:05 +0100, Mark Wielaard wrote: > I made sure all needed services are enabled on > icedtea.classpath.org/developer.classpath.org and set those as defaults > in TestEnv for the net/nio tests that need to contact hosts. Using > icedtea for remote_host and d

Re: [security-dev 00466]: hg: jdk7/tl/jdk: 6496274: jar seems to use more CPU than it should

2008-12-19 Thread Mark Wielaard
Hi Sherman, On Fri, 2008-12-19 at 08:42 -0800, Xueming Shen wrote: > No, you did not miss anything. The "original patch proposal " had not > been sent to > any of the community mailing lists, the "reviewed-by" is for the final > code review, > which was not sent to the mailing list as well, I

Re: [security-dev 00466]: hg: jdk7/tl/jdk: 6496274: jar seems to use more CPU than it should

2008-12-18 Thread Mark Wielaard
Hi, On Thu, 2008-12-18 at 06:57 +, xueming.s...@sun.com wrote: > Changeset: 57dc40ece164 > Author:sherman > Date: 2008-12-17 22:50 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/57dc40ece164 > > 6496274: jar seems to use more CPU than it should > Summary: boost jar cre

Re: ChunkedInputStream/test.txt

2008-09-25 Thread Mark Wielaard
Hi, On Thu, 2008-09-25 at 15:03 +0100, Christopher Hegarty - Sun Microsystems Ireland wrote: > Joseph D. Darcy wrote: > > Yes, I've already asked Chris to fix this in OpenJDK 6 too. > > I pushed these changes into the OpenJDK 6 workspace, so it will be in > the next build/push. Thanks a lot! F

Re: ChunkedInputStream/test.txt

2008-09-24 Thread Mark Wielaard
On Tue, 2008-09-23 at 09:46 -0700, Kelly O'Hair wrote: > Probably true that the test can be re-written, and you are right, a 500K > binary file is not something I want in the repository either. > Unfortunately, some engineers have the historical and bad habit of just > adding in files to workspaces

Re: Heads up: Bad changeset rollback

2008-09-04 Thread Mark Wielaard
On Thu, 2008-09-04 at 20:23 +0800, Max (Weijun) Wang wrote: > The bug id should have been 6740833. Aha! The 7 and 4 got swapped. Thanks. And the jcheck scripts would then have prevented that bug to ever get fixed again. Although I guess you could reuse the swapped bug number for that one then :)

Re: Heads up: Bad changeset rollback

2008-09-04 Thread Mark Wielaard
Hi, On Wed, 2008-09-03 at 14:16 -0700, Mark Reinhold wrote: > > Date: Wed, 03 Sep 2008 13:08:38 -0700 > > From: [EMAIL PROTECTED] > > > Last night there was a changeset introduced to the JSN gate that > > contained an incorrect changeset comment. Rather than pollute the > > changeset history for

Re: hg: jdk7/jsn/jdk: 6717876: Make java.net.NetworkInterface.getIndex() public

2008-08-28 Thread Mark Wielaard
On Thu, 2008-08-28 at 12:16 +0100, Alan Bateman wrote: > Mark Wielaard wrote: > > : > > This seems to introduce a new public API in the java.net package. > > I was wondering how that works for someone that wants to introduce > > such things in openjdk. > There is

Re: hg: jdk7/jsn/jdk: 6717876: Make java.net.NetworkInterface.getIndex() public

2008-08-27 Thread Mark Wielaard
Hi, On Mon, Aug 25, 2008 at 12:43:59PM +, [EMAIL PROTECTED] wrote: > URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/f4289d75cd29 > > 6717876: Make java.net.NetworkInterface.getIndex() public > Summary: Make getIndex() and getByIndex() public. Required a name change in > native code >