On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
This pull request has now been integrated.
Changeset: 6cc4bb11
Author: Mark Powers
Committer: Bradford Wetmore
URL:
https://git.openjdk.java.net/jdk/com
On Mon, 23 May 2022 18:58:34 GMT, Mark Powers wrote:
>> JDK-6725221 Standardize obtaining boolean properties with defaults
>
> Mark Powers has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Al
On Mon, 23 May 2022 18:34:41 GMT, Roger Riggs wrote:
>> You are right. The old way maps the null string to true, and the new way
>> maps it to false. I did not notice that. At this point, I see no value in
>> making the "true".equals and "false".equals changes. Too much can break.
>> I'll reve
> JDK-6725221 Standardize obtaining boolean properties with defaults
Mark Powers has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains six commits:
- Alan and Jamil comments
- Merge
- reverse true.equals and false.equals chan
On Fri, 29 Apr 2022 03:58:57 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of this fix to allow a read-only 'src' buffer to be used with
> SSLEngine.unwrap(). A temporary read-write buffer is created in the SSLCipher
> operation when a read-only buffer is passed. If the 'src' is read
On Fri, 6 May 2022 17:56:44 GMT, Alan Bateman wrote:
>> JDK-6725221 Standardize obtaining boolean properties with defaults
>
> src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777:
>
>> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) {
>> 776:
JDK-6725221 Standardize obtaining boolean properties with defaults
-
Commit messages:
- Merge
- first iteration
Changes: https://git.openjdk.java.net/jdk/pull/8559/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8559&range=00
Issue: https://bugs.openjdk.java.net/brow
On Mon, 25 Apr 2022 17:40:13 GMT, Mark Powers wrote:
> https://bugs.openjdk.java.net/browse/JDK-8285504
>
> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
> a single code review, so it was decided to split into smaller chunks. This is
> one such ch
On Thu, 28 Apr 2022 16:23:25 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/net/ssl/TrustManagerFactory.java line 82:
>>
>>> 80: String type;
>>> 81: type = GetPropertyAction.privilegedGetProperty(
>>> 82: "ssl.TrustManagerFactory.algorithm");
>>
>
> https://bugs.openjdk.java.net/browse/JDK-8285504
>
> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
> a single code review, so it was decided to split into smaller chunks. This is
> one such chunk:
>
> open/src/java.base/share/classes/java
On Thu, 28 Apr 2022 17:29:53 GMT, Bradford Wetmore wrote:
>> My mistake. It's only the trim that you wanted removed, line 94.
>
> No, the API for Security.getProperty doesn't specify trimming, so suggest
> leaving the trim() part also.
Okay. Line 94 is back.
-
PR: https://git.open
On Thu, 28 Apr 2022 16:27:08 GMT, Bradford Wetmore wrote:
>> Just found the same. This needs to be reverted. You can set a Security
>> Property to an "empty" string which won't work here. Suggest you revert to
>> previous code, possibly using a lambda if that was the original intent.
>
> `Se
On Thu, 28 Apr 2022 16:14:01 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/net/ssl/KeyManagerFactory.java line 70:
>>
>>> 68: String type;
>>> 69: type = GetPropertyAction.privilegedGetProperty(
>>> 70: "ssl.KeyManagerFactory.algorithm");
>>
>> So
On Wed, 27 Apr 2022 20:22:42 GMT, Mark Powers wrote:
>> JDK-6725221 is about obtaining boolean properties, so not an exact match.
>> The suggested change is so easy, I'm going to do it.
>
> sun.security.action.GetPropertyAction::privilegedGetProperty doesn't trim the
> https://bugs.openjdk.java.net/browse/JDK-8285504
>
> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
> a single code review, so it was decided to split into smaller chunks. This is
> one such chunk:
>
> open/src/java.base/share/classes/java
On Wed, 27 Apr 2022 19:12:37 GMT, Mark Powers wrote:
>> No problem.
>
> JDK-6725221 is about obtaining boolean properties, so not an exact match. The
> suggested change is so easy, I'm going to do it.
sun.security.action.GetPropertyAction::privilegedGetProperty doesn'
On Tue, 26 Apr 2022 19:09:46 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/TrustManager
On Tue, 26 Apr 2022 22:08:42 GMT, Weijun Wang wrote:
>> Perhaps as part of
>> [JDK-6725221](https://bugs.openjdk.java.net/browse/JDK-6725221)?
>
> No problem.
JDK-6725221 is about obtaining boolean properties, so not an exact match. The
suggested change is so easy, I'm going to do it.
---
On Tue, 26 Apr 2022 19:08:50 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/SSLSocket
On Tue, 26 Apr 2022 18:46:02 GMT, Bradford Wetmore wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/SSLSessionBindi
On Tue, 26 Apr 2022 18:39:33 GMT, Bradford Wetmore wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/KeyStoreBui
> https://bugs.openjdk.java.net/browse/JDK-8285504
>
> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
> a single code review, so it was decided to split into smaller chunks. This is
> one such chunk:
>
> open/src/java.base/share/classes/java
On Tue, 26 Apr 2022 04:37:58 GMT, Jaikiran Pai wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/KeyStoreBuilderParame
> https://bugs.openjdk.java.net/browse/JDK-8285504
>
> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
> a single code review, so it was decided to split into smaller chunks. This is
> one such chunk:
>
> open/src/java.base/share/classes/java
On Mon, 25 Apr 2022 18:48:31 GMT, Alan Bateman wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
https://bugs.openjdk.java.net/browse/JDK-8285504
JDK-8273046 is the umbrella bug for this bug. The changes were too large for a
single code review, so it was decided to split into smaller chunks. This is one
such chunk:
open/src/java.base/share/classes/java/net
-
Commit messages:
26 matches
Mail list logo
