On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by the serviceability team
> (`java.instrument java.management.rmi java.management jdk.attach
> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
> jdk.jdwp.agen
port for running `codespell`.
> The trouble with automating this is of course all false positives. But before
> even trying to solve that issue, all true positives must be fixed. Hence this
> PR.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit
port for running `codespell`.
> The trouble with automating this is of course all false positives. But before
> even trying to solve that issue, all true positives must be fixed. Hence this
> PR.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit
On Thu, 21 Apr 2022 16:17:20 GMT, Kevin Walls wrote:
>> I ran `codespell` on modules owned by the serviceability team
>> (`java.instrument java.management.rmi java.management jdk.attach
>> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
>> jdk.jdwp.agent jdk.jstatd jdk.man
On Thu, 21 Apr 2022 14:03:39 GMT, Daniel Fuchs wrote:
>> I ran `codespell` on modules owned by the serviceability team
>> (`java.instrument java.management.rmi java.management jdk.attach
>> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
>> jdk.jdwp.agent jdk.jstatd jdk.ma
I ran `codespell` on modules owned by the serviceability team (`java.instrument
java.management.rmi java.management jdk.attach jdk.hotspot.agent
jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi jdk.jdwp.agent jdk.jstatd
jdk.management.agent jdk.management`), and accepted those changes where it
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majori
On Tue, 19 Apr 2022 16:24:43 GMT, Magnus Ihse Bursie wrote:
>> I ran `codespell` on the `src/java.base` directory, and accepted those
>> changes where it indeed discovered real typos.
>>
>> (Due to false positives this can unfortunately not be run automatically)
>
> local variable name, and a couple in parameter declarations.
>
> Annoyingly, there are several instances of "childs" (instead of "children")
> in the source code, but they were not local and I dared not change them.
> Someone braver than me might take a stab
> local variable name, and a couple in parameter declarations.
>
> Annoyingly, there are several instances of "childs" (instead of "children")
> in the source code, but they were not local and I dared not change them.
> Someone braver than me might take a stab
> local variable name, and a couple in parameter declarations.
>
> Annoyingly, there are several instances of "childs" (instead of "children")
> in the source code, but they were not local and I dared not change them.
> Someone braver than me might take a stab
On Fri, 15 Apr 2022 11:49:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following PR review please? It adds a new JDK specific
>> extended socket option
>> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
>> and IPv6
>> UDP sockets (NIO DatagramChannels
I ran `codespell` on the `src/java.base` directory, and accepted those changes
where it indeed discovered real typos.
(Due to false positives this can unfortunately not be run automatically)
The majority of fixes are in comments. A handful is in strings, one in a local
variable name, and a cou
On Mon, 7 Mar 2022 16:40:15 GMT, Lance Andersen wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> What problem are you having editing the PR header? You should be able to do
> so as the author of the PR
@LanceAnde
On Fri, 4 Mar 2022 17:17:12 GMT, Roger Riggs wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> We usually request that these be be broken up by area to attract the
> appropriate reviewers and avoid eye-strain. The c
On Mon, 29 Nov 2021 17:00:24 GMT, Julia Boes wrote:
>> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
>> Server.
>>
>> A description is provided in a follow-up comment.
>
> Julia Boes has updated the pull request with a new target base due to a merge
> or a rebase.
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote:
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
Build changes look good.
src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/JWebServe
On Thu, 11 Nov 2021 14:58:45 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source in jdk.httpserver. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the scrip
I ran bin/blessed-modifier-order.sh on source in jdk.httpserver. This scripts
verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
have manually checked the changes made by the script to make sure they are
sound.
-
Commit messages:
- 8277016: Use blessed m
On Thu, 4 Nov 2021 17:09:16 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source owned by net libs. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the scrip
I ran bin/blessed-modifier-order.sh on source owned by net libs. This scripts
verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
have manually checked the changes made by the script to make sure they are
sound.
-
Commit messages:
- 8276655: Use blessed m
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote:
> Single-row table was being used as a hack here, a description list
> seems more appropriate
Looks good to me.
-
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6010
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method is
On 2020-09-29 13:17, Kim Barrett wrote:
On Sep 29, 2020, at 6:51 AM, Kim Barrett wrote:
On Sep 28, 2020, at 11:13 AM, Eric Liu wrote:
Hi,
Thanks for looking at this.
For gcc-10, it's hard to make 'strncpy' all right with asan enabled (approaches
we talked previous don't work).
I'm tryi
On 2020-09-02 09:50, Kim Barrett wrote:
On Sep 2, 2020, at 2:39 AM, Magnus Ihse Bursie
wrote:
On 2020-09-01 11:46, Kim Barrett wrote:
I really hate -Wstringop-truncation. It's been a constant source of churn
for us ever since it appeared. The changes being made to getIndex and
get
On 2020-09-01 11:46, Kim Barrett wrote:
On Sep 1, 2020, at 4:01 AM, Eric Liu wrote:
Hi all,
Please review this simple change to fix some compile warnings.
The newer gcc (gcc-8 or higher) would warn for calls to bounded string
manipulation functions such as 'strncpy' that may either truncate t
On 2020-05-07 23:27, Mikael Vidstedt wrote:
On May 7, 2020, at 7:52 AM, Kumar Srinivasan wrote:
Hi Mikael,
I may have created solinux when the macosx port was merged and in an effort to
reduce the CPP conditionals.
solinux = solaris + linux ie. Vanilla unix code vs Darwin code IIRC has
On 2017-01-25 13:51, Chris Hegarty wrote:
On 24 Jan 2017, at 16:44, Erik Joelsson wrote:
Hello,
Build changes look good except for one thing. In Javadoc.gmk, the dependency on
$(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE) (on line 317), where
the actual recipes are created. Settin
On 2013-10-10 12:10, Michael McMahon wrote:
Can I get the following change for jdk 8 reviewed please?
It's a simple build change to enable compilation of the dummy
SCTP API layer on macosx, plus the dummy implementation
used on windows.
The existing jdk_sctp tests cover this.
http://cr.openjdk
29 matches
Mail list logo
