RE: RFR: 8252837: Cleanup SAP Copyright file headers

Hi Christoph, Looks good to me 😊 Best regards, Goetz. -Original Message- From: nio-dev On Behalf Of Christoph Langer Sent: Montag, 7. September 2020 06:22 To: hotspot-...@openjdk.java.net; net-dev@openjdk.java.net; nio-...@openjdk.java.net; serviceability-...@openjdk.java.net Subjec

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

Thanks! I should have stated that I don't need a new webrev, thanks anyways. Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 24. Januar 2019 11:59 > To: Lindenmaier, Goetz ; OpenJDK Dev list > ; OpenJDK Network Dev list d

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

Hi Christoph, it is a good idea to keep testing these two matters separately. Could you please document in the new test that in OpenJDK it is decided to keep this property empty? Something like: @comment In OpenJDK, this property is empty by default and on purpose. This test assures the default

RE: RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

r "8187658: Bigger buffer > for > GetAdaptersAddresses" > > Hi Goetz, > > Change looks OK to me, although i am not the official reviewer. > > Thanks, > > Vyom > > > On Friday 06 October 2017 12:18 PM, Lindenmaier, Goetz wrote: > &

RE: RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

Thanks, volker! Best regards, Goetz > -Original Message- > From: Volker Simonis [mailto:volker.simo...@gmail.com] > Sent: Freitag, 6. Oktober 2017 10:31 > To: Lindenmaier, Goetz > Cc: net-dev@openjdk.java.net > Subject: Re: RFR(XS): 8188855: Fix VS10 build afte

RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

Hi, could I please get reviews for this tiny change? http://cr.openjdk.java.net/~goetz/wr17/8188855-winBuild/webrev/ Best regards, Goetz.

RE: RFR: 8170544: Fix code scan findings in libnet

Hi Christoph, Thanks for the fixes, looks good now! Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 29. Dezember 2016 14:21 > To: Lindenmaier, Goetz > Cc: net-dev@openjdk.java.net; Chris Hegarty ; > Michael McMahon

RE: RFR: 8170544: Fix code scan findings in libnet

To: Michael McMahon > Cc: net-dev@openjdk.java.net; Chris Hegarty ; > Lindenmaier, Goetz > Subject: RE: RFR: 8170544: Fix code scan findings in libnet > > Hi Michael, > > > > I have just updated http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ in > place. The old

RE: RFR(S): 8171075: Inet4AddressImpl: Remove duplicate and (no longer used ?) native coding for BSD

Hi Christioph, I had a look at your change. The code you remove is only used if __GLIBC__ is not defined _and_ it's FreeBSD older than 6.11. The removed code is basically identical to the other code. You added the fallback to lookupIfIfLocalhost() to the shared code guarded by MACOSX which

RE: RFR: 8170920 SO_RCVBUF and SO_SNDBUF options problem for network channels on MacOS

ber 2016 10:54 > To: Lindenmaier, Goetz > Subject: FW: RFR: 8170920 SO_RCVBUF and SO_SNDBUF options problem for > network channels on MacOS > > > > -Original Message- > From: Michael McMahon [mailto:michael.x.mcma...@oracle.com] > Sent: Freitag, 9. Dezember 2