Re: RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

2019-12-16 Thread Kiran Ravikumar
Thanks Daniel and Chris, Here is my updated webrev with the mentioned corrections. http://cr.openjdk.java.net/~kravikumar/5064980/webrev.01/ Please review at your convenience. Thanks, Kiran On 16/12/2019 14:04, Chris Hegarty wrote: Kiran, On 13 Dec 2019, at 18:28, Kiran Ravikumar

RFR [15] 5064980: URI compareTo inconsistent with equals for mixed-case escape sequences

2019-12-13 Thread Kiran Ravikumar
Hi Guys, Could someone please review my fix to URI.java class were URI.compareTo(URI) behavior was different to URI.equals(URI). |URI.compareTo|(URI) does not consider two URI's to be equal when they differ only in the case of hexadecimal digits of escaped octets, while |URI.equals(URI)|does

Re: RFR: JDK-8214560 - Use {@systemProperty} for definitions of system properties (httpserver)

2019-10-08 Thread Kiran Ravikumar
On 08/10/2019, 17:51, Daniel Fuchs wrote: Hi Kiran, Looks good to me. Did you generate the docs and verify the change has the expected effects? best regards, -- daniel On 08/10/2019 17:19, Kiran Ravikumar wrote: Hi Guys, Could you please review this minor fix: Bug :https

RFR: JDK-8214560 - Use {@systemProperty} for definitions of system properties (httpserver)

2019-10-08 Thread Kiran Ravikumar
Hi Guys, Could you please review this minor fix: Bug :https://bugs.openjdk.java.net/browse/JDK-8214560 Webrev :https://cr.openjdk.java.net/~coffeys/webrev.8214560/webrev/ Explanation : Added the javadoc tag @systemProperty to syst