Re: Must call RegisterNatives after getMethodID, else get UnsatisfiedLinkError

2010-06-09 Thread Kelly O';Hair
It's been a while since I worked with this stuff, but I would have done a: jclass cls = env->FindClass("Test"); Which, if I recall, FindClass actually initializes the class. Just a stab in the dark. -kto On Jun 9, 2010, at 12:39 PM, Martin Buchholz wrote: David, Thanks for the bug arc

Re: Code Review 6957375: java/net/ResponseCache/getResponseCode.java fails with invalid stream header: ACED05

2010-06-04 Thread Kelly O';Hair
Looks fine. Sorry about the regression. -kto On Jun 4, 2010, at 7:45 AM, Chris Hegarty wrote: Hi Alan, Michael, Kelly, This regression test started failing after the integration of the rebranding changes. Effectively the rebranding changes should not have changed one of the binary/data te

Re: hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options

2009-12-04 Thread Kelly O';Hair
Andrew John Hughes wrote: 2009/12/4 : Changeset: 1755493c5774 Author:darcy Date: 2009-12-03 18:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774 6907177: Update jdk tests to remove unncessary -source and -target options Reviewed-by: ohair ! test/demo/jvmti/

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Kelly O';Hair
Andrew, Let me know if you have any suggestions on changes to the developers guide, especially the repositories.html page. I don't want to do massive edits to it, but I certainly can make misc. smaller changes, corrections and additions. -kto

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Kelly O';Hair
Andrew John Hughes wrote: 2009/9/23 Andrew Haley : Andrew John Hughes wrote: 2009/9/23 Andrew Haley : Christopher Hegarty -Sun Microsystems Ireland wrote: [cc'ing net-dev] I see you have push access, so if you make the appropriate changes (mentioned above) I can review the webrev and you c

Re: ChunkedInputStream/test.txt

2008-10-05 Thread Kelly O';Hair
Thanks! This file has always been annoying, a *.txt file that isn't a text file. :^) -kto Christopher Hegarty - Sun Microsystems Ireland wrote: Joseph D. Darcy wrote: Yes, I've already asked Chris to fix this in OpenJDK 6 too. I pushed these changes into the OpenJDK 6 workspace, so it will