On Sat, 21 Nov 2020 11:45:42 GMT, Kartik Ohri
wrote:
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
This pu
On Wed, 2 Dec 2020 16:35:24 GMT, Daniel Fuchs wrote:
>> Kartik Ohri has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Align -> and remove trailing whitespace
>
> Marked as reviewed by dfuchs (Reviewer).
On Wed, 2 Dec 2020 16:15:13 GMT, Chris Hegarty wrote:
>> Kartik Ohri has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> I think that t
On Wed, 2 Dec 2020 16:23:11 GMT, Daniel Fuchs wrote:
>> Kartik Ohri has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/java.ne
On Wed, 2 Dec 2020 16:26:43 GMT, Patrick Concannon
wrote:
>> Kartik Ohri has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/jav
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has updated the pull request incrementally w
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has refreshed the contents of this pull req
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has updated the pull request incrementally w
et/jtreg/runtests.html
> >
> > I’ll import your patch now, and run it against our test suites. All
> going well, I can sponsor the PR and then hopefully we can integrate it
> into the JDK for you!
> >
> > Kind regards,
> > Patrick
> >
> >> On 25
> Hi!
> Kindly review this patch to replace switch statements with switch expressions
> (where it makes sense) in the http client modules. The rationale is to
> improve readability of the code.
> Regards,
> Kartik
Kartik Ohri has refreshed the contents of this pull req
Hi!
Kindly review this patch to replace switch statements with switch expressions
(where it makes sense) in the http client modules. The rationale is to improve
readability of the code.
Regards,
Kartik
-
Commit messages:
- Use switch expressions in jdk.internal.net.http and java.ne
2020 at 11:37 PM Patrick Concannon <
patrick.concan...@oracle.com> wrote:
> Hi Kartik,
>
> Thanks for submitting the patch. Once you’ve run the tier2 tests, I’d be
> happy to sponsor it for you.
>
> -Patrick
>
> > On 23 Nov 2020, at 09:09, Chris Hegarty
> wrote:
>
Hi!
I would like to submit this patch https://github.com/openjdk/jdk/pull/1364
with the rationale to improve the readability of the code. Can someone
please take a look at it and create a public issue if the patch is OK to be
included ?
Thanks,
Kartik
13 matches
Mail list logo
