Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. hmmm, I thought we had take

[jdk18] Integrated: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. This pull request has

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi David, The copyright

[jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files. - Commit messages: - JDK-8273179: Update nroff pages in JDK 18 before RC Changes: https:

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs [v2]

2021-10-28 Thread Jonathan Gibbons
On Thu, 28 Oct 2021 12:11:33 GMT, Ludvig Janiuk wrote: >> Single-row table was being used for visual effect, but a description list >> seems more appropriate. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > Removed html f

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-27 Thread Jonathan Gibbons
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used for visual effect, but a description list > seems more appropriate. OK, but ... While the basic translation from a single-row table to a definition list looks good, it's not clear you still need the `styl

Re: RFR: JDK-8262992: Improve `@see` output [v6]

2021-05-06 Thread Jonathan Gibbons
On Wed, 5 May 2021 15:09:17 GMT, Hannes Wallnöfer wrote: >> This changes the output for `@see` tags to a `` structure. A different >> CSS style is used if any of the `@see` tag labels are longer than 30 >> characters or contain a comma. >> >> The layout for the default CSS style is similar to

Re: RFR: JDK-8262992: Improve `@see` output [v2]

2021-03-24 Thread Jonathan Gibbons
On Thu, 11 Mar 2021 15:17:50 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update `@see` tag in class java.security.cert.PKIXRevocationChecker > > Nic

Re: RFR: JDK-8262992: Improve `@see` output [v2]

2021-03-11 Thread Jonathan Gibbons
On Tue, 9 Mar 2021 16:23:26 GMT, Hannes Wallnöfer wrote: >> This changes the output for `@see` tags to a `` structure. A different >> CSS style is used if any of the `@see` tag labels are longer than 30 >> characters or contain a comma. >> >> The layout for the default CSS style is similar to

Integrated: JDK-8262875: doccheck: empty paragraphs, etc in java.base module

2021-03-02 Thread Jonathan Gibbons
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote: > Please review some minor doc fixes, for issues found by _doccheck_.There > are two kinds of errors that are addressed. > > 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a > paragraph. It is not a term

RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module

2021-03-02 Thread Jonathan Gibbons
Please review some minor doc fixes, for issues found by _doccheck_.There are two kinds of errors that are addressed. 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph. It is not a terminator, to mark the end of a paragraph, or a separator to mark the boundary between

Integrated: JDK-8262430: doclint warnings in java.base module

2021-02-26 Thread Jonathan Gibbons
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote: > Please review some simple doc fixes in the `java.base` module. Two were > reported by doclint; the spelling error was detected by the IDE. This pull request has now been integrated. Changeset: 3088e1e6 Author:Jonathan G

RFR: JDK-8262430: doclint warnings in java.base module

2021-02-25 Thread Jonathan Gibbons
Please review some simple doc fixes in the `java.base` module. Two were reported by doclint; the spelling error was detected by the IDE. - Commit messages: - JDK-8262430: doclint warnings in java.base module Changes: https://git.openjdk.java.net/jdk/pull/2734/files Webrev: https:

Re: RFR: 8258696: Temporarily revert use of pattern match instanceof until docs-reference is fixed

2020-12-18 Thread Jonathan Gibbons
On Fri, 18 Dec 2020 16:54:59 GMT, Chris Hegarty wrote: > Temporarily revert use of pattern match instanceof construct until > docs-reference is fixed, see JDK-8258657. > > ... > Generating REFERENCE_API javadoc for 21 modules > > if (delegate instanceof ExecutorService service)

Integrated: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Jonathan Gibbons
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. This pull request has now been integrated. Changeset: 0aa3c925 Author: Jonathan Gibbons URL: https://git.openjdk.java.net/jdk/commit/0aa3c925 St

RFR: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Jonathan Gibbons
The change is (just) to remove legacy usages of a JDK-private custom tag. - Commit messages: - JDK-8255262: Remove use of legacy custom @spec tag Changes: https://git.openjdk.java.net/jdk/pull/814/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=814&range=00 Issue: htt

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-10 Thread Jonathan Gibbons
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy wrote: > I have in mind dozens of improvements all over the code like this one. That sounds scary. Broad updates like these cause unnecessary churn in the codebase, and can make merging and back porting harder. Changes should be discussed ah

Re: Fix for Javadoc errors in java.base

2020-08-13 Thread Jonathan Gibbons
On 8/13/20 10:13 AM, Sean Mullan wrote: On 8/13/20 11:05 AM, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to hav

hg: jdk8/tl/langtools: 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules

2013-11-25 Thread jonathan . gibbons
Changeset: a78f51d6bd5e Author:jjg Date: 2013-11-25 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Reviewed-by: darcy ! src

hg: jdk8/tl/langtools: 2 new changesets

2013-10-22 Thread jonathan . gibbons
Changeset: 351d6808c1a5 Author:jjg Date: 2013-10-22 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5 8027119: Cleanup javadoc comments for taglet API Reviewed-by: mduigou ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 41d3ffca22ff Author:

hg: jdk8/tl/langtools: 8026791: wrong type_path encoded for method_return on an inner class constructor

2013-10-20 Thread jonathan . gibbons
Changeset: ae4f5cb78ebd Author:jjg Date: 2013-10-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ae4f5cb78ebd 8026791: wrong type_path encoded for method_return on an inner class constructor Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/

hg: jdk8/tl/langtools: 8025109: Better encapsulation for AnnotatedType

2013-10-20 Thread jonathan . gibbons
Changeset: e5d3cd43c85e Author:jjg Date: 2013-10-20 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e5d3cd43c85e 8025109: Better encapsulation for AnnotatedType Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/tools/javac/code/Symbol.j

hg: jdk8/tl/langtools: 8026749: Missing LV table in lambda bodies

2013-10-18 Thread jonathan . gibbons
Changeset: 7de97abc4a5c Author:jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/co

hg: jdk8/tl/langtools: 8026704: Build failure with --enable-debug

2013-10-16 Thread jonathan . gibbons
Changeset: d7e155f874a7 Author:jjg Date: 2013-10-16 10:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7e155f874a7 8026704: Build failure with --enable-debug Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tool

hg: jdk8/tl/langtools: 8026564: import changes from type-annotations forest

2013-10-15 Thread jonathan . gibbons
Changeset: b0c086cd4520 Author:jjg Date: 2013-10-15 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0c086cd4520 8026564: import changes from type-annotations forest Reviewed-by: jjg Contributed-by: wdi...@gmail.com, steve.si...@oracle.com ! make/build.properties

hg: jdk8/tl/langtools: 8025998: Missing LV table in lambda bodies

2013-10-14 Thread jonathan . gibbons
Changeset: 09a414673570 Author:jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/too

hg: jdk8/tl/langtools: 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail

2013-10-14 Thread jonathan . gibbons
Changeset: 7d266a2b31b2 Author:jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy ! src/share/classes/com/sun/tools/

hg: jdk8/tl/langtools: 8026371: "tidy" issues in langtools/src/**/*.html files

2013-10-14 Thread jonathan . gibbons
Changeset: b9e3b55a908c Author:jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c 8026371: "tidy" issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java - src/share/classes/co

hg: jdk8/tl/langtools: 8026368: doclint does not report empty tags when tag closed implicitly

2013-10-14 Thread jonathan . gibbons
Changeset: b024fe427d24 Author:jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! test

hg: jdk8/tl/langtools: 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java

2013-10-10 Thread jonathan . gibbons
Changeset: f068d235c4f7 Author:jjg Date: 2013-10-10 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f068d235c4f7 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Reviewed-by: darcy ! test/com/sun/javadoc/

hg: jdk8/tl/langtools: 8025970: Spurious characters in JavaCompiler

2013-10-04 Thread jonathan . gibbons
Changeset: 3e3c321710be Author:jjg Date: 2013-10-04 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3e3c321710be 8025970: Spurious characters in JavaCompiler Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java

hg: jdk8/tl/langtools: 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode

2013-10-04 Thread jonathan . gibbons
Changeset: 515d54c1b063 Author:jjg Date: 2013-10-04 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/515d54c1b063 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main

hg: jdk8/tl/langtools: 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor

2013-10-04 Thread jonathan . gibbons
Changeset: 2fa6ced325cc Author:jjg Date: 2013-10-04 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fa6ced325cc 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/p

hg: jdk8/tl/langtools: 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java

2013-09-25 Thread jonathan . gibbons
Changeset: 3d61984b077c Author:jjg Date: 2013-09-25 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d61984b077c 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java Reviewed-by: bpatel ! test/tools/doclint/tidy/util/Main.java ! test/to

hg: jdk8/tl/langtools: 8025407: TypeAnnotations does not use Context

2013-09-25 Thread jonathan . gibbons
Changeset: 5043e7056be8 Author:jjg Date: 2013-09-25 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5043e7056be8 8025407: TypeAnnotations does not use Context Reviewed-by: jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classe

hg: jdk8/tl/langtools: 8002154: [doclint] doclint should check for issues which are errors in javadoc

2013-09-24 Thread jonathan . gibbons
Changeset: 3ae62331a56f Author:jjg Date: 2013-09-24 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae62331a56f 8002154: [doclint] doclint should check for issues which are errors in javadoc Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Checker.ja

hg: jdk8/tl/langtools: 8025272: doclint needs to check for valid usage of @value tag

2013-09-24 Thread jonathan . gibbons
Changeset: 6a05a713450d Author:jjg Date: 2013-09-24 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6a05a713450d 8025272: doclint needs to check for valid usage of @value tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/cl

hg: jdk8/tl/langtools: 8025246: [doclint] doclint is showing error on anchor already defined when it's not

2013-09-24 Thread jonathan . gibbons
Changeset: 503338f16d2b Author:jjg Date: 2013-09-24 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/503338f16d2b 8025246: [doclint] doclint is showing error on anchor already defined when it's not Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Chec

hg: jdk8/tl/langtools: 8025050: Doclint doesn't recognize tag

2013-09-24 Thread jonathan . gibbons
Changeset: 96dcb66e6b0a Author:jjg Date: 2013-09-24 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96dcb66e6b0a 8025050: Doclint doesn't recognize tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! test/tools/doclint/html/InlineTags

hg: jdk8/tl/langtools: 8025110: TreeCopier does not correctly copy LabeledStatementTree

2013-09-19 Thread jonathan . gibbons
Changeset: 9a75bdb249a2 Author:jjg Date: 2013-09-19 19:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9a75bdb249a2 8025110: TreeCopier does not correctly copy LabeledStatementTree Reviewed-by: jjg Contributed-by: Werner Dietl ! src/share/classes/com/sun/tools/javac

hg: jdk8/tl/langtools: 8024609: sjavac assertion fails during call to BuildState.collectArtifacts

2013-09-19 Thread jonathan . gibbons
Changeset: 0cfd5baa7154 Author:ohrstrom Date: 2013-09-19 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0cfd5baa7154 8024609: sjavac assertion fails during call to BuildState.collectArtifacts Reviewed-by: jjg ! src/share/classes/com/sun/tools/sjavac/BuildState.ja

hg: jdk8/tl/langtools: 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL

2013-09-17 Thread jonathan . gibbons
Changeset: fdfbc5f0c4ed Author:jjg Date: 2013-09-17 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fdfbc5f0c4ed 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/

hg: jdk8/tl/langtools: 8006972: jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java

2013-09-09 Thread jonathan . gibbons
Changeset: 7439356a7dc5 Author:jjg Date: 2013-09-09 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7439356a7dc5 8006972: jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java Reviewed-by: darcy ! test/tools/javac

hg: jdk8/tl/langtools: 8019521: Enhanced rethrow disabled in lambdas

2013-09-09 Thread jonathan . gibbons
Changeset: 77d395862700 Author:jlahoda Date: 2013-09-09 23:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/77d395862700 8019521: Enhanced rethrow disabled in lambdas Summary: Fixing effectively final detection inside lambdas, small cleanup related to thrown types det

hg: jdk8/tl/langtools: 8024434: problem running javadoc tests in samevm mode on Windows

2013-09-06 Thread jonathan . gibbons
Changeset: 64328fe5e4a6 Author:jjg Date: 2013-09-06 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64328fe5e4a6 8024434: problem running javadoc tests in samevm mode on Windows Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Pa

hg: jdk8/tl/langtools: 8024288: javadoc generated-by comment should always be present

2013-09-04 Thread jonathan . gibbons
Changeset: 044721d4d359 Author:jjg Date: 2013-09-04 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/044721d4d359 8024288: javadoc generated-by comment should always be present Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWri

hg: jdk8/tl/langtools: 8015663: Need to supply tests to provide javadoc for profiles support code coverage

2013-08-30 Thread jonathan . gibbons
Changeset: 7993cfab8610 Author:jjg Date: 2013-08-30 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7993cfab8610 8015663: Need to supply tests to provide javadoc for profiles support code coverage Reviewed-by: jjg Contributed-by: evgeniya.stepan...@oracle.com ! t

hg: jdk8/tl/langtools: 8008367: Sub-packages missing from Profiles javadoc

2013-08-30 Thread jonathan . gibbons
Changeset: f050c714b556 Author:jjg Date: 2013-08-30 16:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f050c714b556 8008367: Sub-packages missing from Profiles javadoc Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java

hg: jdk8/tl/langtools: 8024093: Two *.rej files checked in to langtools/test directory

2013-08-30 Thread jonathan . gibbons
Changeset: 3dd40e5715fb Author:jjg Date: 2013-08-30 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3dd40e5715fb 8024093: Two *.rej files checked in to langtools/test directory Reviewed-by: mchung - test/tools/javac/diags/examples/MrefStat.java.rej - test/tools/ja

hg: jdk8/tl/langtools: 8023700: Use non breaking space in various labels

2013-08-30 Thread jonathan . gibbons
Changeset: 240f424cc0d5 Author:jjg Date: 2013-08-30 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/240f424cc0d5 8023700: Use non breaking space in various labels Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.

hg: jdk8/tl/langtools: 8023833: Replace direct use of AnnotatedType in javadoc code

2013-08-29 Thread jonathan . gibbons
Changeset: 23f0f3c9c44a Author:jjg Date: 2013-08-29 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/23f0f3c9c44a 8023833: Replace direct use of AnnotatedType in javadoc code Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/

hg: jdk8/tl/langtools: 8022744: javac -Xpkginfo command's documentation is sparse

2013-08-29 Thread jonathan . gibbons
Changeset: 96b6865eda94 Author:jjg Date: 2013-08-29 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96b6865eda94 8022744: javac -Xpkginfo command's documentation is sparse Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java

hg: jdk8/tl/langtools: 8013384: Potential infinite loop in javadoc

2013-08-29 Thread jonathan . gibbons
Changeset: 9c0e192c0926 Author:jjg Date: 2013-08-29 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9c0e192c0926 8013384: Potential infinite loop in javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java

hg: jdk8/tl/langtools: 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only

2013-08-29 Thread jonathan . gibbons
Changeset: b0b25c1f6cbd Author:jjg Date: 2013-08-29 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0b25c1f6cbd 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only Reviewed-by: darcy ! test/tools/javac/tree/TypeA

hg: jdk8/tl/langtools: 8001669: javadoc internal DocletAbortException should set cause when appropriate

2013-08-29 Thread jonathan . gibbons
Changeset: 0e6577980181 Author:jjg Date: 2013-08-29 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e6577980181 8001669: javadoc internal DocletAbortException should set cause when appropriate Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/

hg: jdk8/tl/langtools: 8010310: [javadoc] Error processing sources with -private

2013-08-28 Thread jonathan . gibbons
Changeset: 189942cdf585 Author:jjg Date: 2013-08-28 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/189942cdf585 8010310: [javadoc] Error processing sources with -private Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java !

hg: jdk8/tl/langtools: 8023768: Use the unannotatedType in cyclicity checks.

2013-08-26 Thread jonathan . gibbons
Changeset: 7bf6313e1ced Author:jjg Date: 2013-08-26 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bf6313e1ced 8023768: Use the unannotatedType in cyclicity checks. Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/tools/javac/comp/Ch

hg: jdk8/tl/langtools: 8023701: Fix badly named test

2013-08-26 Thread jonathan . gibbons
Changeset: 60f156c653d3 Author:jjg Date: 2013-08-26 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60f156c653d3 8023701: Fix badly named test Reviewed-by: bpatel - test/com/sun/javadoc/testNavagation/TestNavagation.java - test/com/sun/javadoc/testNavagation/pkg/A

hg: jdk8/tl/langtools: 8022173: Relax some warnings in doclint

2013-08-22 Thread jonathan . gibbons
Changeset: b77381d99056 Author:jjg Date: 2013-08-22 12:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b77381d99056 8022173: Relax some warnings in doclint Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! test/tools/doclint/html/ListTagsTes

hg: jdk8/tl/langtools: 8022287: javac.sym.Profiles uses a static Map when it should not

2013-08-21 Thread jonathan . gibbons
Changeset: 57e1266527dd Author:jjg Date: 2013-08-21 17:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57e1266527dd 8022287: javac.sym.Profiles uses a static Map when it should not Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/sym/Profiles.java + test/t

hg: jdk8/tl/langtools: 8023515: import type-annotations updates

2013-08-21 Thread jonathan . gibbons
Changeset: 7de231613e4a Author:jjg Date: 2013-08-21 16:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de231613e4a 8023515: import type-annotations updates Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/source/tree/MethodTree.java ! sr

hg: jdk8/tl/langtools: 8013887: In class use, some tables are randomly unsorted

2013-08-20 Thread jonathan . gibbons
Changeset: 720992953d43 Author:jjg Date: 2013-08-20 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/720992953d43 8013887: In class use, some tables are randomly unsorted Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java

hg: jdk8/tl/langtools: 8022080: javadoc generates invalid HTML in Turkish locale

2013-08-20 Thread jonathan . gibbons
Changeset: 79e341614c50 Author:jjg Date: 2013-08-20 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79e341614c50 8022080: javadoc generates invalid HTML in Turkish locale Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.jav

hg: jdk8/tl/langtools: 8020663: Restructure some properties to facilitate better translation

2013-08-20 Thread jonathan . gibbons
Changeset: a76dc1b4c299 Author:jjg Date: 2013-08-20 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a76dc1b4c299 8020663: Restructure some properties to facilitate better translation Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/re

hg: jdk8/tl/langtools: 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages

2013-08-14 Thread jonathan . gibbons
Changeset: 14faef2b51eb Author:jjg Date: 2013-08-14 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/14faef2b51eb 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages Reviewed-by: bpatel ! src/share/classes/com/sun/too

hg: jdk8/tl/langtools: 8020556: doclint does not check type variables for @throws

2013-07-24 Thread jonathan . gibbons
Changeset: 2fbe77c38802 Author:jjg Date: 2013-07-24 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fbe77c38802 8020556: doclint does not check type variables for @throws Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/c

hg: jdk8/tl/langtools: 8021215: javac gives incorrect doclint warnings on normal package statements

2013-07-23 Thread jonathan . gibbons
Changeset: 129751018061 Author:jjg Date: 2013-07-23 16:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/129751018061 8021215: javac gives incorrect doclint warnings on normal package statements Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java

hg: jdk8/tl/langtools: 8020313: doclint doesn't reset HTML anchors correctly

2013-07-17 Thread jonathan . gibbons
Changeset: 1e533c1bfb01 Author:jjg Date: 2013-07-17 19:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e533c1bfb01 8020313: doclint doesn't reset HTML anchors correctly Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/docl

hg: jdk8/tl/langtools: 8020664: doclint gives incorrect warnings on normal package statements

2013-07-17 Thread jonathan . gibbons
Changeset: 1476d54fdc61 Author:jjg Date: 2013-07-17 19:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1476d54fdc61 8020664: doclint gives incorrect warnings on normal package statements Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/DocLint.java

hg: jdk8/tl/langtools: 8014636: TestLiteralCodeInPre fails on windows

2013-07-17 Thread jonathan . gibbons
Changeset: 80e75aa6a707 Author:jjg Date: 2013-07-17 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/80e75aa6a707 8014636: TestLiteralCodeInPre fails on windows Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/s

hg: jdk8/tl/langtools: 8020278: NPE in javadoc

2013-07-12 Thread jonathan . gibbons
Changeset: 37031963493e Author:jjg Date: 2013-07-12 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37031963493e 8020278: NPE in javadoc Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/docl

hg: jdk8/tl/langtools: 8015720: since tag isn't copied while generating JavaFX documentation

2013-06-27 Thread jonathan . gibbons
Changeset: 26437287529d Author:janvalenta Date: 2013-06-27 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/26437287529d 8015720: since tag isn't copied while generating JavaFX documentation Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolk

hg: jdk8/tl/langtools: 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values

2013-06-26 Thread jonathan . gibbons
Changeset: 3b2e10524627 Author:jjg Date: 2013-06-26 18:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b2e10524627 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values Reviewed-by: jjg, darcy Contributed-by: matherey.nu..

hg: jdk8/tl/langtools: 8016193: Fix OAC issue in langtools docs

2013-06-07 Thread jonathan . gibbons
Changeset: fd31bf97340f Author:jjg Date: 2013-06-07 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fd31bf97340f 8016193: Fix OAC issue in langtools docs Reviewed-by: darcy ! src/share/classes/com/sun/javadoc/Tag.java

hg: jdk8/tl/langtools: 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations

2013-06-04 Thread jonathan . gibbons
Changeset: 8fb68f73d4b1 Author:jjg Date: 2013-06-04 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8fb68f73d4b1 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations Reviewed-by: mcimadamore, jfranck ! src/share/classes/

hg: jdk8/tl/langtools: 8007687: javadoc -X does not include -Xdoclint

2013-06-03 Thread jonathan . gibbons
Changeset: 019063968164 Author:jjg Date: 2013-06-03 17:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/019063968164 8007687: javadoc -X does not include -Xdoclint Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/

hg: jdk8/tl/langtools: 8006615: [doclint] move remaining messages into resource bundle

2013-06-03 Thread jonathan . gibbons
Changeset: 242bcad5be74 Author:jjg Date: 2013-06-03 17:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/242bcad5be74 8006615: [doclint] move remaining messages into resource bundle Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/doclint/DocLint.jav

hg: jdk8/tl/langtools: 8013405: DocLint should support

2013-06-03 Thread jonathan . gibbons
Changeset: 391f97e270c2 Author:jjg Date: 2013-06-03 16:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/391f97e270c2 8013405: DocLint should support Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/H

hg: jdk8/tl/langtools: 6885876: add comments to javac/util/Convert.java

2013-05-17 Thread jonathan . gibbons
Changeset: 0928f2cfbf8e Author:jjg Date: 2013-05-17 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0928f2cfbf8e 6885876: add comments to javac/util/Convert.java Reviewed-by: mduigou ! src/share/classes/com/sun/tools/javac/util/Convert.java

hg: jdk8/tl/langtools: 8006879: Detection of windows in sjavac fails.

2013-05-15 Thread jonathan . gibbons
Changeset: 445b8b5ae9f4 Author:jjg Date: 2013-05-15 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/445b8b5ae9f4 8006879: Detection of windows in sjavac fails. Reviewed-by: jjg Contributed-by: erik.joels...@oracle.com ! src/share/classes/com/sun/tools/sjavac/serve

hg: jdk8/tl/langtools: 8014323: Add VariableTree.getNameExpression

2013-05-14 Thread jonathan . gibbons
Changeset: 529fb3ed5d2a Author:jjg Date: 2013-05-14 21:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/529fb3ed5d2a 8014323: Add VariableTree.getNameExpression Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/VariableTree.java ! src/share/classes/com/sun/so

hg: jdk8/tl/langtools: 8013163: Convert 4 tools multicatch tests to jtreg format

2013-05-14 Thread jonathan . gibbons
Changeset: 53b389eb39c1 Author:sogoel Date: 2013-05-14 18:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/53b389eb39c1 8013163: Convert 4 tools multicatch tests to jtreg format Reviewed-by: jjg + test/tools/javac/multicatch/Pos11.java + test/tools/javac/multicatch/Po

hg: jdk8/tl/langtools: 8013852: update reference impl for type-annotations

2013-05-14 Thread jonathan . gibbons
Changeset: ddb4a2bfcd82 Author:jjg Date: 2013-05-14 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ddb4a2bfcd82 8013852: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wdi...@gmail.com, steve.si...@oracle.com, joel.fra...@oracle.com,

hg: jdk8/tl/langtools: 8014557: Mutable static field in HtmlDocletWriter

2013-05-14 Thread jonathan . gibbons
Changeset: 0384683c64be Author:jjg Date: 2013-05-14 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0384683c64be 8014557: Mutable static field in HtmlDocletWriter Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java

hg: jdk8/tl/langtools: 8014461: genstubs creates default native methods

2013-05-14 Thread jonathan . gibbons
Changeset: 46b9c25f7024 Author:jjg Date: 2013-05-14 12:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/46b9c25f7024 8014461: genstubs creates default native methods Reviewed-by: alanb ! make/tools/genstubs/GenStubs.java

hg: jdk8/tl/langtools: 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees

2013-05-13 Thread jonathan . gibbons
Changeset: 8dd528992c15 Author:jlahoda Date: 2013-05-10 15:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8dd528992c15 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Reviewed-by: jjg Contributed-by: Dusan Balek , Jan Lah

hg: jdk8/tl/langtools: 8014363: javac test class ToolTester handles classpath incorrectly

2013-05-12 Thread jonathan . gibbons
Changeset: e39669aea0bd Author:jjg Date: 2013-05-12 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39669aea0bd 8014363: javac test class ToolTester handles classpath incorrectly Reviewed-by: ksrini ! test/tools/javac/api/6406133/T6406133.java ! test/tools/javac/

hg: jdk8/tl/langtools: 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar

2013-05-07 Thread jonathan . gibbons
Changeset: 43c2f7cb9c76 Author:jjg Date: 2013-05-07 14:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/43c2f7cb9c76 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Reviewed-by: vromero, mcimadamore ! src/share/clas

hg: jdk8/tl/langtools: 8009724: Enhance the DocTree API with DocTreePath

2013-05-06 Thread jonathan . gibbons
Changeset: a7ff36d06fa2 Author:jlahoda Date: 2013-05-06 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a7ff36d06fa2 8009724: Enhance the DocTree API with DocTreePath Summary: Adding DocTreePath and DocTreePathScanner similar to TreePath and TreePathScanner, respe

hg: jdk8/tl/langtools: 8008768: Using {@inheritDoc} in simple tag defined via -tag fails

2013-05-03 Thread jonathan . gibbons
Changeset: d918b63a5509 Author:jjg Date: 2013-05-03 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d918b63a5509 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Reviewed-by: jjg, mduigou Contributed-by: jonathan.gibb...@oracle.com, mike.dui...@ora

hg: jdk8/tl/langtools: 8002387: Improve rendered HTML formatting for {@code}

2013-05-03 Thread jonathan . gibbons
Changeset: 38c4bade0ec1 Author:jjg Date: 2013-05-03 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38c4bade0ec1 8002387: Improve rendered HTML formatting for {@code} Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javadoc/Comment.java + test/com/sun/javadoc

hg: jdk8/tl/langtools: 8012728: Normalize @ignore comments on langtools tests

2013-05-03 Thread jonathan . gibbons
Changeset: abd153854f16 Author:jjg Date: 2013-05-03 09:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abd153854f16 8012728: Normalize @ignore comments on langtools tests Reviewed-by: vromero, mcimadamore ! test/com/sun/javadoc/_template/Template.java ! test/com/sun/

hg: jdk8/tl/langtools: 8013256: javac test failing after Lambda changes to java.util.List

2013-04-25 Thread jonathan . gibbons
Changeset: 4b0038f66d66 Author:jjg Date: 2013-04-25 17:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4b0038f66d66 8013256: javac test failing after Lambda changes to java.util.List Reviewed-by: mduigou ! test/tools/javac/api/TestJavacTaskScanner.java

hg: jdk8/tl/langtools: 8012661: remove langtools Makefile-classic

2013-04-19 Thread jonathan . gibbons
Changeset: d59730bd3162 Author:jjg Date: 2013-04-19 11:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d59730bd3162 8012661: remove langtools Makefile-classic Reviewed-by: erikj, tbell - make/Makefile-classic

hg: jdk8/tl/langtools: 8012656: cache frequently used name strings for DocImpl classes

2013-04-18 Thread jonathan . gibbons
Changeset: 95d29b99e5b3 Author:jjg Date: 2013-04-18 20:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/95d29b99e5b3 8012656: cache frequently used name strings for DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/sh

hg: jdk8/tl/langtools: 8012658: Change default langtools source level to 7

2013-04-18 Thread jonathan . gibbons
Changeset: 891b88acf47a Author:jjg Date: 2013-04-18 19:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/891b88acf47a 8012658: Change default langtools source level to 7 Reviewed-by: darcy ! make/netbeans/langtools/nbproject/project.xml

hg: jdk8/tl/langtools: 8008174: DocTree API should provide start and end positions for tree nodes

2013-04-18 Thread jonathan . gibbons
Changeset: ed918a442b83 Author:jlahoda Date: 2013-04-17 15:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed918a442b83 8008174: DocTree API should provide start and end positions for tree nodes Summary: Adding DocSourcePositions to allow access to DocTree starting/en

hg: jdk8/tl/jdk: 8010279: java.util.Stream.min/max((Comparator)null) is not consistent in throwing (unspecified) NPE

2013-04-12 Thread jonathan . gibbons
Changeset: d8cae0195fe9 Author:henryjen Date: 2013-04-12 12:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8cae0195fe9 8010279: java.util.Stream.min/max((Comparator)null) is not consistent in throwing (unspecified) NPE Reviewed-by: alanb, mduigou ! src/share/classes/jav

hg: jdk8/tl/langtools: 8011677: EndPosTables should avoid hidden references to Parser

2013-04-08 Thread jonathan . gibbons
Changeset: 3f3cc8d3f13c Author:jjg Date: 2013-04-08 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3f3cc8d3f13c 8011677: EndPosTables should avoid hidden references to Parser Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java

hg: jdk8/tl/langtools: 8011676: Instances of Tokens.Comment should not be defined in inner classes

2013-04-08 Thread jonathan . gibbons
Changeset: b402b93cbe38 Author:jjg Date: 2013-04-08 11:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b402b93cbe38 8011676: Instances of Tokens.Comment should not be defined in inner classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/Jav

  1   2   3   4   5   6   >