Integrated: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value

On Fri, 16 Jul 2021 09:16:23 GMT, Jonathan Dowland wrote: > The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java` uses > the IP address "1.1.1.1" as a value. I think at the time the address was > picked, the assumption was the address was not valid /

Re: RFR: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value [v2]

On Fri, 10 Sep 2021 14:17:32 GMT, Daniel Fuchs wrote: >> Jonathan Dowland has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request conta

Re: RFR: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value [v2]

nd to random ports > on localhost for each dummy proxy (as done for the target HTTP server in the > test already). I can do that if preferred. > > <https://bugs.openjdk.java.net/browse/JDK-8270553> Jonathan Dowland has updated the pull request with a new target base due to a m

RFR: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value

The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java` uses the IP address "1.1.1.1" as a value. I think at the time the address was picked, the assumption was the address was not valid / not routable. Since April 2018 the address is part of CloudFlare's "Free" DNS product:

Integrated: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll

On Fri, 12 Mar 2021 09:52:13 GMT, Jonathan Dowland wrote: > This is an adaptation of a patch originally written by Shafi Ahmad in > a comment on the JBS page but never submitted or merged. > > With -Xcheck:jni, the method java.net.NetworkInterface.getAll very > quickly breaches

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v3]

On Mon, 15 Mar 2021 17:10:14 GMT, Chris Hegarty wrote: >> Jonathan Dowland has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains one commit: >> >> 8187450: JNI local refs exceeds capacity warning in >

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll

On Mon, 15 Mar 2021 17:13:16 GMT, Chris Hegarty wrote: > No need to force-push - just push. The Skara workflow will generate > incremental diffs per-push and flatten all commits into one before final > integration into the JDK mainline. Thank you (yes this is my first time…) - PR

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v4]

ype veth peer name > veth${namespace}${num} > sudo ip link set veth${namespace}${num} netns ${namespace} > sudo ip addr add 192.168.2.${num}/24 dev vethhost${num} > sudo ip netns exec ${namespace} ip addr add 192.168.2.${num}/24 dev > veth${namespace}${num} > s

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v3]

ype veth peer name > veth${namespace}${num} > sudo ip link set veth${namespace}${num} netns ${namespace} > sudo ip addr add 192.168.2.${num}/24 dev vethhost${num} > sudo ip netns exec ${namespace} ip addr add 192.168.2.${num}/24 dev > veth${namespace}${num} > s

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v2]

On Mon, 15 Mar 2021 12:53:11 GMT, Chris Hegarty wrote: >> Jonathan Dowland has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > src/java

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v2]

ype veth peer name > veth${namespace}${num} > sudo ip link set veth${namespace}${num} netns ${namespace} > sudo ip addr add 192.168.2.${num}/24 dev vethhost${num} > sudo ip netns exec ${namespace} ip addr add 192.168.2.${num}/24 dev > veth${namespace}${num} >

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll

ork output after doing so, though, and whether the thresholds are breached or not is highly dependent on the status of the test running system's network configuration. -- 👱🏻 Jonathan Dowland Senior Software Engineer, OpenJDK, Red Hat

RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll

This is an adaptation of a patch originally written by Shafi Ahmad in a comment on the JBS page but never submitted or merged. With -Xcheck:jni, the method java.net.NetworkInterface.getAll very quickly breaches the default JNI local refs threshold (32). Exactly when this happens depends upon the n

what happened to JDK-8187450 (JNI local refs exceeds capacity warning in NetworkInterface::getAll)

it only requires minor reworking. Before I go any further, I was wondering if there was any non-obvious reason why this wasn't pursued already? Thanks, -- 👱🏻 Jonathan Dowland Senior Software Engineer, OpenJDK, Red Hat