Re: RFR: JDK-8257401: Use switch expressions in jdk.internal.net.http and java.net.http

2020-11-30 Thread John Jiang
On Sat, 21 Nov 2020 11:45:42 GMT, Kartik Ohri wrote: > Hi! > Kindly review this patch to replace switch statements with switch expressions > (where it makes sense) in the http client modules. The rationale is to > improve readability of the code. > Regards, > Kartik Just a question. Do we hav

RFR[9] JDK-8170641: sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails with timeout

2016-12-26 Thread John Jiang
: https://bugs.openjdk.java.net/browse/JDK-8170641 Best regards, John Jiang

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-06-11 Thread John Jiang
Hi, Just restarted this job. On 2016/4/29 15:34, Alan Bateman wrote: On 28/04/2016 05:50, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi Amy, That's case to case. If a test is using java.logging APIs directly, I declared the module for the test. Otherwise, I didn't. I think that may be more clear. Although a test is using jdk.httpserver, that doesn't mean it also dependents on java.logging. Best regards,

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even though some ones have to declare other modules. Best regards, John Jiang On 2016/4/27 23:07, John Jiang wrote

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi Alan, Felix, Thanks for your comments. Please review the updated webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.01/ Best regards, John Jiang On 2016/4/27 15:08, John Jiang wrote: Hi, Please review the fix for explicitly declaring module dependencies for java net tests

RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi, Please review the fix for explicitly declaring module dependencies for java net tests. Issue: https://bugs.openjdk.java.net/browse/JDK-8151913 Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00 Best regards, John Jiang

Re: RFR: 8087124 HTTP/2 implementation

2016-04-06 Thread John Jiang
Hi Michael, All of HTTP/2 frame types aren't public APIs, then is there any way to handle HTTP/2 at lower level? For example, how to cancel server push? In theory, the client should send a RST_STREAM frame with error code REFUSED_STREAM or CANCEL to the server. Best regards, John Jian