Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c

2012-10-23 Thread Jim Gish
Looks good to me. Jim - Original Message - From: john.zavg...@oracle.com To: net-dev@openjdk.java.net Sent: Tuesday, October 23, 2012 10:57:06 AM GMT -05:00 US/Canada Eastern Subject: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c Greetings: I'm requesting

Re: Indenting code?

2012-09-14 Thread Jim Gish
o do exactly what we want. -Chris. Anyway, the main advice I think is to keep things locally consistent where possible. Also major refactoring or formatting in a bug fix is a royal pain for reviewers. -Alan -- Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304 Oracle Java Pl

Re: GC closes my ServerSocket

2012-06-13 Thread Jim Gish
On 06/13/2012 08:48 AM, Weijun Wang wrote: Automatic Resource Management ? http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html try-with-resources I learned about it when I submitted a test change using try finally (It was recommend that I use this instead :-)