RFR 8207952/11, Problem-list 3 sctp tests

Hi all,     please review the following patch to problem-list 3 sctp tests, which have been observed to be quite unstable on OEL 7 x64. Bug: https://bugs.openjdk.java.net/browse/JDK-8207952 Problem-listing cause: https://bugs.openjdk.java.net/browse/JDK-8141694 Patch: diff -r 6c

Re: RFR 8194260, Point-to-point interface should be excluded from java/net/ipv6tests/*

configured. With null, those tests just quit. -Felix Hopping the code which invokes getFirstLocalIPv4Address, getFirstLocalIPv6Addres already taken care of null. Thanks, Vyom On Wednesday 18 April 2018 11:05 AM, Felix Yang wrote: Hi Chris and Wyom,     fixed as commented.  Updated webrev

Re: RFR 8194260, Point-to-point interface should be excluded from java/net/ipv6tests/*

Hi Chris and Wyom,     fixed as commented.  Updated webrev:     http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.01/ Thanks, Felix On 2018/4/17 16:25, Chris Hegarty wrote: On 17 Apr 2018, at 04:34, Felix Yang wrote: ... http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.00/ Thanks

RFR 8194260, Point-to-point interface should be excluded from java/net/ipv6tests/*

Hi all,    please review the following patch to apply NetworkConfiguration library to exclude point-to-point interfaces. Bug:     https://bugs.openjdk.java.net/browse/JDK-8194260 Webrev:     http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.00/ Thanks, Felix

RFR 8194724/10, Problem list java/net/httpclient/SplitResponseSSL.java

java/net/httpclient/SplitResponseSSL.java has been observed to fail frequently on windows-x64. Propose to problem list it before JDK-8194151 fixed. Bug:     https://bugs.openjdk.java.net/browse/JDK-8194724 Patch: diff -r 069c82c31914 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  M

RFR 8191172/10, Problem list java/net/httpclient/websocket/ConnectionHandover.java

Hi all,     please review a minor change to problem list java/net/httpclient/websocket/ConnectionHandover.java temporarily. It has been changed a lot in sandbox, so this test can be resumed after future updates from sandbox. Bug:   https://bugs.openjdk.java.net/browse/JDK-8191172 Origi

RFR 8187026/10, Remove intermittent key from java/net/httpclient/http2/BasicTest.java

Hi there,    please review a minor patch to remove key intermittent. The original bug has been resolved in JDK-8177935 and no intermittent failure observed since there. Bug:     https://bugs.openjdk.java.net/browse/JDK-8187026 Patch: diff -r 777356696811 test/java/net/httpclient/http2/Basi

Re: RFR 8085875/10, java/net/DatagramSocket/PortUnreachable.java fails intermittently: Address already in use

tely right, recreateServerSocket is fine then. Best regards Christoph -Original Message- From: Mark Sheppard [mailto:mark.shepp...@oracle.com] Sent: Donnerstag, 7. September 2017 13:07 To: Langer, Christoph ; Felix Yang Cc: net-dev@openjdk.java.net Subject: Re: RFR 8085875/10, java/net/Data

RFR 8085875/10, java/net/DatagramSocket/PortUnreachable.java fails intermittently: Address already in use

Hi all,     please review a patch to add retries to avoid possible port conflicts during re-binding. Bug:     https://bugs.openjdk.java.net/browse/JDK-8085875 Webrev:     http://cr.openjdk.java.net/~xiaofeya/8085875/webrev.00/ Thanks, Felix

Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

Hi Chris,   pushed with build tags. Thanks, Felix On 2017/9/4 17:42, Chris Hegarty wrote: On 4 Sep 2017, at 06:29, Felix Yang <mailto:felix.y...@oracle.com>> wrote: Hi Mark and Roger,     thanks for the comments. Adjusted the test to just simply print information for al

Re: RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

yMatch:. Maybe something like: List nis = NetworkInterface.networkInterfaces()     .filter(i -> !i.equals(ni))     .filter(i -> i.inetAddresses().anyMatch(n -> n.equals(ia)))     .collect(Collectors.toList()); $.02, Roger On 9/1/2017 3:47 A

RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

Hi there,     please review a test patch for isolating a network configuration issue, which led to TestInterfaces failing from time to time. Bug:     https://bugs.openjdk.java.net/browse/JDK-8134989 Webrev:     http://cr.openjdk.java.net/~xiaofeya/8134989/webrev.00/ Thanks, Felix

Re: RFR 8186818/10, Enable debug option for TcpTest.java

Roger,     thanks for the review. Updated a bit with Mark's comment in bug. http://cr.openjdk.java.net/~xiaofeya/8186818/webrev.00/ Thanks, Felix On 2017/8/28 21:50, Roger Riggs wrote: Hi Felix, Looks fine. Roger On 8/28/2017 3:51 AM, Felix Yang wrote: Hi there,     please revie

RFR 8186818/10, Enable debug option for TcpTest.java

Hi there,     please review the patch to enable debug diagnostic for test/java/net/ipv6tests/TcpTest.java. Then we can know which addresses are being used, to isolate possible multi-homed issues. Bug:     https://bugs.openjdk.java.net/browse/JDK-8186818 Patch: diff -r 162c0a6e1fe3 test/jav

Re: [JDK 10] RFR: 8185794: java/net/httpclient/security/Driver.java fails in timeout

Hi Daniel, two comments: 1. you may need to change the copy right year from 2016 to 2017 2. If I remember correctly, Chris suggested to add copyright to all policy files. Probably you can add together, though not purpose of this bug. Thanks, Felix On 2017/8/4 2:21, Daniel Fuchs wrote: H

RFR 8183514/10, Remove intermittent key from httpclient test TimeoutOrdering and ErrorTest

Hi there, please review a patch to remove intermittent key from test/java/net/httpclient/TimeoutOrdering.java test/java/net/httpclient/http2/ErrorTest.java. They have been observed to be stable after fixing of related bugs. Bug: https://bugs.openjdk.java.net/browse/JDK-8183514 Patch

RFR 8182975/10, Mark http2/BasicTest.java and FixedThreadPoolTest.java as intermittently failing

Hi all, please review a minor patch to add key intermittent to two tests. They have been observed to be failing intermittently. Bug: https://bugs.openjdk.java.net/browse/JDK-8182975 Patch: diff -r 7cef1c3f1dbe test/java/net/httpclient/http2/BasicTest.java --- a/test/java/net/httpcli

Re: RFR 8178699/10, Fail to send async requests if server doesn't response the first one

gt; If you still have the full thread-dump where the issue could > be observed it might be good to record it in JDK-8178699 > (if you no longer have it then don't bother). > > best regards, > > -- daniel > >> On 23/06/2017 09:59, Felix Yang wrote

RFR 8178699/10, Fail to send async requests if server doesn't response the first one

Hi all, please review the following patch to API in jdk.incubator.httpclient. The patch is more like a clean-up: * With current RequestProcessor implementation, constructing multiple HTTP Exchange may be blocked if the first request doesn't response by server side. This is introduced

Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

y exceptions. This was originally added by Max in https://bugs.openjdk.java.net/browse/JDK-7078355. TO Max, could you comment if such chmod is still necessary? If yes, since this is just for test clean-up rather than a part of test logic, is it enough with "File.setReadable(...)"? -

RFR 8181635/10, sun/net/www/protocol/jar/B6449504.java fails at Windows platform (after JDK-8181414)

Hi, please review the patch to make the test run with othervm mode. It has been observed to be failing in agentvm mode, because Jar connection is not closed in prior test. Bug: https://bugs.openjdk.java.net/browse/JDK-8181635 Patch: --- old/test/sun/net/www/protocol/jar/B6449504.java

Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Thanks:-) -Felix On 2017/6/1 16:32, Felix Yang wrote: Hi there, please review the patch convert several sun/net shell tests to plain java tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8181080 Webrev: http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.00/ Thanks

Re: RFR 8166139/10, Refactor java/net shell cases to java

Hi Chris, pushed, thank you very much! -Felix On 2017/5/30 17:44, Chris Hegarty wrote: On 29/05/17 16:17, Felix Yang wrote: Hi Chris, please review the updated webrev below. Comments inline. http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.03/ Thanks Felix. .. 2) test/java

Re: RFR 8166139/10, Refactor java/net shell cases to java

According with JDK-503, it is to cover endorsed scenarios, while endorsed mechanism has been removed in JDK 9. -Felix -Chris. On 27/05/17 02:15, Felix Yang wrote: Hi Roger, thanks for the comments. Please see the new webrev http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.02/

Re: RFR 8166139/10, Refactor java/net shell cases to java

ir"). It is not expected to run outside jtreg. -Felix URLConnection/6212146/Test.java:47 typo: ULR -> URL Regards, Roger On 5/25/2017 11:14 PM, Felix Yang wrote: Hi Roger, please review the updated webrev: http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.01/ Thanks, Felix On 2017

Re: RFR 8166139/10, Refactor java/net shell cases to java

(Not a reviewer.) Thanks, Amy [1] http://hg.openjdk.java.net/jdk10/jdk10/file/tip/test/lib/jdk/test/lib/compiler/CompilerUtils.java On 5/26/17 11:14 AM, Felix Yang wrote: Hi Roger, please review the updated webrev: http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.01/ Thanks, Fe

Re: RFR 8166139/10, Refactor java/net shell cases to java

d. That is because corresponding prerequisite was removed even in JDK 8. -Felix Regards, Roger On 5/25/2017 4:08 AM, Felix Yang wrote: Hi there, please review following patch to convert all shell cases under java/net to plain java codes. Webrev: http://cr.openjdk.java.net/~xiaofe

RFR 8166139/10, Refactor java/net shell cases to java

Hi there, please review following patch to convert all shell cases under java/net to plain java codes. Webrev: http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8166139 Thanks, Felix

Re: RFR 8169115, java/net/InetAddress/ptr/lookup.sh failed intermittently

rds Christoph -Original Message- From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Felix Yang Sent: Donnerstag, 8. Dezember 2016 11:35 To: Dmitry Samersoff ; core-libs- d...@openjdk.java.net; net-dev@openjdk.java.net; CHRIS.HEGARTY Subject: Re: RFR 8169115, java/net/In

Re: RFR 8169115, java/net/InetAddress/ptr/lookup.sh failed intermittently

tack=true that do A and PRT lookup in one run. 2. Read results of process above, do PTR lookup with default settings and compare results. -Dmitry On 2016-12-06 12:06, Felix Yang wrote: Hi, please review the following patch. It generally coverts codes from shell t

Ping - Re: RFR 8043838, Test java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java failed intermittently in nightly

:-) -Felix > On 6 Dec 2016, at 9:28 AM, Felix Yang wrote: > > Add core-libs. > > Thanks, > Felix > On 2016/12/5 22:14, Felix Yang wrote: >> Hi, >> >> updated webrev. May I have a reviewer to review this >> >> http://cr.openjdk.java.net/~x

Re: RFR 8169115, java/net/InetAddress/ptr/lookup.sh failed intermittently

o A and PRT lookup in one run. 2. Read results of process above, do PTR lookup with default settings and compare results. -Dmitry On 2016-12-06 12:06, Felix Yang wrote: Hi, please review the following patch. It generally coverts codes from shell to plain java. Bug: https://bu

RFR 8169115, java/net/InetAddress/ptr/lookup.sh failed intermittently

Hi, please review the following patch. It generally coverts codes from shell to plain java. Bug: https://bugs.openjdk.java.net/browse/JDK-8169115 Webrev: http://cr.openjdk.java.net/~xiaofeya/8169115/webrev.00/ Thanks, Felix

Re: RFR 8043838, Test java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java failed intermittently in nightly

Add core-libs. Thanks, Felix On 2016/12/5 22:14, Felix Yang wrote: Hi, updated webrev. May I have a reviewer to review this http://cr.openjdk.java.net/~xiaofeya/8043838/webrev.01/ -Felix On 2016/12/5 15:50, Felix Yang wrote: On 2016/12/5 15:47, Langer, Christoph wrote: Hi Felix

Re: RFR 8043838, Test java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java failed intermittently in nightly

Hi, updated webrev. May I have a reviewer to review this http://cr.openjdk.java.net/~xiaofeya/8043838/webrev.01/ -Felix On 2016/12/5 15:50, Felix Yang wrote: On 2016/12/5 15:47, Langer, Christoph wrote: Hi Felix, looks ok to me. You probably should remove the reference to the old

Re: RFR 8043838, Test java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java failed intermittently in nightly

On 2016/12/5 15:47, Langer, Christoph wrote: Hi Felix, looks ok to me. You probably should remove the reference to the old shell script in comment line 25, though: 25 * Test run from script, AcceptCauseFileDescriptorLeak.sh Christoph, Good catch! Thanks, Felix Best regards Christoph

RFR 8043838, Test java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java failed intermittently in nightly

Hi all, please review the following patch to cover the codes from shell to plain java. Bug: https://bugs.openjdk.java.net/browse/JDK-8043838 Webrev: http://cr.openjdk.java.net/~xiaofeya/8043838/webrev.00/ Thanks, Felix

Re: RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

d also suggest to use try-with-resource to close in CacheImpl (int port) and CacheImpl::writeMap to make sure the file is always properly closed. Updated all the history codes, as you suggested Thanks, Felix best regards, -- daniel On 01/12/16 09:47, Felix Yang wrote: Hi, please review the

RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

Hi, please review the following patch. The code was converted from shell script to plain Java. Since it is by-design to bind on a prior-used port, add a few of re-tries for possible BindException. Bug: https://bugs.openjdk.java.net/browse/JDK-8162521 Webrev: http://cr.openjdk.j

Re: RFR 8156504/9, java/net/URLPermission/nstest/lookup.sh fails intermittently

. + 1 for getting rid of the AccessControlContext. I was not very comfortable with that either. cheers, -- daniel -Chris. On 2 Nov 2016, at 07:10, Felix Yang wrote: Hi Amy, thanks for the comments. Updated webrev: http://cr.openjdk.java.net/~xiaofeya/8156504/webrev.01/ -Felix On 2016

Re: RFR 8156504/9, java/net/URLPermission/nstest/lookup.sh fails intermittently

This might be reformatted automatically by IDE, but just feel previous one is more easy to read. Thanks, Amy On 11/2/16 10:39 AM, Felix Yang wrote: Hi there, please review the following patch for an intermittent failing test. Converted it into plain java test and avoid free port anti-pa

RFR 8156504/9, java/net/URLPermission/nstest/lookup.sh fails intermittently

Hi there, please review the following patch for an intermittent failing test. Converted it into plain java test and avoid free port anti-pattern. Bug: https://bugs.openjdk.java.net/browse/JDK-8156504 Webrev: http://cr.openjdk.java.net/~xiaofeya/8156504/webrev.00/ Thanks, Felix

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

Chris, I will push without othervm -Felix On 2016/9/27 16:29, Chris Hegarty wrote: On 27 Sep 2016, at 09:25, Felix Yang wrote: Hi Chris, updated as suggested http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ Looks good to me. Up to you, but with the thread join ( if my

Re: RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

Hi Chris, updated as suggested http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ Thanks, Felix On 2016/9/27 15:55, Chris Hegarty wrote: On 27 Sep 2016, at 03:08, Felix Yang wrote: Hi all, please review following test fix. Bug: https://bugs.openjdk.java.net/browse/JDK

RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

Hi all, please review following test fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8154525 Webrev: http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.00/ This test has been observed to fail sometimes with "Error while cleaning up threads after test ", even after test compl

Re: RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

close(); > > which looks strange to me... > > best regards, > > -- daniel > > > On 26/09/16 08:56, Felix Yang wrote: >> Hi there, >> >>please review following patch to a few of java.net tests. >> >> Bug: >> >>https://bug

Re: RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

java may run into intermittent failure unless it is run > single alone. > > Xuelei > > On 9/26/2016 3:56 PM, Felix Yang wrote: >> Hi there, >> >>please review following patch to a few of java.net tests. >> >> Bug: >> >>

RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

Hi there, please review following patch to a few of java.net tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8085575 https://bugs.openjdk.java.net/browse/JDK-8130657 Webrev: http://cr.openjdk.java.net/~xiaofeya/8085575_8130657/webrev.00/ Add retry for java/net/Socket/Inheri

RFR 8085049/9, java/net/MulticastSocket/TimeToLive.java fails intermittently with "Address already in use"

Hi there, please review a minor test fix to avoid hard-coded port usage, which leads to "Address already in use" issue intermittently. Bug: https://bugs.openjdk.java.net/browse/JDK-8085049 Since it is just a 1 line change, just print the patch here: diff -r 83030d149c5c test/java/ne

Re: RFR 8166359/9, java/net/URLPermission/nstest/lookup.sh fails if proxy is set, since fix for JDK-8161016

Hi Chris, On 2016/9/20 23:22, Chris Hegarty wrote: Felix, On 20 Sep 2016, at 13:57, Felix Yang wrote: Hi all, please review the following test fix. It explicitly disables proxy to make sure the test not affected by different environment configuration. Bug: https

RFR 8166359/9, java/net/URLPermission/nstest/lookup.sh fails if proxy is set, since fix for JDK-8161016

Hi all, please review the following test fix. It explicitly disables proxy to make sure the test not affected by different environment configuration. Bug: https://bugs.openjdk.java.net/browse/JDK-8166359 Webrev: http://cr.openjdk.java.net/~xiaofeya/8166359/webrev.00/

Re: RFR 8163561, add a test for Proxy Authentication in HTTP/2 Client API

Hi Chris, thanks for the comments. Updated webrev: http://cr.openjdk.java.net/~xiaofeya/8163561/webrev.01/ Thanks, Felix On 2016/8/18 23:43, Chris Hegarty wrote: On 18 Aug 2016, at 10:26, Felix Yang wrote: Hi all, please review a new test, which tries to verify "Proxy-Authent

RFR 8163561, add a test for Proxy Authentication in HTTP/2 Client API

Hi all, please review a new test, which tries to verify "Proxy-Authenticate" header can be handled correctly. Bug: https://bugs.openjdk.java.net/browse/JDK-8163561 Webrev: http://cr.openjdk.java.net/~xiaofeya/8163561/webrev.00/ Thanks, Felix

RFR 8163149/9, Typo in java.net.http.AuthenticationFilter

Hi there, please review a simple patch for java.net.http.AuthenticationFilter. There is a typo in the code. "Proxy-Authentication" should be replaced with "Proxy-Authenticate" Bug: https://bugs.openjdk.java.net/browse/JDK-8163149 Webrev: http://cr.openjdk.java.net/~xiaofeya/8163149/webrev

Re: RFR JDK-8156742: Miscellaneous WebSocket API improvements

Hi Pavel, one comment: http://cr.openjdk.java.net/~prappo/8156742/webrev.01/src/java.httpclient/share/classes/java/net/http/WebSocket.java.udiff.html The CloseReason is constructed with read only Buffer as following: + private CloseReason(WSCloseCode code, String description, ByteBuffer d

RFR 8157816, Mark 4 httpclient tests as intermittently failing

Hi all, please review the change to mark following tests with keyword 'intermittent'. These tests have been observed to fail intermittently for a while. test/java/net/httpclient/SplitResponse.java test/java/net/httpclient/http2/BasicTest.java test/java/net/httpclient/http2/ErrorTest.java tes

RFR 8156509/9: Mark java/net/httpclient/security/Security.java as intermittently failing

Hi there, please review the following patch to mark java/net/httpclient/security/Security.java with keyword 'intermittent'. It has been observed to fail intermittently. Thanks, Felix diff -r 2569a85ce76a test/java/net/httpclient/security/Security.java --- a/test/java/net/httpclient/secu

Re: RFR JDK-8087113: Websocket API and implementation

Hi Pavel, several comments: 1. WebSocket.request(long n) is documented as " @throws IllegalArgumentException if n < -1 " It looks meaningless to allow 0. 2. Some concern on the way of handling close. Consider following scenario. * obtain a ws connection * message communications bala

Re: RFR 8154543, NetworkInterfaceStreamTest.java fails intermittently after JDK-8146758

Thanks, Chris :-) -Felix On 2016/4/20 15:26, Chris Hegarty wrote: This looks ok to me Felix. -Chris. On 20 Apr 2016, at 08:07, Felix Yang wrote: Hi there, I introduced a problem in fix for JDK-8146758. When calling allNetworkInterfaces(), it will concat sub interfaces into the stream

RFR 8154543, NetworkInterfaceStreamTest.java fails intermittently after JDK-8146758

Hi there, I introduced a problem in fix for JDK-8146758. When calling allNetworkInterfaces(), it will concat sub interfaces into the stream incorrectly. Then the test fails on a Solaris host which has virtual(sub) interfaces. Bug: https://bugs.openjdk.java.net/browse/JDK-8154543 Webrev: h

Re: RFR 8146758, NetworkInterfaceStreamTest.java fails intermittently at comparing network interfaces

Hi Chris, thanks for the review. Could you sponsor the change? Thanks, Felix On 2016/4/15 18:45, Chris Hegarty wrote: On 15/04/16 10:29, Felix Yang wrote: Hi all, please review the following fix. It is an intermittent failure because of Teredo Tunneling Pseudo-Interface. Bug: https

RFR 8146758, NetworkInterfaceStreamTest.java fails intermittently at comparing network interfaces

Hi all, please review the following fix. It is an intermittent failure because of Teredo Tunneling Pseudo-Interface. Bug: https://bugs.openjdk.java.net/browse/JDK-8146758 Webrev: http://cr.openjdk.java.net/~xiaofeya/8146758/webrev.00/ Thanks, Felix

Re: RFR 8065076/9, test/java/net/SocketPermission/SocketPermissionTest.java failed intermittently

016, at 12:45 PM, Chris Hegarty wrote: > > On 20 Jan 2016, at 06:36, Chris Hegarty <mailto:chris.hega...@oracle.com>> wrote: > >> Felix, >> >> On 14 Jan 2016, at 06:07, Felix Yang wrote: >> >>> Hi all, >>> please review the fix fo

RFR 8065076/9, test/java/net/SocketPermission/SocketPermissionTest.java failed intermittently

Hi all, please review the fix for test/java/net/SocketPermission/SocketPermissionTest.java, which fails frequently with "java.net.BindException: Address already in use". Bug: https://bugs.openjdk.java.net/browse/JDK-8065076 Webrev: http://cr.openjdk.java.net/~xiaofeya/8065076/webrev.00 Th

Re: RFR 8133704/9, java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java may fail with address already in use

Hi Chris, thank you very much! -Felix On 2016/1/8 22:08, Chris Hegarty wrote: Hi Felix, On 08/01/16 08:36, Felix Yang wrote: Hi all, please review the fix for java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java Bug: https://bugs.openjdk.java.net/browse/JDK

RFR 8133704/9, java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java may fail with address already in use

Hi all, please review the fix for java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java Bug: https://bugs.openjdk.java.net/browse/JDK-8133704 Webrev: http://cr.openjdk.java.net/~xiaofeya/8133704/webrev.00 It is using hard-coded port 4445 for the server side. This fix upda

Re: RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

Thanks Chris! I will remove bug id as you suggested. TO Frank, could you sponsor the fix? Thanks, Felix On 2016/1/6 17:56, Chris Hegarty wrote: Thank Felix. On 06/01/16 08:27, Felix Yang wrote: Hi Chris, updated webrev with your suggestion: http://cr.openjdk.java.net/~xiaofeya

Re: RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

Hi Chris, updated webrev with your suggestion: http://cr.openjdk.java.net/~xiaofeya/8140472/webrev.01/ Thanks, Felix On 2016/1/6 13:49, Chris Hegarty wrote: Hi Felix, On 6 Jan 2016, at 05:09, Felix Yang wrote: Hi all, please review the fix for java/net/ipv6tests/TcpTest.java

RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

Hi all, please review the fix for java/net/ipv6tests/TcpTest.java, which replaces hard-coded ports with dynamic free ports on runtime. Bug: https://bugs.openjdk.java.net/browse/JDK-8140472 Webrev: http://cr.openjdk.java.net/~xiaofeya/8140472/webrev.00 Thanks, Felix

Re: RFR 8146209/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java still fails after fix JDK-8131155

Hi Chris, could you sponsor this fix? Thanks, Felix > On Dec 26, 2015, at 12:33 AM, Chris Hegarty wrote: > > This looks fine Felix, thanks. > > -Chris > >> On 25 Dec 2015, at 06:29, Felix Yang wrote: >> >> Hi all, >> please review

RFR 8146209/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java still fails after fix JDK-8131155

Hi all, please review the fix for java/net/NetworkInterface/NetworkInterfaceStreamTest.java. There are some situations missed in prior fix for JDK-8131155, which should also exclude "Teredo Tunneling Pseudo-Interface". Bug: https://bugs.openjdk.java.net/browse/JDK-8146209 Webrev: http://c

Re: RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

Chris/Paul/Amy, thank you very much for your comments. I produced a new webrev by 1) renaming isWindows to "IS_WINDOWS' 2) removing @intermittent 3) adding 8131155 to @bug Webrev: http://cr.openjdk.java.net/~xiaofeya/8131155/webrev.01/ If it is OK, I need a sponsor. Thanks again, Felix On

RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

Hi all, please review the fix for java/net/NetworkInterface/NetworkInterfaceStreamTest.java. It is necessary to exclude "Teredo Tunneling Pseudo-Interface" whose configuration changes frequently. Bug: https://bugs.openjdk.java.net/browse/JDK-8131155 Webrev: http://cr.openjdk.java.net/~xia

Re: RFR 8042581: Intermittent failure in java/net/DatagramSocket/InheritHandle.java

Thanks for looking at this, Alan and Chris. Please check the updated webrev: http://cr.openjdk.java.net/~xiaofeya/8042581/webrev.01/ -Felix On 12/29/2014 11:51 PM, Alan Bateman wrote: On 29/12/2014 15:46, Chris Hegarty wrote: Looks ok Felix. You could put the construction of the new Datagram

RFR 8042581: Intermittent failure in java/net/DatagramSocket/InheritHandle.java

Hi all, please review the fix for 8042581. This failure was only observed on Windows, so it is most possibly because the socket.close() on Windows is processed asynchronously within the Windows API layer (TCP machine) . Add 5 times of tries to the test if BindException is encountered on Win

Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

Hi Chris, I think it is necessary to add a regression test case for this issue? There was a similar issue on DatagramSocket, https://bugs.openjdk.java.net/browse/JDK-4945514. "test/java/net/DatagramSocket/InheritHandle.java" was created for it. Thanks, -Felix On 12/18/2014 10:01 PM, Chr