On Fri, 15 Oct 2021 08:49:20 GMT, Evan Whelan wrote:
> Hi,
>
> Please review my fix for JDK-8274779 which changes how HttpClient and
> HttpsClient checks for equality when comparing request methods.
>
> When `HttpURLConnection.setRequestMethod` is passed `new String("
On Wed, 20 Oct 2021 14:52:45 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setReques
a new HttpClient should
> be created in cases where we can no longer use the cached one.
>
> All CI testing is green for this fix.
>
> Kind regards,
> Evan
Evan Whelan has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views w
On Tue, 19 Oct 2021 17:19:08 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added setInCache to HttpClientAccess to replace reflection
>
> test/jdk/sun/n
a new HttpClient should
> be created in cases where we can no longer use the cached one.
>
> All CI testing is green for this fix.
>
> Kind regards,
> Evan
Evan Whelan has updated the pull request incrementally with one additional
commit since the last revision:
Removed +ope
a new HttpClient should
> be created in cases where we can no longer use the cached one.
>
> All CI testing is green for this fix.
>
> Kind regards,
> Evan
Evan Whelan has updated the pull request incrementally with one additional
commit since the last revision:
Added setInCach
On Fri, 15 Oct 2021 15:25:33 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Extracted both connectTimeouts to variables and added copyright header to
>> access
On Fri, 15 Oct 2021 09:38:50 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Extracted both connectTimeouts to variables and added copyright header to
>> access
a new HttpClient should
> be created in cases where we can no longer use the cached one.
>
> All CI testing is green for this fix.
>
> Kind regards,
> Evan
Evan Whelan has updated the pull request incrementally with two additional
commits since the last revision:
- Extracted bo
On Fri, 15 Oct 2021 09:36:06 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Extracted both connectTimeouts to variables and added copyright header to
>> access
a new HttpClient should
> be created in cases where we can no longer use the cached one.
>
> All CI testing is green for this fix.
>
> Kind regards,
> Evan
Evan Whelan has updated the pull request incrementally with one additional
commit since the last revision:
Test
Hi,
Please review my fix for JDK-8274779 which changes how HttpClient and
HttpsClient checks for equality when comparing request methods.
When `HttpURLConnection.setRequestMethod` is passed `new String("POST")` rather
than the "POST" String literal, the old behaviour resulted in broken
HttpC
On Thu, 28 Jan 2021 16:42:02 GMT, Evan Whelan wrote:
> Hi all,
>
> Please review this fix for which corrects the order in which field values are
> returned from the `HttpURLConnection.getHeaderFields` and
> `URLConnection.getRequestProperties` methods.
>
> Currently,
reverse.
> This does not conform with the RFC2616 spec which outlines that the order of
> these field values should not be changed.
>
> Thanks,
> Evan
Evan Whelan has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
reverse.
> This does not conform with the RFC2616 spec which outlines that the order of
> these field values should not be changed.
>
> Thanks,
> Evan
Evan Whelan has updated the pull request incrementally with one additional
commit since the last revision:
MessageHe
reverse.
> This does not conform with the RFC2616 spec which outlines that the order of
> these field values should not be changed.
>
> Thanks,
> Evan
Evan Whelan has updated the pull request incrementally with one additional
commit since the last revision:
URLConnecti
On Thu, 28 Jan 2021 17:02:31 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> URLConnection doc fixes
>
> src/java.base/share/classes/java/net/URLConne
Hi all,
Please review this fix for which corrects the order in which field values are
returned from the `HttpURLConnection.getHeaderFields` and
`URLConnection.getRequestProperties` methods.
Currently, the implementation of these methods returns the values in reverse.
This does not conform with
nd is found at:
https://bugs.openjdk.java.net/browse/JDK-8252456
Please let me know if you have any more suggestions or feedback.
Kind regards,
Evan
-Original Message-
From: Daniel Fuchs
Sent: Thursday 27 August 2020 20:01
To: Evan Whelan ; net-dev@openjdk.java.net
Subject: Re: RFR 81
.
Thanks in advance,
Evan
From: Evan Whelan
Sent: Friday 14 August 2020 13:10
To: net-dev@openjdk.java.net
Subject: RFR 8133686: REOPEN JDK-8080659 : HttpURLConnection?s getHeaderFields
method returns field values in reverse order
Hi all,
I'm Evan and I've just recently
Hi all,
I have another small fix for net-dev reviewers.
This is a small fix to the java/net/URL.java documentation to add a link to one
of the constructors.
--- old/open/src/java.base/share/classes/java/net/URL.java 2020-08-18
14:53:33.886033182 +
+++ new/open/src/java.base/share/
Hi all,
I'm Evan and I've just recently joined the Java Platform Group here in Oracle
so this is my first time getting to interact with the OpenJDK Community.
This is a request to review my fix for
https://bugs.openjdk.java.net/browse/JDK-8133686
The webrev for this fix can be found a
22 matches
Mail list logo
