Re: InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2013-01-09 Thread Deven You
Hi Michael, Any progress in the review of this CCC request? Thanks a lot! On 11/23/2012 11:50 PM, Michael McMahon wrote: Hi Deven The CCC request is entered on the system but not reviewed yet. I will get back to you next week after the US break. - Michael. On 23/11/12 08:10, Deven You wrote

Re: InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2012-11-23 Thread Deven You
Hi Michael, Is there any progress for the CCC request? I hope we can get some update from you. Thanks a lot! On 08/03/2012 03:29 PM, Deven You wrote: Hi Michael, Any suggestion or comments for this issue? Thanks a lot! On 08/01/2012 01:49 PM, Deven You wrote: Hi Michael, I have

Re: InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2012-08-03 Thread Deven You
Hi Michael, Any suggestion or comments for this issue? Thanks a lot! On 08/01/2012 01:49 PM, Deven You wrote: Hi Michael, I have submitted a sun bug 7188315. I do not know about CCC request, if needed, please conduct me to request it. Thanks a lot! On 07/31/2012 05:32 PM, Michael McMahon

Re: InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2012-07-31 Thread Deven You
Michael On 31/07/12 08:14, Deven You wrote: Hi Michael, Thanks for your review, I have updated the patch[1] according to your comments. [1] http://cr.openjdk.java.net/~youdwei/ojdk-527/webrev.03/ <http://cr.openjdk.java.net/%7Eyoudwei/ojdk-527/webrev.02/> Thanks a lot! On 07/25/2012

Re: InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2012-07-31 Thread Deven You
/12 07:17, Deven You wrote: Hi Alan and Michael, I add a java doc[1] for the new networkaddress.cache.localhost.ttl property. Please take a look when you have time. The change looks fine to me. There is a typo in the apidoc in InetAddress. "as as" should be "as an". Migh

Re: InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2012-07-23 Thread Deven You
a.net/~youdwei/ojdk-527/webrev.01/ <http://cr.openjdk.java.net/%7Eyoudwei/ojdk-527/webrev.01/> Thanks a lot! On 07/12/2012 02:59 PM, Deven You wrote: Hi Alan and Michael, Thanks very much for your kind suggestions. I agree that local host shouldn't follow the default caching mechanism

Re: InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2012-07-12 Thread Deven You
e fallback properties so I have no idea where I can do the same thing for networkaddress.cache.localhost.ttl. Please take a look. Thanks a lot! On 07/11/2012 06:55 PM, Michael McMahon wrote: On 11/07/12 08:00, Alan Bateman wrote: On 05/07/2012 07:10, Deven You wrote: Hi All, I no

Re: InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2012-07-09 Thread Deven You
Hi All, There is anybody notice this issue. Thanks a lot! On 07/05/2012 02:10 PM, Deven You wrote: Hi All, I noticed that InetAddress.getLocalHost() uses cache to improve the performance. However the default implementation is caching local host within 5 seconds. From the spec

InetAddress should utilize networkaddress.cache.ttl for getLocalHost() too

2012-07-04 Thread Deven You
Hi All, I noticed that InetAddress.getLocalHost() uses cache to improve the performance. However the default implementation is caching local host within 5 seconds. From the spec, networkaddress.cache.ttl should be used to control the cache behaviour and I think it is a better solution. For

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-05-13 Thread Deven You
: InetAddress.isReachable should support pinging 0.0.0.0 Reviewed-by: alanb, chegar Please verify it and thank you all for reviewing it. On 05/09/2012 11:36 AM, Deven You wrote: Hi Alan, Since this patch is for Unix like platforms, I didn't test the test case on Windows yet. However when I t

Using OP_CONNECT with Selector.select causes selector to fire repeatedly

2012-05-09 Thread Deven You
Hi All, When start a simple server, listening on a port like 8765, which just accepts connections. We then register a non-blocking SocketChannel (the client) with a selector with interest in OP_CONNECT, so that we can use the selector to notify us when the channel is ready to finish connecting

Re: Using OP_CONNECT with Selector.select causes selector to fire repeatedly

2012-05-09 Thread Deven You
I suddenly realized this topic should be in nio-dev mailing list. Please ignore previous mail. Thanks a lot! On 05/09/2012 03:26 PM, Deven You wrote: Hi All, When start a simple server, listening on a port like 8765, which just accepts connections. We then register a non-blocking

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-05-08 Thread Deven You
rther investigation to see why these 2 addresses can not be reachable or we just think it is the proper behavior because JDK's behavior is consistent with ping on Windows? Thanks a lot! On 05/07/2012 03:46 PM, Alan Bateman wrote: On 07/05/2012 03:29, Deven You wrote: Hi Alan and Chris, I have u

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-05-06 Thread Deven You
Hi Alan and Chris, I have updated the webrev[1] according to your suggestions. For the test case, I did two things: 1. add the @run main/othervm -Djava.net.preferIPv4Stack=true PingThis 2. Only when !preferIPv4Stack and hasIPv6(), ::0 will be added into the address list. I think it's enough

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-27 Thread Deven You
Hi Alan, I have updated the patch and test[1] for ::0. Please review it. [1] http://cr.openjdk.java.net/~littlee/OJDK-217/webrev.03/ Thanks a lot! On 04/27/2012 04:41 PM, Alan Bateman wrote: On 27/04/2012 06:47, Deven You wrote: Hi Alan, Sorry for the test results of PingThis.java on ::0

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-26 Thread Deven You
Hi Alan, Sorry for the test results of PingThis.java on ::0. I just missed to test it with sudo privilege. Actually It also fails with sudo privilege. I will look into the ipv6 branch to see why the ::0 also fails. Thanks a lot! On 04/27/2012 09:35 AM, Deven You wrote: Hi Alan, I have

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-26 Thread Deven You
mentation for ::0. [2] http://cr.openjdk.java.net/~littlee/OJDK-217/webrev.02/ Thanks a lot! On 04/25/2012 05:15 PM, Alan Bateman wrote: On 25/04/2012 07:18, Deven You wrote: Hi Michael, I also add the bug number into the test case[1], please review it: [1] http://cr.openjdk.java.net/~youdwei

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-24 Thread Deven You
appear to support pinging 0.0.0.0. What is the official position on 0.0.0.0 as a destination address? - Michael. On 23/04/12 06:57, Deven You wrote: On 04/09/2012 03:57 PM, Deven You wrote: Hi net-devs, There is a test case [1] can reproduce this problem. Please use root privilege to run this

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-24 Thread Deven You
. What is the official position on 0.0.0.0 as a destination address? - Michael. On 23/04/12 06:57, Deven You wrote: On 04/09/2012 03:57 PM, Deven You wrote: Hi net-devs, There is a test case [1] can reproduce this problem. Please use root privilege to run this test case(create raw socket need

Re: Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-22 Thread Deven You
On 04/09/2012 03:57 PM, Deven You wrote: Hi net-devs, There is a test case [1] can reproduce this problem. Please use root privilege to run this test case(create raw socket need root privilege). Test results: sudo ~/jdks/oracle/jdk1.7.0_03/bin/java Javanet The target ip is 0.0.0.0 the

Java_java_net_Inet6AddressImpl_isReachable0 is returning false for InetAdress 0.0.0.0

2012-04-09 Thread Deven You
Hi net-devs, There is a test case [1] can reproduce this problem. Please use root privilege to run this test case(create raw socket need root privilege). Test results: sudo ~/jdks/oracle/jdk1.7.0_03/bin/java Javanet The target ip is 0.0.0.0 the target is reachable: false Test failed Exception