Thank you, Daniel
Regards,
Chris
> On 19 Nov 2018, at 5:40 PM, Daniel Fuchs wrote:
>
> Looks good to me Chris!
>
> best regards,
>
> -- daniel
>
> On 19/11/2018 03:03, Chris Yin wrote:
>> Hi, Daniel
>>> On 16 Nov 2018, at 7:13 PM, Daniel Fuchs wro
, yes, that’s make sense since the original logic
“return reason” may also return null if no failure message, update webrev as
below.
http://cr.openjdk.java.net/~xyin/8129310/webrev.03/
Thanks,
Chris
>
> best regards,
>
> -- daniel
>
> On 16/11/2018 03:58, Chris Yin wrote:
://cr.openjdk.java.net/~xyin/8129310/webrev.02/
Regards,
Chris
> On 16 Nov 2018, at 10:39 AM, Chris Yin wrote:
>
> Hi, Daniel
>
> Thanks a lot for your reviewing and comments, revision webrev as below.
>
> http://cr.openjdk.java.net/~xyin/8129310/webrev.01/
>
> Regards,
> Chris
&g
hanges
> work as you expect.
>
> best regards,
>
> -- daniel
>
> On 15/11/2018 09:12, Chris Yin wrote:
>> Please review below minor change for
>> java/net/Socket/asyncClose/AsyncClose.java fails intermittently issue, thanks
>> From previous failure log, seems
Please review below minor change for java/net/Socket/asyncClose/AsyncClose.java
fails intermittently issue, thanks
From previous failure log, seems lack of enough info to find out root cause,
this change is to enhance a little to base test class AsyncCloseTest with
guessing, even it may not com
> On 13 Nov 2018, at 10:35 AM, Weijun Wang wrote:
>
> I'm scanning a file and downloading links inside:
>
> lines.flapMap(x -> Stream.ofNullable(findURIFrom(x)))
> .map(l -> download(c, l))
> .forEach(f -> f.join());
>
> CompletableFuture> download(HttpClient c, URI link) {
>retur
Hi, Vyom, Chris H.
> On 11 Oct 2018, at 7:08 PM, Chris Hegarty wrote:
>
>
>
>> On 11 Oct 2018, at 12:02, vyom tewari > <mailto:vyom.tew...@oracle.com>> wrote:
>> On Thursday 11 October 2018 02:15 PM, Chris Yin wrote:
>>> Please review be
t;
>> On 11 Oct 2018, at 09:45, Chris Yin > <mailto:xu.y@oracle.com>> wrote:
>>
>> Please review below small change to fix test
>> sun/net/ftp/FtpURLConnectionLeak.Java, thanks
>>
>> Besides the original timeout issue, looks like the test no
Please review below small change to fix test
sun/net/ftp/FtpURLConnectionLeak.Java, thanks
Besides the original timeout issue, looks like the test not working as expected
even the results is pass. Per test description, we expect FileNotFoundException
and then verify connection closed, but look
Thank you, Chris H.
Regards,
Chris Y.
> On 21 Sep 2018, at 3:59 PM, Chris Hegarty wrote:
>
>
>> On 21 Sep 2018, at 07:02, Chris Yin > <mailto:xu.y@oracle.com>> wrote:
>>
>> Please review below minor change for 8169246, thanks
>>
>&g
Please review below minor change for 8169246, thanks
The failure log indicate "BindException: Address already in use”, I didn’t see
any reason for this test to use a fixed port 4001 that may occupied by others,
so propose to just remove fixed port.
bug: https://bugs.openjdk.java.net/browse/JDK-
the same port is being reused, then printing out
> the client’s bound port would do that ( since the servers port is
> already printed in the logs ).
>
> If such a change was integrated, then the next observed failure
> would confirm or disconfirm your suspicion.
>
> -Chris
Loop net-dev since the test is under java/net, thanks
> On 20 Sep 2018, at 5:30 PM, Chris Yin wrote:
>
> Please review below minor change for 8199931, thanks
>
> A little explanation about the change here, since the failure samples are too
> less (seems too hard to repro),
13 matches
Mail list logo
