On Wed, 13 Apr 2022 22:20:14 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update LastModified
LGTM.
-
Marked as reviewed by chegar (Re
On Tue, 15 Feb 2022 15:33:01 GMT, Conor Cleary wrote:
>> As described in the title, this is a simple change to the
>> `HttpRequest.Builder::build` method to highlight that an immutable and
>> reusable instance of an `HttpRequest` is created when this method is
>> invoked. This is done by addin
On Wed, 3 Nov 2021 13:23:36 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
> On 25 Aug 2021, at 10:10, Daniel Fuchs wrote:
>
> I hereby nominate Patrick Concannon to Membership in the Networking
> Group.
Vote: Yes
-Chris
On Thu, 19 Aug 2021 14:02:28 GMT, Daniel Fuchs wrote:
> Please find here a patch that fixes intermittent failures in
> HandshakeFailureTest.java. The test expects an SSLException but finds an
> AssertionError instead. The AssertionError was too strong and was fired
> before the Http2Connection
On Tue, 17 Aug 2021 10:55:02 GMT, Julia Boes wrote:
>> This is a doc-only fix that improves the wording of the API doc of
>> `getRequestHeaders()`. The other changes are trivial cleanup.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit since the last revisi
On Thu, 12 Aug 2021 13:44:23 GMT, Julia Boes wrote:
> This is a doc-only fix that improves the wording of the API doc of
> `getRequestHeaders()`. The other changes are trivial cleanup.
Marked as reviewed by chegar (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5100
On Wed, 4 Aug 2021 10:54:10 GMT, Daniel Fuchs wrote:
>> This is a minor change that updates
>> `sun.net.httpserver.HttpConnection::toString` to never return null.
>>
>> Testing: tier 1-3 all clear
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/HttpConnection.java line
> 69:
>
>> 67:
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote:
> This is a minor change that updates
> `sun.net.httpserver.HttpConnection::toString` to never return null.
>
> Testing: tier 1-3 all clear
Marked as reviewed by chegar (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/492
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
Trivially, looks ok to me.
On Mon, 12 Jul 2021 20:39:53 GMT, Christoph Langer wrote:
> The change for JDK-8257001 left an obsolete int field. Remove it.
Marked as reviewed by chegar (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4759
On Tue, 6 Jul 2021 16:56:17 GMT, Brian Burkhalter wrote:
>> Please review this change to the Unix implementations of
>> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state ==
>> ChannelState.UNINITIALIZED`.
>
> Brian Burkhalter has updated the pull request incrementally with
On Tue, 6 Jul 2021 14:41:18 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my patch for Inserting missing commas in
> copyright headers from files in java.net. These commas were mistakenly left
> out of PR https://github.com/openjdk/jdk/pull/4574.
>
> Kind regards,
>
>
On Mon, 5 Jul 2021 11:21:39 GMT, Daniel Fuchs wrote:
> Please find here a trivial fix for:
>
> 8269772: [macos-aarch64] test compilation failed with "SocketException: No
> buffer space available"
>
> Running several of the websocket tests concurrently on some of the CI
> machines is causing r
On Tue, 29 Jun 2021 16:10:44 GMT, Brian Burkhalter wrote:
>> Please review this change to the Unix implementations of
>> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state ==
>> ChannelState.UNINITIALIZED`.
>
> Brian Burkhalter has updated the pull request incrementally wit
On Thu, 24 Jun 2021 11:44:19 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Wed, 23 Jun 2021 18:02:02 GMT, Julia Boes wrote:
>> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the
>> following format: First character uppercase, all other characters lowercase,
>> for example `"foo" -> "Foo"`. This behaviour is not consistent across the
>> mutator m
On Thu, 17 Jun 2021 21:31:48 GMT, Mark Sheppard wrote:
>> JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed
>> with "SocketException: Cannot allocate memory"
>>
>> The test java/net/MulticastSocket/Promiscuous.java has been observed to fail
>> on a regular basis on m
t;> ProblemList.txt.
>>
>> Please oblige and review the changes for a fix of the issue JDK-8265369
>
> Mark Sheppard has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8265369 [macos-aarch64] java/net/MulticastSoc
On Thu, 17 Jun 2021 09:17:24 GMT, Julia Boes wrote:
> This cleanup-only change fixes the indentation of all members from 8 to 4
> spaces and removes whitespace in method invocations (example: `foo ()` ->
> `foo()`). It also removes superfluous type parameters on lines 83, 168, 206.
Marked as r
On Wed, 16 Jun 2021 13:53:38 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find below a test-only change to fix some intermittent failures
> observed with the httpclient/websocket tests:
> these tests intermittently and randomly fail with ENOMEM ("No buffer space
> available").
>
> Some machines
On Mon, 14 Jun 2021 15:28:01 GMT, Mark Sheppard wrote:
> JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed
> with "SocketException: Cannot allocate memory"
>
> The test java/net/MulticastSocket/Promiscuous.java has been observed to fail
> on a regular basis on macosx
On Thu, 10 Jun 2021 17:39:58 GMT, Daniel Fuchs wrote:
> Another change brought by jtreg 6+1 in the behavior of @BeforeMethod.
> Now throwing an exception in @BeforeMethod causes all annotated methods to be
> skipped, not just those annotated with @Test.
>
> HttpClient tests that use @BeforeMeth
On Wed, 2 Jun 2021 17:52:34 GMT, Daniel Fuchs wrote:
>> Please find below a fix that will make
>> `java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to
>> the rare case where addresses bound to a network interfaces are updated
>> while the test is running.
>>
>> Instead
On Wed, 2 Jun 2021 11:06:46 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Tue, 1 Jun 2021 17:20:38 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull reques
On Tue, 1 Jun 2021 12:09:26 GMT, Daniel Fuchs wrote:
> Please find below a trivial change to improve diagnostic in case of failure
> in the HandshakeFailureTest.
> The AssertionError observed will have more information next time it fires,
> and the stack trace will appear as the cause of the ru
On Mon, 31 May 2021 16:21:29 GMT, Daniel Fuchs wrote:
> The Utils.remaining(List list) method assumes that it can and
> should synchronize on the given list to prevent concurrent modification. In
> 99% of the cases this assumption is wrong. There's only one such list (the
> SSLFlowDelegate wri
On Fri, 28 May 2021 13:11:43 GMT, Chris Hegarty wrote:
> The SCTP channel factory methods, namely SctpChannel::open,
> SctpServerChannel::open, and SctpMultiChannel::open, are specified to throw
> UnsupportedOperationException, if the SCTP protocol is not supported.
> Currently
On Fri, 28 May 2021 14:31:56 GMT, Alan Bateman wrote:
> EPROTONOSUPPORT and ESOCKTNOSUPPORT are subtly different and I don't know if
> ESOCKTNOSUPPORT is possible. Checking both errors is okay/harmless so I think
> this change is okay.
ESOCKTNOSUPPORT is the reported error for SOCK_SEQPACKET (
On Thu, 27 May 2021 13:20:26 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find below a fix for:
>> 8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with
>> "IOException: No buffer space available"
>>
>> The Pending* websocket tests create a server that accepts sockets to cre
The SCTP channel factory methods, namely SctpChannel::open,
SctpServerChannel::open, and SctpMultiChannel::open, are specified to throw
UnsupportedOperationException, if the SCTP protocol is not supported.
Currently, underlying platform support is assumed once the appropriate
libsctp.so.1 libra
On Thu, 27 May 2021 00:41:25 GMT, Jie Fu wrote:
>>> if sctp is configured on a linux system would there exist a /proc/net/sctp
>>> and have an entry in /proc/net/protocols ?
>>
>> No /proc/net/sctp and no entry in /proc/net/protocols.
>> But I don't think it's the reason since it passed on anot
On Wed, 26 May 2021 03:54:14 GMT, Jie Fu wrote:
> Hi all,
>
> java/net/SctpSanity.java fails on some of our test machines due to Protocol
> not supported.
> The reason is that the test fails to detect all the cases when a machine
> doesn't support SCTP.
>
> The fix just follows what are done
On Wed, 26 May 2021 14:32:22 GMT, Jie Fu wrote:
> > This is probably ok, but a little surprising. Can you say a more about the
> > machine setup?
>
> What do you mean by `setup`?
> And how can I get these setups?
> Thanks.
Let me rephrase.
You said: "The reason is that the test fails to detec
On Wed, 26 May 2021 03:54:14 GMT, Jie Fu wrote:
> Hi all,
>
> java/net/SctpSanity.java fails on some of our test machines due to Protocol
> not supported.
> The reason is that the test fails to detect all the cases when a machine
> doesn't support SCTP.
>
> The fix just follows what are done
The vote for Daniel Fuchs [1] is now closed.
Yes: 3
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is
sufficient to approve the nomination.
-Chris.
[1] https://mail.openjdk.java.net/pipermail/net-dev/2021-May/015847.html
On Tue, 18 May 2021 09:49:26 GMT, Daniel Fuchs wrote:
>> The filter operation `Consumer` that is passed to the factory methods can
>> throw an unchecked exception. This change adds a note on the exception
>> handling in that case. It also adds a clarification to
>> `Filter::afterHandler` on th
On Tue, 18 May 2021 09:34:25 GMT, Julia Boes wrote:
> The filter operation `Consumer` that is passed to the factory methods can
> throw an unchecked exception. This change adds a note on the exception
> handling in that case. It also adds a clarification to `Filter::afterHandler`
> on the rela
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Mon, 17 May 2021 09:53:06 GMT, Julia Boes wrote:
> The tests for `afterHandler` filters expect the filter operation to happen
> before the assertion. Very rarely this is not the case, the calling thread
> reads the response before the filter operation is executed, so the test value
> is not
Vote: YES
-Chris.
> On 12 May 2021, at 11:58, Chris Hegarty wrote:
>
> I hereby nominate Daniel Fuchs to Membership in the Networking
> Group.
I hereby nominate Daniel Fuchs to Membership in the Networking
Group.
Daniel is a Reviewer in the JDK project, and a long term contributor to
the Java platform. Daniel has been actively participating in the
evolution and maintenance of the networking libraries for several years.
Daniel was a signi
On Mon, 10 May 2021 19:31:32 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a fix to prevent an assertion error from firing in the
>> com.sun.net.httpserver.
>>
>> The issue occurs systematically when all of these conditions are met:
>>
>> 1. System assertions are enabled
>> 2. The ha
On Fri, 30 Apr 2021 10:46:33 GMT, Daniel Fuchs wrote:
> Hi,
>
> I stumbled on an issue in Stream.java where an assert was misplaced,
> preventing the proper IOException to be triggered. I believe this is what
> caused the FlowAdapterPublisherTest.java to fail with the "Invalid Preface"
> err
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote:
>> 8266155: Convert java.base to use Stream.toList()
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing redundant imports
Marked as reviewed by chegar (Reviewer).
--
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Marked as reviewed by chegar (Reviewer).
src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 6788:
> 6786: }
> 6787:
> 6788: /**
I think the import of Collectors c
On Wed, 28 Apr 2021 11:26:18 GMT, Julia Boes wrote:
>> Add two static factory methods to com.sun.net.httpserver.Filter that
>> facilitate the creation of pre- and post-processing Filters:
>>
>> `public static Filter beforeResponse(String description,
>> Consumer filterImpl) {}`
>> `public sta
On Tue, 13 Apr 2021 15:39:17 GMT, Julia Boes wrote:
> Add two static factory methods to com.sun.net.httpserver that facilitate the
> creation of pre- and post-processing Filters:
>
> `public static Filter beforeResponse(String description,
> Consumer filterImpl) {}`
> `public static Filter af
On Tue, 23 Mar 2021 13:45:06 GMT, Michael McMahon wrote:
>> Could I get the following simple fix reviewed please?
>>
>> The bug is jdk.internal.net.http.AuthenticationFilter throws an NPE wrapped
>> in an IOException if it receives a HTTP response containing a
>> WWW-Authenticate header with
On Mon, 22 Mar 2021 09:26:08 GMT, Michael McMahon wrote:
> Could I get the following simple fix reviewed please?
>
> Thanks,
> Michael.
test/jdk/java/net/httpclient/EmptyAuthenticate.java line 44:
> 42:
> 43: public static void main(String[] args) throws IOException,
> URISyntaxException
On Tue, 16 Feb 2021 13:37:20 GMT, Jamie Le Tual
wrote:
>> I think that the changes are mostly good. I would like to try them out on my
>> local system and our internal buildAndTest system.
>
>> I think that the changes are mostly good. I would like to try them out on my
>> local system and our
On Thu, 18 Mar 2021 14:57:16 GMT, Chris Hegarty wrote:
> As per the Java Native Interface Specification: "All Java objects returned by
> JNI functions are local references." [1].
>
> The get/set-InetXXAddress-member helper functions in net_util.c retrieve a
> local
On Tue, 16 Mar 2021 15:41:21 GMT, Andrew Haley wrote:
>> Thanks for making these changes. This is much easier to review now. I'm not
>> an expert with JNI ref - but the logic now looks right.
>
> Please hold off on this; there's an issue to clear up.
@theRealAph Please let me know when this PR
As per the Java Native Interface Specification: "All Java objects returned by
JNI functions are local references." [1].
The get/set-InetXXAddress-member helper functions in net_util.c retrieve a
local reference to the internal `holder` before operating on the InetAddress
object. These function
On Fri, 19 Feb 2021 14:53:36 GMT, Conor Cleary wrote:
>> src/java.base/unix/native/libnet/Inet4AddressImpl.c line 375:
>>
>>> 373: icmp->icmp_type = ICMP_ECHO;
>>> 374: icmp->icmp_code = 0;
>>> 375: // same result as downcasting the little-endian pid, although
>>> we are
addr add 192.168.2.${num}/24 dev
>> veth${namespace}${num}
>> sudo ip link set vethhost${num} up
>> sudo ip netns exec ${namespace} ip link set veth${namespace}${num} up
>>
>> count="$(sudo ip netns exec ${namespace} ip link show |grep UP | wc -l)&qu
On Sun, 14 Mar 2021 12:29:45 GMT, Alan Bateman wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default JNI
On Mon, 15 Mar 2021 16:59:24 GMT, Jonathan Dowland wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default
On Mon, 15 Mar 2021 12:53:16 GMT, Jonathan Dowland wrote:
>> This is an adaptation of a patch originally written by Shafi Ahmad in
>> a comment on the JBS page but never submitted or merged.
>>
>> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very
>> quickly breaches the default
On Tue, 9 Mar 2021 20:52:19 GMT, Mark Sheppard wrote:
>> The disadvantage is that it would add another level of braces.
>
> maybe ... I find it would provide an easier flow to code ... an "easy on the
> eye" call flow linkage - the variable is declared and then used instead
> of the disc
On Tue, 9 Mar 2021 19:56:25 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
On Tue, 9 Mar 2021 17:59:27 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the `instanceof` pattern variable?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the
On Tue, 9 Mar 2021 11:07:07 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.net`
> and `java.nio` packages to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/net/Interfa
On Tue, 2 Mar 2021 10:15:13 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset that fixes the "no comment" warnings
> generated by `javadoc -Xdoclint` for `java.base/jdk.net`?
>
> Kind regards,
> Patrick
Marked as reviewed by chegar (Reviewer).
-
P
On Fri, 26 Feb 2021 10:59:01 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes "no comment" warnings generated by
>> `javadoc -Xdoclint` for `java.base/java.net`
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last re
On Thu, 25 Feb 2021 15:38:02 GMT, Conor Cleary wrote:
>> A number of net tests use a
>> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
>> to verify either the functionality of th
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote:
> Please review some simple doc fixes in the `java.base` module. Two were
> reported by doclint; the spelling error was detected by the IDE.
Marked as reviewed by chegar (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/p
On Wed, 24 Feb 2021 13:58:38 GMT, Chris Hegarty wrote:
> Trivial clean up of remaining doclint warnings in jdk.httpserver.
>
> The minor spec clarifications do not amount to a normative change, so no CSR
> is required (they're documented the obvious and only possible behav
> Trivial clean up of remaining doclint warnings in jdk.httpserver.
>
> The minor spec clarifications do not amount to a normative change, so no CSR
> is required (they're documented the obvious and only possible behaviour).
Chris Hegarty has updated the pull request incre
On Wed, 24 Feb 2021 15:54:29 GMT, Michael McMahon wrote:
>> A number of net tests use a
>> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)**
>> to verify either the functionality of
Trivial clean up of remaining doclint warnings in jdk.httpserver.
The minor spec clarifications do not amount to a normative change, so no CSR is
required (they're documented the obvious and only possible behaviour).
-
Commit messages:
- Initial changes
Changes: https://git.openj
On Tue, 23 Feb 2021 17:20:13 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a fix for:
>> 8262027: Improve how HttpConnection detects a closed channel when
>> taking/returning a connection to the pool
>>
>> While writing a new test to verify that it was possible to handle proxy
>> *an
On Mon, 22 Feb 2021 16:44:15 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a fix for:
>> 8262027: Improve how HttpConnection detects a closed channel when
>> taking/returning a connection to the pool
>>
>> While writing a new test to verify that it was possible to handle proxy
>> *an
On Wed, 17 Feb 2021 16:38:03 GMT, Сергей Цыпанов
wrote:
>> Non-static classes hold a link to their parent classes, which in many cases
>> can be avoided.
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8261880: Remove s
On Wed, 17 Feb 2021 10:30:45 GMT, Chris Hegarty wrote:
>> In another bug this question from me was answered by Alan Bateman :
>>
>> Btw. while adjusting Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 , I
>> started to wonder what happens to the allocated me
On Tue, 16 Feb 2021 12:26:54 GMT, Matthias Baesken wrote:
> In another bug this question from me was answered by Alan Bateman :
>
> Btw. while adjusting Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 , I
> started to wonder what happens to the allocated memory in the same file in
> handleSen
On Fri, 29 Jan 2021 10:59:20 GMT, Evan Whelan wrote:
>> src/java.base/share/classes/java/net/URLConnection.java line 596:
>>
>>> 594: * corresponding values, they must be returned in the order they
>>> were added,
>>> 595: * preserving the insertion-order.
>>> 596: *
>>
>> Here
On Fri, 29 Jan 2021 11:03:07 GMT, Evan Whelan wrote:
>> Hi all,
>>
>> Please review this fix for which corrects the order in which field values
>> are returned from the `HttpURLConnection.getHeaderFields` and
>> `URLConnection.getRequestProperties` methods.
>>
>> Currently, the implementation
On Fri, 5 Feb 2021 11:25:57 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my proposed changeset for JDK-8235139: '`Remove
>> the socket impl factory mechanism`' ?
>>
>> These changes propose to deprecate (for the eventual removal) the API points
>> for statically con
On Tue, 2 Feb 2021 15:55:40 GMT, Julia Boes wrote:
> This change clarifies the InetSocketAddress::toString specification, which
> was recently updated to reflect an implementation change [1]. The
> specification is not changed, but it is enhanced with two examples and some
> more verbiage, as
On Thu, 21 Jan 2021 09:48:50 GMT, Chris Hegarty wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> As a part of the rename from "canonize" to "canonicalize", doCano
On Wed, 20 Jan 2021 15:46:13 GMT, Eirik Bjørsnøs
wrote:
>> By moving string splitting and concatenation into the canonizeString
>> utility, we can defer allocation until we determine that canonization is
>> required. This saves two string allocations and a string concat for the
>> common case
On Wed, 23 Dec 2020 14:06:12 GMT, Jamie Le Tual
wrote:
>> Users have been able to send ICMP packets without the need for root
>> privileges or the CAP_NET_RAW capability since at least kernel 3.11.
>>
>> For some time now, if the kernel parameter net.ipv4.ping_group_range
>> included the gid
On Sun, 17 Jan 2021 02:02:54 GMT, Jaikiran Pai wrote:
>> As noted by the reporter in the comments of
>> https://bugs.openjdk.java.net/browse/JDK-7146776, the `URLStreamHandler` in
>> its `getHostAddress` is incorrectly synchronizing on the `URLStreamHandler`
>> instance, instead of synchronizi
On Thu, 14 Jan 2021 02:25:25 GMT, Yasumasa Suenaga wrote:
>> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when
>> the stream reaches EOF. However IOE handler returns without closing.
>>
>> I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think
>> `Bo
On Thu, 14 Jan 2021 12:48:18 GMT, Сергей Цыпанов
wrote:
>> Instead of allocating a copy of underlying array via
>> `CharArrayWriter.toCharArray()` and passing it to constructor of String
>> String str = new String(charArrayWriter.toCharArray());
>> we could call `toString()` method
>> String st
On Tue, 12 Jan 2021 16:05:01 GMT, Aleksei Efimov wrote:
> Hi,
>
> The proposed change adds back [1] `instanceof` pattern match use to
> `HttpClientImpl` class. It was previously removed by
> [JDK-8258696](https://bugs.openjdk.java.net/browse/JDK-8258696) due to docs
> build failure.
>
> Alek
On Fri, 8 Jan 2021 13:20:38 GMT, Aleksei Efimov wrote:
>> This issue is blocked by [8258657][1]. It should not be integrated until
>> after 8258657 has been resolved. The JIRA issues have been linked up to
>> reflect this.
>>
>> [1]: https://bugs.openjdk.java.net/browse/JDK-8258657
>
> [JDK-82
ect(String,int).
-Chris.
[1] https://bugs.openjdk.java.net/browse/JDK-8170568
[2] https://mail.openjdk.java.net/pipermail/net-dev/2019-April/012371.html
[3] https://tools.ietf.org/html/rfc6555
> On 17 Dec 2020, at 14:39, Chris Hegarty wrote:
>
> Looping in a prior relevant issue i
On Thu, 17 Dec 2020 13:16:31 GMT, Aleksei Efimov wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>> take advantage of "flow
On Fri, 18 Dec 2020 16:54:59 GMT, Chris Hegarty wrote:
> Temporarily revert use of pattern match instanceof construct until
> docs-reference is fixed, see JDK-8258657.
>
> ...
> Generating REFERENCE_API javadoc for 21 modules
>
> if (delegate instanceof Ex
Temporarily revert use of pattern match instanceof construct until
docs-reference is fixed, see JDK-8258657.
...
Generating REFERENCE_API javadoc for 21 modules
if (delegate instanceof ExecutorService service) {
^
(use --enab
On Thu, 17 Dec 2020 14:51:44 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find an almost trivial fix for:
> 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default
> executor when stopping.
>
> The HttpClient should shutdown his executor when stopping, when the executor
> was
Looping in a prior relevant issue in JIRA:
https://bugs.openjdk.java.net/browse/JDK-8170568 -
Improve address selection for network clients
-Chris.
> On 17 Dec 2020, at 13:45, Daniel Fuchs wrote:
>
> Hi Simone,
>
> We are investigating introducing a Service Provider interface
> which would
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup unnecess
On Wed, 16 Dec 2020 09:20:09 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup unnecess
On Sat, 31 Oct 2020 19:37:10 GMT, Stuart Marks wrote:
>> I believe this changes is useful and still actual:
>> 1. improve code to make it easier to read.
>> 2. performance should be improved a bit too
>
> I’ll see if I can get somebody to take a look at this.
This seems like a reasonable change,
On Sat, 5 Dec 2020 04:54:27 GMT, Yasumasa Suenaga wrote:
>> `InputStream` from `BodyPublishers.ofInputStream()` is usually closed when
>> the stream reaches EOF. However IOE handler returns without closing.
>>
>> I confirmed this problem in `BodyPublishers.ofInputStream()`, but I think
>> `Bod
1 - 100 of 2074 matches
Mail list logo
