Hi Aleksei, Daniel,
Great news, thanks a lot for all your help on cleaning up this patch!
Cheers,
- Anuraag
On Wed, Jan 15, 2020, 01:14 Aleks Efimov wrote:
> Thanks Daniel!
>
> Anuuraag,
> I will update the copyrights, no need to send new patch. Then will
> sponsor your change - commit and pu
-if (loadConfig(searchlist, nameservers) != STS_ERROR) {
+ if (loadConfig(env, searchlist, nameservers) != STS_ERROR) {
/*
* Populate static fields in sun.net.DefaultResolverConfiguration
@@ -272,8 +209,6 @@
Java_sun_net_dns_ResolverConfigurationImpl_loadDNSconfig0(JNIEnv *
Hi Daniel,
Thanks for the review!
On Thu, Jan 9, 2020 at 9:04 PM Daniel Fuchs wrote:
> Hi,
>
> Two small remarks:
>
> ResolverConfigurationImpl.java:
>
>71 if (!l.contains(s)) {
>
> Maybe empty strings should be skipped here too.
>
Makes sense, added the check.
>
> I believe
s) != STS_ERROR) {
+if (loadConfig(env, searchlist, nameservers) != STS_ERROR) {
/*
* Populate static fields in sun.net.DefaultResolverConfiguration
@@ -272,8 +209,6 @@
Java_sun_net_dns_ResolverConfigurationImpl_loadDNSconfig0(JNIEnv *env,
jclass cl
obj = (*env)-&g
ameservers) != STS_ERROR) {
+if (loadConfig(env, searchlist, nameservers) != STS_ERROR) {
/*
* Populate static fields in sun.net.DefaultResolverConfiguration
@@ -272,8 +226,6 @@
Java_sun_net_dns_ResolverConfigurationImpl_loadDNSconfig0(JNIEnv *env,
jclass cl
obj = (*en
r your change.
> >
> > Merry Christmas and a Happy New Year,
> > Aleksei
> >
> > On 18/12/2019 06:08, Anuraag Agrawal wrote:
> >> ...
> >> http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/03/
> >>
>
> I think that this mainly look
filter out
> site-local addresses.
>
> Testing:
> Run your latest patch though our CI system - no issues detected.
>
> -Aleksei
>
> On 10/12/2019 06:59, Anuraag Agrawal wrote:
>
> Hi Aleksei,
>
> Thanks for running the test. I had checked the global search list,
Gateway . . . . . . . . . : <---->
>DHCP Server . . . . . . . . . . . : <>
>DHCPv6 Client DUID. . . . . . . . : <>
>DNS Servers . . . . . . . . . . . : <>
><
Hi all,
Thanks for the reviews. I've fixed the formatting errors, and I hope I
fixed the copyright issue. I couldn't find documentation on the format of
the copyright header, but assume the second number is the year of
modification to update. I found ResolverConfigurationImpl.c to have an old
one
g(searchlist, nameservers) != STS_ERROR) {
+if (loadConfig(env, searchlist, nameservers) != STS_ERROR) {
/*
* Populate static fields in sun.net.DefaultResolverConfiguration
On Sun, Nov 24, 2019 at 11:21 PM Bernd Eckenfels
wrote:
> Hello Anuraag,
>
> The patch
Hello,
While investigating DNS resolution failure using Netty (
https://github.com/netty/netty/issues/9796), I came across an old JDK bug
where on Windows, the list of OS name servers includes those for disabled
interfaces (https://bugs.openjdk.java.net/browse/JDK-7006496). This is
problematic sin
11 matches
Mail list logo
