Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v4]

2021-03-22 Thread Andrew Haley
On Tue, 16 Mar 2021 14:12:46 GMT, Jonathan Dowland wrote: >> This is an adaptation of a patch originally written by Shafi Ahmad in >> a comment on the JBS page but never submitted or merged. >> >> With -Xcheck:jni, the method java.net.NetworkInterface.getAll very >> quickly breaches the default

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v4]

2021-03-22 Thread Andrew Haley
On Tue, 16 Mar 2021 15:41:21 GMT, Andrew Haley wrote: > Please hold off on this; there's an issue to clear up. Done. - PR: https://git.openjdk.java.net/jdk/pull/2963

Re: RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v4]

2021-03-16 Thread Andrew Haley
On Tue, 16 Mar 2021 15:01:02 GMT, Daniel Fuchs wrote: >> Jonathan Dowland has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Correct test invocation metadata >> >>-Xcheck:jni prior to the main class declaration; /othervm suffix no

Re: [8u] RFR(m): 8194298: Add support for per Socket configuration of TCP keepalive

2020-06-29 Thread Andrew Haley
On 29/06/2020 17:06, Severin Gehwolf wrote: > It's a possibility. IMHO, it doesn't really make the code easier to > read, though. Some duplication for clarity seems OK to me in this case. > I'm not too fond of over-use of ifdef so I'd rather keep it at v5. > YMMV.

Re: [8u] RFR(XS): 8244461: [JDK 8u] Build fails with glibc 2.32

2020-05-08 Thread Andrew Haley
; > Thoughts? OK. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew Haley
Andrew John Hughes wrote: > 2009/9/23 Andrew Haley : >> Christopher Hegarty -Sun Microsystems Ireland wrote: >>> [cc'ing net-dev] >>> >>> I see you have push access, so if you make the appropriate changes >>> (mentioned above) I can review the w

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew Haley
Christopher Hegarty -Sun Microsystems Ireland wrote: > [cc'ing net-dev] > > Alan Bateman wrote: >> Pavel Tisnovsky wrote: >>> Hi, >>> >>> two-lines patch for regression test >>> java/net/MulticastSocket/SetOutgoingIf.java is exposed at >>> http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinIf/ >