Integrated: 8281289: Improve with List.copyOf

2022-02-04 Thread Xue-Lei Andrew Fan
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote: > Please review this trivial code clean up, for a little bit better performance. This pull request has now been integrated. Changeset: 42e272e1 Author:Xue-Lei Andrew Fan URL: https://git.openjdk.java.net/jdk/commit/42e272e18

Re: RFR: 8281289: Improve with List.copyOf

2022-02-04 Thread Hai-May Chao
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote: > Please review this trivial code clean up, for a little bit better performance. Marked as reviewed by hchao (Committer). Looks good to me. - PR: https://git.openjdk.java.net/jdk/pull/7356

Re: RFR: 8281289: Improve with List.copyOf

2022-02-04 Thread Jamil Nimeh
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote: > Please review this trivial code clean up, for a little bit better performance. Looks good to me. - Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7356

RFR: 8281289: Improve with List.copyOf

2022-02-04 Thread Xue-Lei Andrew Fan
Please review this trivial code clean up, for a little bit better performance. - Commit messages: - 8281289: Improve with List.copyOf Changes: https://git.openjdk.java.net/jdk/pull/7356/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7356&range=00 Issue: https://bugs.

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-04 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-04 Thread Xue-Lei Andrew Fan
On Fri, 4 Feb 2022 16:35:22 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More update for the sec and impl > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 713: > >> 7

Re: RFR: 8280494: (D)TLS signature schemes [v12]

2022-02-04 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes [v11]

2022-02-04 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-04 Thread Xue-Lei Andrew Fan
On Fri, 4 Feb 2022 16:34:14 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More update for the sec and impl > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 735: > >> 7

Re: RFR: 8280494: (D)TLS signature schemes [v10]

2022-02-04 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-04 Thread Sean Mullan
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable

2022-02-04 Thread Michael McMahon
On Fri, 4 Feb 2022 14:11:49 GMT, Daniel Fuchs wrote: >> Hi, >> >> Could I get the following patch reviewed please? (A CSR is also required >> which I will submit when the docs are agreed) >> >> It adds a pair of new system properties to make the keep alive timer in >> java.net.HttpURLConnecti

Re: RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable

2022-02-04 Thread Daniel Fuchs
On Fri, 4 Feb 2022 13:11:02 GMT, Michael McMahon wrote: > Hi, > > Could I get the following patch reviewed please? (A CSR is also required > which I will submit when the docs are agreed) > > It adds a pair of new system properties to make the keep alive timer in > java.net.HttpURLConnection c

RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable

2022-02-04 Thread Michael McMahon
Hi, Could I get the following patch reviewed please? (A CSR is also required which I will submit when the docs are agreed) It adds a pair of new system properties to make the keep alive timer in java.net.HttpURLConnection configurable. The proposed property names are: "http.keepAlive.time.serv

Re: RFR: 8280965: Tests com/sun/net/httpserver/simpleserver fail with FileSystemException on Windows 11 [v2]

2022-02-04 Thread Daniel Fuchs
On Fri, 4 Feb 2022 09:44:53 GMT, Julia Boes wrote: >> This change updates the tests in question to handle the case where sym link >> creation is not supported, as observed on Windows 11 where additional >> privileges are required to create sym links. >> >> Testing: tier 1-3 across platforms, p

Re: RFR: 8280965: Tests com/sun/net/httpserver/simpleserver fail with FileSystemException on Windows 11 [v2]

2022-02-04 Thread Julia Boes
> This change updates the tests in question to handle the case where sym link > creation is not supported, as observed on Windows 11 where additional > privileges are required to create sym links. > > Testing: tier 1-3 across platforms, plus tests in question on Windows 11 > specifically Julia