Re: RFR: 8280494: (D)TLS signature schemes [v5]

2022-01-29 Thread Xue-Lei Andrew Fan
On Sun, 30 Jan 2022 03:06:35 GMT, Bernd wrote: >> Yes. Array copy is a concern of mine, too. Hopefully, the frozen array >> feature could help address the array copy issues in the future. > > Hmm.. I guess the different packages make it really hard to have an internal > optimized getter. What

Re: RFR: 8280494: (D)TLS signature schemes [v5]

2022-01-29 Thread Xue-Lei Andrew Fan
On Sun, 30 Jan 2022 03:03:37 GMT, Bernd wrote: >> If we want to reuse the result, we may have to cache something. It is not >> good to me. The parsing of the signature scheme names actually depends on >> the provider. So at this point, in the Java SE API specification, it is not >> easy to

Re: RFR: 8280494: (D)TLS signature schemes [v5]

2022-01-29 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes [v4]

2022-01-29 Thread Bernd
On Sat, 29 Jan 2022 05:31:08 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 763: >> >>> 761: >>> 762: String[] tempSchemes = signatureSchemes.clone(); >>> 763: for (String scheme : tempSchemes) { >> >> In addition to this loo

Re: RFR: 8280494: (D)TLS signature schemes [v4]

2022-01-29 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Integrated: 8277412: Use String.isBlank to simplify code in sun.net.www.protocol.mailto.Handler

2022-01-29 Thread Andrey Turbanov
On Fri, 12 Nov 2021 19:11:36 GMT, Andrey Turbanov wrote: > All this manually written code actually can be replaced with single > String.isBlank() call. > `file` variable is guaranteed to be non-null. This pull request has now been integrated. Changeset: 268880b4 Author:Andrey Turbanov URL