On Fri, 21 Jan 2022 16:02:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
> Fix RFC compliance.
> Tier1 and tier2 passed.
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7181/files
- new: https://git.openjdk.j
On Fri, 21 Jan 2022 16:02:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
On Fri, 21 Jan 2022 16:51:20 GMT, Daniel Jeliński wrote:
> Fix RFC compliance.
> Tier1 and tier2 passed.
Could you update the copyright years and add `8163921` to the `@bug` tag in the
test?
-
PR: https://git.openjdk.java.net/jdk/pull/7181
On Fri, 21 Jan 2022 16:02:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
Fix RFC compliance.
Tier1 and tier2 passed.
-
Commit messages:
- Fix default Accept header
Changes: https://git.openjdk.java.net/jdk/pull/7181/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7181&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8163921
Stats
On Fri, 21 Jan 2022 15:51:10 GMT, Michael McMahon wrote:
>> `NamingException` has `setRootCause()`. Why not use that? I use that one too
>> and full stack is retained.
>
> Yes, I can do that. Though it will cause the existing LDAP channel binding
> test to fail which is checking for an empty ro
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The feature
On Fri, 21 Jan 2022 13:39:06 GMT, Michael Osipov wrote:
>> Actually, it turns out I should be throwing `NamingException` here. That is
>> what was being thrown by `TlsChannelBinding.parseType` before and an
>> existing test was expecting that. NamingException only takes a String
>> message. So
On Fri, 21 Jan 2022 15:26:33 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
On Fri, 21 Jan 2022 15:08:58 GMT, Michael McMahon wrote:
>> It was being handled elsewhere as "never". But, I agree it would be clearer
>> to normalise it to "never" here.
>
> Sorry, I should have checked back to the source rather than the snippet
> quoted. The problem is that the logError call
On Fri, 21 Jan 2022 15:26:33 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
On Fri, 21 Jan 2022 14:38:08 GMT, Julia Boes wrote:
> This change adds the classpath exception to the copyright header of the files
> in question. As source files, they should have both the GPL and the classpath
> exception.
Marked as reviewed by dfuchs (Reviewer).
-
PR: https://
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The feature
On Fri, 21 Jan 2022 13:38:08 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 189:
>>
>>> 187: } else {
>>> 188: logError("Unexpected value for \"jdk.https.negotiate.cbt\"
>>> system property");
>>> 189: return s;
>
On Fri, 21 Jan 2022 14:38:08 GMT, Julia Boes wrote:
> This change adds the classpath exception to the copyright header of the files
> in question. As source files, they should have both the GPL and the classpath
> exception.
P1–P5 doc bugs are okay to integrate in JDK 18 RDP2, I think fixes co
On Fri, 21 Jan 2022 14:38:08 GMT, Julia Boes wrote:
> This change adds the classpath exception to the copyright header of the files
> in question. As source files, they should have both the GPL and the classpath
> exception.
Should you make this PR against jdk-18 repo instead?
-
This change adds the classpath exception to the copyright header of the files
in question. As source files, they should have both the GPL and the classpath
exception.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.java.net/jdk18/pull/111/files
Webrev: https://we
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote:
> We were leaking the list returned by `createProxyList`. Verified that the
> leak is no longer present with this patch. Also removed a few unused
> variables.
>
> Reported by clang-tidy.
Thanks for reviewing!
-
PR: https:
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote:
> We were leaking the list returned by `createProxyList`. Verified that the
> leak is no longer present with this patch. Also removed a few unused
> variables.
>
> Reported by clang-tidy.
Marked as reviewed by dfuchs (Reviewer).
--
On Fri, 21 Jan 2022 13:35:53 GMT, Michael McMahon wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 133:
>>
>>> 131:
>>> (String)env.get(TlsChannelBinding.CHANNEL_BINDING_TYPE));
>>> 132: } catch (ChannelBindingExce
On Thu, 20 Jan 2022 11:16:16 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.base/share/classes/sun/security/util/Chann
On Thu, 20 Jan 2022 11:14:40 GMT, Michael Osipov wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.naming/share/classes/com/sun/jndi/ldap/s
On Thu, 20 Jan 2022 11:04:18 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.base/share/classes/java/net/doc-files/net-
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote:
> We were leaking the list returned by `createProxyList`. Verified that the
> leak is no longer present with this patch. Also removed a few unused
> variables.
>
> Reported by clang-tidy.
tier1 and tier2 also passed.
-
PR:
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote:
> We were leaking the list returned by `createProxyList`. Verified that the
> leak is no longer present with this patch. Also removed a few unused
> variables.
>
> Reported by clang-tidy.
Tested locally. Returned values look correct, an
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote:
> We were leaking the list returned by `createProxyList`. Verified that the
> leak is no longer present with this patch. Also removed a few unused
> variables.
>
> Reported by clang-tidy.
Look reasonable to me. Did you run tier1 - tier2
On Mon, 18 Oct 2021 07:55:52 GMT, Andrey Turbanov wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
This pull request has now been integrated.
Changeset: 47b1c51b
Author:Andrey Turbanov
URL:
https:/
We were leaking the list returned by `createProxyList`. Verified that the leak
is no longer present with this patch. Also removed a few unused variables.
Reported by clang-tidy.
-
Commit messages:
- Fix memory leak
Changes: https://git.openjdk.java.net/jdk/pull/7172/files
Webrev:
29 matches
Mail list logo
