Re: RFR: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST [v4]

2021-10-19 Thread Daniel Fuchs
On Tue, 19 Oct 2021 13:48:24 GMT, Evan Whelan wrote: >> Hi, >> >> Please review my fix for JDK-8274779 which changes how HttpClient and >> HttpsClient checks for equality when comparing request methods. >> >> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")` >> rather

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v4]

2021-10-19 Thread Daniel Fuchs
On Tue, 19 Oct 2021 13:28:26 GMT, Aleksei Efimov wrote: >> This change implements a new service provider interface for host name and >> address resolution, so that java.net.InetAddress API can make use of >> resolvers other than the platform's built-in resolver. >> >> The following API classes

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v3]

2021-10-19 Thread Aleksei Efimov
On Sun, 17 Oct 2021 21:39:06 GMT, Mark Sheppard wrote: > I think that a hostname is constant while a host is up, but it can be > changed, and when changed a host restart is required. I don't think it is > quite as dynamic as has been suggested, but I open to correction. It is possible to chang

Re: RFR: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST [v4]

2021-10-19 Thread Evan Whelan
> Hi, > > Please review my fix for JDK-8274779 which changes how HttpClient and > HttpsClient checks for equality when comparing request methods. > > When `HttpURLConnection.setRequestMethod` is passed `new String("POST")` > rather than the "POST" String literal, the old behaviour resulted in

Re: RFR: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST [v3]

2021-10-19 Thread Evan Whelan
On Fri, 15 Oct 2021 15:25:33 GMT, Daniel Fuchs wrote: >> Evan Whelan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Extracted both connectTimeouts to variables and added copyright header to >> accessor >> - Removed reflection in fav

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v3]

2021-10-19 Thread Aleksei Efimov
On Fri, 15 Oct 2021 17:19:26 GMT, Daniel Fuchs wrote: >> Aleksei Efimov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add @since tags to new API classes >> - Add checks and test for empty stream resolver results > > test/lib/jdk/tes

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v3]

2021-10-19 Thread Aleksei Efimov
On Fri, 15 Oct 2021 17:09:46 GMT, Daniel Fuchs wrote: >> Aleksei Efimov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add @since tags to new API classes >> - Add checks and test for empty stream resolver results > > test/jdk/java/ne

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v3]

2021-10-19 Thread Aleksei Efimov
On Fri, 15 Oct 2021 14:25:02 GMT, Daniel Fuchs wrote: >> Aleksei Efimov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add @since tags to new API classes >> - Add checks and test for empty stream resolver results > > src/java.base/sh

Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v4]

2021-10-19 Thread Aleksei Efimov
> This change implements a new service provider interface for host name and > address resolution, so that java.net.InetAddress API can make use of > resolvers other than the platform's built-in resolver. > > The following API classes are added to `java.net.spi` package to facilitate > this: > -

Re: RFR: 8275319 java.net.NetworkInterface throws java.lang.Error instead of SocketException [v4]

2021-10-19 Thread Daniel Fuchs
On Tue, 19 Oct 2021 09:32:19 GMT, Daniel Jeliński wrote: >> Per Java documentation, >> "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30) >> [..] indicates serious problems that a reasonable application should not >> try to catch". Failure

Re: RFR: 8275319 java.net.NetworkInterface throws java.lang.Error instead of SocketException [v3]

2021-10-19 Thread Alan Bateman
On Tue, 19 Oct 2021 07:53:47 GMT, Daniel Jeliński wrote: >> src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 123: >> >>> 121: // not an error >>> 122: *adapters = NULL; >>> 123: return ERROR_SUCCESS; >> >> Mapping ERROR_NO_DATA to

Integrated: 8245095: Implementation of JEP 408: Simple Web Server

2021-10-19 Thread Julia Boes
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is

Re: RFR: 8275319 java.net.NetworkInterface throws java.lang.Error instead of SocketException [v4]

2021-10-19 Thread Daniel Jeliński
> Per Java documentation, > "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30) > [..] indicates serious problems that a reasonable application should not try > to catch". Failure to enumerate network interfaces or addresses is not a > serio

Re: RFR: 8275319 java.net.NetworkInterface throws java.lang.Error instead of SocketException [v3]

2021-10-19 Thread Daniel Jeliński
On Tue, 19 Oct 2021 06:42:43 GMT, Alan Bateman wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix crash on GetIpAddrTable error > > src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 123: > >> 1

Re: RFR: 8275319 java.net.NetworkInterface throws java.lang.Error instead of SocketException [v3]

2021-10-19 Thread Daniel Jeliński
On Tue, 19 Oct 2021 06:45:58 GMT, Alan Bateman wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix crash on GetIpAddrTable error > > src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 232: > >> 2