Re: [jdk17] RFR: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"

2021-07-06 Thread Vyom Tewari
On Mon, 5 Jul 2021 11:21:39 GMT, Daniel Fuchs wrote: > Please find here a trivial fix for: > > 8269772: [macos-aarch64] test compilation failed with "SocketException: No > buffer space available" > > Running several of the websocket tests concurrently on some of the CI > machines is causing r

RE: test/jdk/java/net/SocketPermission/SocketPermissionTest.java question about Optional usage in joinGroupMulticastTest()

2021-07-06 Thread Baesken, Matthias
Hi Daniel, thanks for confirming , I opened https://bugs.openjdk.java.net/browse/JDK-8269919 JDK-8269919: SocketPermissionTest.java problematic Optional usage in joinGroupMulticastTest Best regards, Matthias -Original Message- From: Daniel Fuchs Sent: Dienstag, 6. Juli 2021 16:

Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v6]

2021-07-06 Thread Brian Burkhalter
> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: Clea

Integrated: 8269917: Insert missing commas in copyrights in java.net

2021-07-06 Thread Patrick Concannon
On Tue, 6 Jul 2021 14:41:18 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my patch for Inserting missing commas in > copyright headers from files in java.net. These commas were mistakenly left > out of PR https://github.com/openjdk/jdk/pull/4574. > > Kind regards, > >

Re: RFR: 8269917: Insert missing commas in copyrights in java.net

2021-07-06 Thread Chris Hegarty
On Tue, 6 Jul 2021 14:41:18 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my patch for Inserting missing commas in > copyright headers from files in java.net. These commas were mistakenly left > out of PR https://github.com/openjdk/jdk/pull/4574. > > Kind regards, > >

Re: RFR: 8269917: Insert missing commas in copyrights in java.net

2021-07-06 Thread Daniel Fuchs
On Tue, 6 Jul 2021 14:41:18 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my patch for Inserting missing commas in > copyright headers from files in java.net. These commas were mistakenly left > out of PR https://github.com/openjdk/jdk/pull/4574. > > Kind regards, > >

RFR: 8269917: Insert missing commas in copyrights in java.net

2021-07-06 Thread Patrick Concannon
Hi, Could someone please review my patch for Inserting missing commas in copyright headers from files in java.net. These commas were mistakenly left out of PR https://github.com/openjdk/jdk/pull/4574. Kind regards, 
Patrick - Commit messages: - 8269917: Insert missing commas in c

Re: test/jdk/java/net/SocketPermission/SocketPermissionTest.java question about Optional usage in joinGroupMulticastTest()

2021-07-06 Thread Daniel Fuchs
Thanks Matthias, It does look like a bug. We probably have at least one IPv4 multicast interfaces on all machines in our CI! Not sure whether randomly selecting the first one is such a good idea though - we may have to investigate how stable the test gets if we fix this... best regards, -- dani

Integrated: 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation

2021-07-06 Thread Patrick Concannon
On Wed, 23 Jun 2021 12:06:41 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my changes for the removal of the legacy > `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations? > > In JDK 13, JEP 353 provided a drop in replacement for the legacy > `PlainSocketImpl

test/jdk/java/net/SocketPermission/SocketPermissionTest.java question about Optional usage in joinGroupMulticastTest()

2021-07-06 Thread Baesken, Matthias
Hi , I wonder about the coding in SocketPermissionTest.java joinGroupMulticastTest() : https://github.com/openjdk/jdk/blob/master/test/jdk/java/net/SocketPermission/SocketPermissionTest.java#L224 // Positive ( requires a functional network interface ) Optional onif = pr

Integrated: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE

2021-07-06 Thread Julia Boes
On Fri, 2 Jul 2021 11:56:04 GMT, Julia Boes wrote: > `com.sun.net.httpserver.HttpServer::createContext` specifies > `IllegalArgumentException` to be thrown if a context already exists for the > path provided. The implementation class`sun.net.httpserver.ServerImpl` does > not comply with this,

Re: RFR: 8269692: sun.net.httpserver.ServerImpl::createContext should throw IAE [v2]

2021-07-06 Thread Daniel Fuchs
On Mon, 5 Jul 2021 13:38:19 GMT, Julia Boes wrote: >> `com.sun.net.httpserver.HttpServer::createContext` specifies >> `IllegalArgumentException` to be thrown if a context already exists for the >> path provided. The implementation class`sun.net.httpserver.ServerImpl` does >> not comply with th

Re: RFR: 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation [v6]

2021-07-06 Thread Patrick Concannon
> Hi, > > Could someone please review my changes for the removal of the legacy > `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations? > > In JDK 13, JEP 353 provided a drop in replacement for the legacy > `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl` > imple

Re: [jdk17] RFR: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"

2021-07-06 Thread Chris Hegarty
On Mon, 5 Jul 2021 11:21:39 GMT, Daniel Fuchs wrote: > Please find here a trivial fix for: > > 8269772: [macos-aarch64] test compilation failed with "SocketException: No > buffer space available" > > Running several of the websocket tests concurrently on some of the CI > machines is causing r