Re: RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly [v2]

2021-04-13 Thread Vyom Tewari
On Tue, 13 Apr 2021 10:30:18 GMT, Conor Cleary wrote: >> ### Description >> `Inet6Address/B6206527.java` test creates two instances of ServerSocket, >> both of which are explicity bound to a Link-Local address. Neither of the >> ServerSocket instances are explicitly closed meaning there is no g

Re: RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly [v2]

2021-04-13 Thread Michael McMahon
On Tue, 13 Apr 2021 10:30:18 GMT, Conor Cleary wrote: >> ### Description >> `Inet6Address/B6206527.java` test creates two instances of ServerSocket, >> both of which are explicity bound to a Link-Local address. Neither of the >> ServerSocket instances are explicitly closed meaning there is no g

Re: RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly [v2]

2021-04-13 Thread Daniel Fuchs
On Tue, 13 Apr 2021 10:30:18 GMT, Conor Cleary wrote: >> ### Description >> `Inet6Address/B6206527.java` test creates two instances of ServerSocket, >> both of which are explicity bound to a Link-Local address. Neither of the >> ServerSocket instances are explicitly closed meaning there is no g

Re: RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly [v2]

2021-04-13 Thread Conor Cleary
On Tue, 13 Apr 2021 09:04:02 GMT, Michael McMahon wrote: >> Conor Cleary has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed othervm argument > > test/jdk/java/net/Inet6Address/B6206527.java line 47: > >> 45: } >> 46: >> 47

Re: RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly [v2]

2021-04-13 Thread Conor Cleary
> ### Description > `Inet6Address/B6206527.java` test creates two instances of ServerSocket, both > of which are explicity bound to a Link-Local address. Neither of the > ServerSocket instances are explicitly closed meaning there is no guarantee > that their associated resources are freed. > >

Re: RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly

2021-04-13 Thread Conor Cleary
On Tue, 13 Apr 2021 09:14:47 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/Inet6Address/B6206527.java line 31: >> >>> 29: * @build jdk.test.lib.NetworkConfiguration >>> 30: *jdk.test.lib.Platform >>> 31: * @run main/othervm B6206527 >> >> Does it need othervm mode? Best to not use it

Re: RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly

2021-04-13 Thread Daniel Fuchs
On Tue, 13 Apr 2021 09:03:01 GMT, Michael McMahon wrote: >> ### Description >> `Inet6Address/B6206527.java` test creates two instances of ServerSocket, >> both of which are explicity bound to a Link-Local address. Neither of the >> ServerSocket instances are explicitly closed meaning there is n

Re: RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly

2021-04-13 Thread Michael McMahon
On Mon, 12 Apr 2021 15:21:05 GMT, Conor Cleary wrote: > ### Description > `Inet6Address/B6206527.java` test creates two instances of ServerSocket, both > of which are explicity bound to a Link-Local address. Neither of the > ServerSocket instances are explicitly closed meaning there is no guara