Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-03-19 Thread Chris Hegarty
On Tue, 16 Feb 2021 13:37:20 GMT, Jamie Le Tual wrote: >> I think that the changes are mostly good. I would like to try them out on my >> local system and our internal buildAndTest system. > >> I think that the changes are mostly good. I would like to try them out on my >> local system and our

Integrated: 8263658: Use the blessed modifier order in java.base

2021-03-19 Thread Alex Blewitt
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt wrote: > Sonar displays a warning message that modifiers should be declared in the > order listed in the JLS; specifically, that isntead of using `final static` > the `static final` should be preferred. > > This fixes the issues in the `java.base

Re: RFR: 8263080: Obsolete relationship in MulticastSocket API documentation. [v4]

2021-03-19 Thread Daniel Fuchs
> Now that DatagramSocket has been updated by JDK-8237352 to support joining > multicast group, this sentence in the API class level documentation of > MulticastSocket is obsolete and should be removed: > > "A MulticastSocket is a (UDP) DatagramSocket, with additional capabilities for > joining

Integrated: 8263818: Release JNI local references in get/set-InetXXAddress-member helper functions of net_util.c

2021-03-19 Thread Chris Hegarty
On Thu, 18 Mar 2021 14:57:16 GMT, Chris Hegarty wrote: > As per the Java Native Interface Specification: "All Java objects returned by > JNI functions are local references." [1]. > > The get/set-InetXXAddress-member helper functions in net_util.c retrieve a > local reference to the internal `

Re: RFR: 8263818: Release JNI local references in get/set-InetXXAddress-member helper functions of net_util.c

2021-03-19 Thread Alan Bateman
On Thu, 18 Mar 2021 14:57:16 GMT, Chris Hegarty wrote: > As per the Java Native Interface Specification: "All Java objects returned by > JNI functions are local references." [1]. > > The get/set-InetXXAddress-member helper functions in net_util.c retrieve a > local reference to the internal `