Re: RFR: JDK-8262430: doclint warnings in java.base module

2021-02-25 Thread Alan Bateman
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote: > Please review some simple doc fixes in the `java.base` module. Two were > reported by doclint; the spelling error was detected by the IDE. I think the broken link issue is very recent as it only had to reference InetSocketAddress whe

RFR: JDK-8262430: doclint warnings in java.base module

2021-02-25 Thread Jonathan Gibbons
Please review some simple doc fixes in the `java.base` module. Two were reported by doclint; the spelling error was detected by the IDE. - Commit messages: - JDK-8262430: doclint warnings in java.base module Changes: https://git.openjdk.java.net/jdk/pull/2734/files Webrev: https:

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property) [v2]

2021-02-25 Thread Daniel Fuchs
On Thu, 25 Feb 2021 19:16:58 GMT, Conor Cleary wrote: >> test/jdk/java/net/InetAddress/InternalNameServiceWithNoHostsFileTest.java >> line 32: >> >>> 30: * thrown >>> 31: * @run main/othervm -Djdk.net.hosts.file=TestHosts-II >>> -Dsun.net.inetaddr.ttl=0 >>> 32: * InternalN

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property) [v2]

2021-02-25 Thread Conor Cleary
On Thu, 25 Feb 2021 17:26:00 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8262195: Copyrights & InternalNSTest Host File Delete >> - 8262195: Added descriptive comments and filename > > test

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property) [v2]

2021-02-25 Thread Aleksei Efimov
On Thu, 25 Feb 2021 15:38:02 GMT, Conor Cleary wrote: >> A number of net tests use a >> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** >> to verify either the functionality of th

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property) [v2]

2021-02-25 Thread Daniel Fuchs
On Thu, 25 Feb 2021 15:38:02 GMT, Conor Cleary wrote: >> A number of net tests use a >> **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** >> to verify either the functionality of th

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-25 Thread Daniel Fuchs
On Thu, 25 Feb 2021 16:59:07 GMT, Naoto Sato wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed comment > > src/java.base/share/classes/java/net/InetSocketAddress.java line 326: > >> 324: /** >> 325: *

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-25 Thread Naoto Sato
On Thu, 25 Feb 2021 11:05:07 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a change that fixes "no comment" warnings generated by >> `javadoc -Xdoclint` for `java.base/java.net` > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property) [v2]

2021-02-25 Thread Conor Cleary
> A number of net tests use a > **[HostsFileNameService](https://github.com/openjdk/jdk/blob/382e38dd246596ec94a1f1ce0e0f9e87f53366c7/src/java.base/share/classes/java/net/InetAddress.java#L955)** > to verify either the functionality of this type of Name Service or as a > complement to other test

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net

2021-02-25 Thread Daniel Fuchs
On Wed, 24 Feb 2021 20:42:52 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` The CSR draft can be reviewed here: https://bugs.openjdk.java.net/browse/JDK-8262372 - PR: https

Re: RFR: 8261880: Change nested classes in java.base to static nested classes where possible [v2]

2021-02-25 Thread Сергей Цыпанов
On Wed, 24 Feb 2021 08:50:36 GMT, Alan Bateman wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8261880: Remove static from declarations of Holder nested classes > > src/java.base/windows/classes/sun/nio/ch/PipeIm

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-25 Thread Daniel Fuchs
> Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Fixed comment - Changes: - all: https:

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-25 Thread Daniel Fuchs
On Thu, 25 Feb 2021 09:24:50 GMT, Patrick Concannon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed comment > > src/java.base/share/classes/java/net/HttpRetryException.java line 48: > >> 46: >> 47: /**

Integrated: 8262296 Fix remaining doclint warnings in jdk.httpserver

2021-02-25 Thread Chris Hegarty
On Wed, 24 Feb 2021 13:58:38 GMT, Chris Hegarty wrote: > Trivial clean up of remaining doclint warnings in jdk.httpserver. > > The minor spec clarifications do not amount to a normative change, so no CSR > is required (they're documented the obvious and only possible behaviour). This pull req

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net

2021-02-25 Thread Patrick Concannon
On Wed, 24 Feb 2021 20:42:52 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` src/java.base/share/classes/java/net/HttpRetryException.java line 48: > 46: > 47: /** > 48: * the U