Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-02-02 Thread Xue-Lei Andrew Fan
On Tue, 2 Feb 2021 01:15:25 GMT, Clive Verghese wrote: > Hi, > > Thank you for the feedback. > > I have verified that tier1 and tier2 tests pass on Windows, MacOS and Linux. Thank you! I will address the closed test failures. I will post you when the update is ready. - PR: htt

Re: RFR: JDK-8241995: Clarify InetSocketAddress::toString specification

2021-02-02 Thread Michael McMahon
On Tue, 2 Feb 2021 15:55:40 GMT, Julia Boes wrote: > This change clarifies the InetSocketAddress::toString specification, which > was recently updated to reflect an implementation change [1]. The > specification is not changed, but it is enhanced with two examples and some > more verbiage, as

Re: 8241995: Clarify InetSocketAddress::toString specification

2021-02-02 Thread Julia Boes
Hi Jaikiran, I just created a PR, taking into consideration your suggestion: https://github.com/openjdk/jdk/pull/2357 https://mail.openjdk.java.net/pipermail/net-dev/2021-February/015298.html Regards, Julia From: net-dev on behalf of Jaikiran Pai Date: Tuesday, 2 February 2021 at 15:06 To: C

RFR: JDK-8241995: Clarify InetSocketAddress::toString specification

2021-02-02 Thread Julia Boes
This change clarifies the InetSocketAddress::toString specification, which was recently updated to reflect an implementation change [1]. The specification is not changed, but it is enhanced with two examples and some more verbiage, as per earlier suggestions on the net-dev mailing list [2][3].

Re: 8241995: Clarify InetSocketAddress::toString specification

2021-02-02 Thread Jaikiran Pai
Hello Chris, I missed this thread previously. This suggested change to the javadoc looks good to me and the example now makes it clear on what to expect. As for the last paragraph of the javadoc, I'm just adding to the suggestions already made by others in this thread. Perhaps the following

Withdrawn: 8235140: Investigate deprecation of the Socket/ServerSocket impl factory mechanism

2021-02-02 Thread Patrick Concannon
On Tue, 2 Feb 2021 12:27:08 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my proposed change for JDK-8235140: '`Investigate > deprecation of the Socket/ServerSocket impl factory mechanism`' ? > > This fix proposes to deprecate (for the eventual removal) the API points fo

RFR: 8235140: 'Investigate deprecation of the Socket/ServerSocket impl factory mechanism'

2021-02-02 Thread Patrick Concannon
Hi, Could someone please review my proposed change for JDK-8235140: '`Investigate deprecation of the Socket/ServerSocket impl factory mechanism`' ? This fix proposes to deprecate (for the eventual removal) the API points for statically configuring a system-wide factory for the `Socket/SocketSer