Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-02-01 Thread Clive Verghese
On Fri, 29 Jan 2021 00:50:04 GMT, Xue-Lei Andrew Fan wrote: >> Clive Verghese has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments > > Please make sure all tier1 and tier2 tests passed on all supported platforms. > E

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v9]

2021-02-01 Thread Clive Verghese
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears > to not be fully fixed > > This also fixes JDK-8259516: Alerts sent by peer may not be received > correctly during TLS handshake Clive Verghese has updated the pull request incrementally with one additional commit s

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v6]

2021-02-01 Thread Alan Bateman
On Mon, 1 Feb 2021 16:56:03 GMT, Daniel Fuchs wrote: >> DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that >> allows to globally replace the default DatagramSocket/MulticastSocket >> implementation provided by the JDK. This was provided as a way in early JDK >> releas

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory

2021-02-01 Thread Alan Bateman
On Mon, 1 Feb 2021 15:52:21 GMT, Daniel Fuchs wrote: > > I think the title can be changed to something like "Update DatagramSocket > > to add support for joining multicast groups" or something that makes it > > clearer what the changes are about. > > Done. Let's see whether the bot deals with

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v5]

2021-02-01 Thread Daniel Fuchs
On Sat, 30 Jan 2021 10:24:05 GMT, Alan Bateman wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixup @bug in the tests > > src/java.base/share/classes/java/net/DatagramSocket.java line 223: > >> 221: *to

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v6]

2021-02-01 Thread Daniel Fuchs
> DatagramSocket has a DatagramSocket.setDatagramSocketImplFactory method that > allows to globally replace the default DatagramSocket/MulticastSocket > implementation provided by the JDK. This was provided as a way in early JDK > releases to replace the system wide implementation. It has been m

Re: RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory

2021-02-01 Thread Daniel Fuchs
On Sat, 30 Jan 2021 08:15:01 GMT, Alan Bateman wrote: > I think the title can be changed to something like "Update DatagramSocket to > add support for joining multicast groups" or something that makes it clearer > what the changes are about. Done. Let's see whether the bot deals with the chang