Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-01-28 Thread Xue-Lei Andrew Fan
On Thu, 28 Jan 2021 20:12:14 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has up

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-01-28 Thread Clive Verghese
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears > to not be fully fixed > > This also fixes JDK-8259516: Alerts sent by peer may not be received > correctly during TLS handshake Clive Verghese has updated the pull request incrementally with one additional commit s

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-28 Thread Xue-Lei Andrew Fan
On Tue, 26 Jan 2021 18:56:57 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has up

Re: RFR: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order

2021-01-28 Thread Daniel Fuchs
On Thu, 28 Jan 2021 16:42:02 GMT, Evan Whelan wrote: > Hi all, > > Please review this fix for which corrects the order in which field values are > returned from the `HttpURLConnection.getHeaderFields` and > `URLConnection.getRequestProperties` methods. > > Currently, the implementation of the

RFR: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order

2021-01-28 Thread Evan Whelan
Hi all, Please review this fix for which corrects the order in which field values are returned from the `HttpURLConnection.getHeaderFields` and `URLConnection.getRequestProperties` methods. Currently, the implementation of these methods returns the values in reverse. This does not conform with

Re: RFR: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently [v5]

2021-01-28 Thread Patrick Concannon
> Hi, > > Could someone please review my fix for JDK-8259628: > '`jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java` fails > intermittently' ? > > `AsynchronousSocketChannelNAPITest` is failing intermittently on Linux due to > a race condition caused by not correctly waiting

Integrated: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently

2021-01-28 Thread Patrick Concannon
On Wed, 20 Jan 2021 11:52:17 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my fix for JDK-8259628: > '`jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java` fails > intermittently' ? > > `AsynchronousSocketChannelNAPITest` is failing intermittently on Lin

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]

2021-01-28 Thread Claes Redestad
On Wed, 27 Jan 2021 19:03:38 GMT, Sean Mullan wrote: >> Claes Redestad has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Copyrights >> - Same for Windows > > Marked as reviewed by mullan (Reviewer). @seanjmullan @dfuch @Michael-Mc-Maho

Integrated: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

2021-01-28 Thread Claes Redestad
On Wed, 27 Jan 2021 14:47:08 GMT, Claes Redestad wrote: > 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed This pull request has now been integrated. Changeset: 8fe1323d Author:Claes Redestad URL: https://git.openjdk.java.net/jdk/commit/8fe132