Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]

2021-01-27 Thread Sean Mullan
On Wed, 27 Jan 2021 18:59:00 GMT, Claes Redestad wrote: >> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager >> installed > > Claes Redestad has updated the pull request incrementally with two additional > commits since the last revision: > > - Copyrights > - Same

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]

2021-01-27 Thread Daniel Fuchs
On Wed, 27 Jan 2021 18:59:00 GMT, Claes Redestad wrote: >> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager >> installed > > Claes Redestad has updated the pull request incrementally with two additional > commits since the last revision: > > - Copyrights > - Same

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]

2021-01-27 Thread Claes Redestad
> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed Claes Redestad has updated the pull request incrementally with two additional commits since the last revision: - Copyrights - Same for Windows - Changes: - all: https://git.openjdk.java.

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]

2021-01-27 Thread Claes Redestad
On Wed, 27 Jan 2021 16:57:25 GMT, Sean Mullan wrote: > Will you make the same change to > `src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java`? Good catch. Let's keep things consistent. :-) - PR: https://git.openjdk.java.net/jdk/pull/2263

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-27 Thread Clive Verghese
On Wed, 27 Jan 2021 17:46:03 GMT, Xue-Lei Andrew Fan wrote: >> Changes requested by rhalade (Reviewer). > > For the CSR request, I updated the component to security-libs/javax.net.ssl, > add 17 as one of the fix versions, and added myself as reviewer. Thank you. I will change the status of the

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-27 Thread Xue-Lei Andrew Fan
On Wed, 13 Jan 2021 18:46:10 GMT, Rajan Halade wrote: >> Clive Verghese has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Update copyright year >> - Add error handling guidelines >> - Fix bugids and use serv

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

2021-01-27 Thread Sean Mullan
On Wed, 27 Jan 2021 15:10:16 GMT, Michael McMahon wrote: >> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager >> installed > > Marked as reviewed by michaelm (Reviewer). Will you make the same change to `src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileF

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

2021-01-27 Thread Michael McMahon
On Wed, 27 Jan 2021 14:47:08 GMT, Claes Redestad wrote: > 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed Marked as reviewed by michaelm (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2263

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

2021-01-27 Thread Claes Redestad
On Wed, 27 Jan 2021 14:54:33 GMT, Alan Bateman wrote: >> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager >> installed > > Should be okay as the side effect of getPermission is not observable. Make > sure to run all the tests before integrating. @AlanBateman @dfuch

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

2021-01-27 Thread Daniel Fuchs
On Wed, 27 Jan 2021 14:47:08 GMT, Claes Redestad wrote: > 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed Looks reasonable to me. Make sure to run jdk-tier2 (or jdk_core) just in case :-) - Marked as reviewed by dfuchs (Reviewer). PR: htt

Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

2021-01-27 Thread Alan Bateman
On Wed, 27 Jan 2021 14:47:08 GMT, Claes Redestad wrote: > 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed Should be okay as the side effect of getPermission is not observable. Make sure to run all the tests before integrating. - Marked as

RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

2021-01-27 Thread Claes Redestad
8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed - Commit messages: - Avoid getting permissions when there's no SM installed Changes: https://git.openjdk.java.net/jdk/pull/2263/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2263&r