> Hi, Please review
> Windows mapping for file into memory could not happen to reserved memory.
> In mapping CDS archive we first reserve enough memory then before mapping,
> release them. For cds archive and using class space, need split the whole
> space into two, that is, release the whole
On Mon, 7 Dec 2020 15:32:54 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for JDK-8254996: 'make
> jdk.net.UnixDomainPrincipal a record class'?
>
> `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires
> boilerplate methods for access. How
On Mon, 7 Dec 2020 17:11:28 GMT, Conor Cleary wrote:
>> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
>> seen to fail with an IllegalMonitorStateException. This failure was caused
>> by the use of `wait()` in a non synchronized block. This failure was
>> mitigated t
On Mon, 7 Dec 2020 14:53:25 GMT, Daniel Fuchs wrote:
>> Conor Cleary has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8255583: Added original bug id to bug tag
>> - 8255583: Add bug & summary tags to KeepAliveStreamCleanerTestDriver
>
> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
> seen to fail with an IllegalMonitorStateException. This failure was caused by
> the use of `wait()` in a non synchronized block. This failure was mitigated
> through use of `await()` instead as is shown below (code can
On Mon, 7 Dec 2020 15:32:54 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for JDK-8254996: 'make
> jdk.net.UnixDomainPrincipal a record class'?
>
> `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires
> boilerplate methods for access. How
On Fri, 4 Dec 2020 17:41:47 GMT, Daniel Fuchs wrote:
> The timeout tests extending AbstractConnectTimeout have been relaxed to
> accept a
> ConnectException wrapping NoRouteToHostException.
> These test have been observed failing intermittently with ConnectException
> wrapping
> java.nio.channe
Hi,
Could someone please review my code for JDK-8254996: 'make
jdk.net.UnixDomainPrincipal a record class'?
`jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires
boilerplate methods for access. However, these methods and fields are
susceptible to trivial mistakes and add
On Mon, 7 Dec 2020 11:39:30 GMT, Conor Cleary wrote:
>> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
>> seen to fail with an IllegalMonitorStateException. This failure was caused
>> by the use of `wait()` in a non synchronized block. This failure was
>> mitigated t
On Mon, 7 Dec 2020 11:09:47 GMT, Conor Cleary wrote:
>> Will do Daniel, thanks for pointing that out!
>
> Should probably add a short summary as well
Added bug ids for the original issue which you referred to and for the issue
this PR relates to. Will mark as resolved if this is all good
-
> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
> seen to fail with an IllegalMonitorStateException. This failure was caused by
> the use of `wait()` in a non synchronized block. This failure was mitigated
> through use of `await()` instead as is shown below (code can
On Mon, 7 Dec 2020 10:55:06 GMT, Daniel Fuchs wrote:
>> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
>> seen to fail with an IllegalMonitorStateException. This failure was caused
>> by the use of `wait()` in a non synchronized block. This failure was
>> mitigated t
On Mon, 7 Dec 2020 11:08:37 GMT, Conor Cleary wrote:
>> test/jdk/sun/net/www/http/KeepAliveStreamCleaner/KeepAliveStreamCleanerTestDriver.java
>> line 26:
>>
>>> 24: /*
>>> 25: * @test
>>> 26: * @modules java.base/sun.net.www.http
>>
>> Hi Conor,
>>
>> Can you add:
>>
>> @bug 8255124
>>
>
On Mon, 7 Dec 2020 09:52:47 GMT, Conor Cleary wrote:
> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously
> seen to fail with an IllegalMonitorStateException. This failure was caused by
> the use of `wait()` in a non synchronized block. This failure was mitigated
> throu
The KeepAliveStreamCleaner in sun.net.ww.http package had been previously seen
to fail with an IllegalMonitorStateException. This failure was caused by the
use of `wait()` in a non synchronized block. This failure was mitigated through
use of `await()` instead as is shown below (code can be view
On Wed, 2 Dec 2020 17:00:07 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find below a fix that fixes an issue in Http2TestServerConnection -
> where the
> connection will be closed by the test server if the test server receives a
> RESET from the client
> after the stream has been closed.
>
> T
16 matches
Mail list logo
