Integrated: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Xue-Lei Andrew Fan
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Xue-Lei Andrew Fan
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
On Thu, 26 Nov 2020 20:26:36 GMT, Xue-Lei Andrew Fan wrote: >> Certain TLS ALPN values can't be properly read or written by the SunJSSE >> provider. This is due to the choice of Strings as the API interface and the >> undocumented internal use of the UTF-8 Character Set which converts >> chara

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
On Thu, 26 Nov 2020 10:33:26 GMT, Daniel Fuchs wrote: >> Certain TLS ALPN values can't be properly read or written by the SunJSSE >> provider. This is due to the choice of Strings as the API interface and the >> undocumented internal use of the UTF-8 Character Set which converts >> characters

RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Bradford Wetmore
Certain TLS ALPN values can't be properly read or written by the SunJSSE provider. This is due to the choice of Strings as the API interface and the undocumented internal use of the UTF-8 Character Set which converts characters larger than U+7F into multi-byte arrays that may not be expected

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Daniel Fuchs
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: icmp and raw sockets on linux

2020-12-01 Thread Jamie Le Tual
Hi Alan, I received an email this morning saying my OCA had been processed, but that it would perhaps take a couple of hours before a bot picks it up and I show up on the OCA signatories page (no idea where that page is though). I have also updated the patch in my pull request to cover ipv6 as wel

RFR: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows

2020-12-01 Thread Mat Carter
Modified Windows specific loopback macros to support full range of loopback addresses, commit message includes unit test data as there's no gtest's for java libraries (only hotspot compiler) This is an expansion on the original fix for 8250521: Configure initial RTO to use minimal retry for loo

Re: RFR: JDK-8257401: Use switch expressions in jdk.internal.net.http and java.net.http

2020-12-01 Thread Daniel Fuchs
On Tue, 1 Dec 2020 01:51:35 GMT, John Jiang wrote: > Do we have clear guideline or requirement for using this new lang feature? > We know there are a lot of old switch-case blocks in the existing codes, > including source codes and test codes. @johnshajiang I don't think we have any global guide

Re: RFR: JDK-8257401: Use switch expressions in jdk.internal.net.http and java.net.http [v2]

2020-12-01 Thread Patrick Concannon
On Mon, 30 Nov 2020 13:04:11 GMT, Kartik Ohri wrote: >> Hi! >> Kindly review this patch to replace switch statements with switch >> expressions (where it makes sense) in the http client modules. The rationale >> is to improve readability of the code. >> Regards, >> Kartik > > Kartik Ohri has r