Re: Use switch expressions in jdk.internal.net.http and java.net.http

2020-11-25 Thread Patrick Concannon
Hi Kartik, Thanks for running the tests. I’m not sure about your problem on Ubuntu 20.10, but I’ll take a look into it. Just so you know, you can also run tests using jtreg. You can find more information on how to do that here: http://openjdk.java.net/jtreg/runtests.html I’ll import your patch

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref)

2020-11-25 Thread Daniel Fuchs
On Wed, 25 Nov 2020 08:50:18 GMT, Сергей Цыпанов wrote: >> Please merge from master to get a fresh round of testing. @AlanBateman might >> want to look at it. > > Done! I'll have a look at this when I can spare some cycles. @stsypanov did you run tier2 tests? - PR: https://git.o

Re: Use switch expressions in jdk.internal.net.http and java.net.http

2020-11-25 Thread Kartik Ohri
Hi Chris and Patrick, It is the first time I am running the tier2 tests so I am not sure if I am doing it correctly. I'll share what I did and my observations. I executed make run-test-tier2 on my Ubuntu 20.10 machine and the tests failed to build due to some warnings in a hostpot jtreg test. The

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref) [v2]

2020-11-25 Thread Сергей Цыпанов
> Hello, while working with `java.net.URL` I've found unused package-private > method `URL.set(String protocol, String host, int port, String file, String > ref)` which can be safely removed from JDK. Testing: tier1, tier2 > > Could someone crate an issue for tracking of this simple change? Сер

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref)

2020-11-25 Thread Сергей Цыпанов
On Wed, 25 Nov 2020 08:02:07 GMT, Aleksey Shipilev wrote: >> @shipilev thanks for filing the issue! Done. > > Please merge from master to get a fresh round of testing. @AlanBateman might > want to look at it. Done! - PR: https://git.openjdk.java.net/jdk/pull/779

Re: RFR: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref)

2020-11-25 Thread Aleksey Shipilev
On Tue, 27 Oct 2020 19:46:27 GMT, Сергей Цыпанов wrote: >> Submitted [here](https://bugs.openjdk.java.net/browse/JDK-8255477), please >> try to update the PR title to "8255477: Remove unused method URL.set(String >> protocol, String host, int port, String file, String ref)". Also, merge from