On Tue, 17 Nov 2020 05:02:07 GMT, Christoph Langer wrote:
>> The test com/sun/jndi/dns/ConfigTests/PortUnreachable.java is not working on
>> AIX.
>>
>> It tests that when a DNS server is unreachable it fails quickly with a
>> PortUnreachableException due to ICMP Destination Unreachable packets
On Tue, 17 Nov 2020 17:28:45 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 335:
>>
>>> 333: * Remove a particular header (e.g. Foo-Bar):
>>> 334: * {@code HttpRequest.newBuilder(request, (name, value) ->
>>> name.equalsIgnoreCase("F
On Tue, 17 Nov 2020 18:09:03 GMT, Xue-Lei Andrew Fan wrote:
>> Sean Mullan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More test changes.
>
> Marked as reviewed by xuelei (Reviewer).
Hi Sean,
The changes to the HttpClient test look
On Tue, 17 Nov 2020 17:55:19 GMT, Sean Mullan wrote:
>> This change disables the TLSv1 and TLSv1.1 protocols by adding them to the
>> jdk.tls.disabledAlgorithms security property in the java.security file.
>> These protocols use weak algorithms and are being deprecated by the IETF.
>> They sho
On Tue, 17 Nov 2020 17:55:19 GMT, Sean Mullan wrote:
>> This change disables the TLSv1 and TLSv1.1 protocols by adding them to the
>> jdk.tls.disabledAlgorithms security property in the java.security file.
>> These protocols use weak algorithms and are being deprecated by the IETF.
>> They sho
> This change disables the TLSv1 and TLSv1.1 protocols by adding them to the
> jdk.tls.disabledAlgorithms security property in the java.security file. These
> protocols use weak algorithms and are being deprecated by the IETF. They
> should be disabled by default to improve the default security
On Tue, 17 Nov 2020 17:16:48 GMT, Michael McMahon wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> c
On Mon, 16 Nov 2020 15:54:18 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existi
On Mon, 16 Nov 2020 15:54:18 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existi
On Tue, 17 Nov 2020 16:16:53 GMT, Patrick Concannon
wrote:
>> test/jdk/java/net/httpclient/HttpRequestNewBuilderTest.java line 320:
>>
>>> 318: @Test(dataProvider = "testRequests")
>>> 319: public void testRemoveHeader(HttpRequest request) {
>>> 320: BiPredicate filter = (n, v)
On Mon, 16 Nov 2020 17:29:20 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> comm
On Mon, 2 Nov 2020 22:04:56 GMT, Michael McMahon wrote:
> Minor spec changes from spec approved in initial CSR
This pull request has now been integrated.
Changeset: 9d0ee66f
Author:Michael McMahon
URL: https://git.openjdk.java.net/jdk/commit/9d0ee66f
Stats: 70 lines in 3 files ch
On Tue, 17 Nov 2020 11:53:14 GMT, Michael McMahon wrote:
>> Minor spec changes from spec approved in initial CSR
>
> Michael McMahon has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - update from Alan's comment Nov 17
> - minor change sugge
On Tue, 17 Nov 2020 11:25:22 GMT, Alan Bateman wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> comm
> Minor spec changes from spec approved in initial CSR
Michael McMahon has updated the pull request incrementally with two additional
commits since the last revision:
- update from Alan's comment Nov 17
- minor change suggested by Daniel
-
Changes:
- all: https://git.openjdk.ja
On Mon, 16 Nov 2020 13:29:26 GMT, Michael McMahon wrote:
>> Minor spec changes from spec approved in initial CSR
>
> Michael McMahon has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/
On Tue, 17 Nov 2020 07:50:10 GMT, ANUPAM DEV
wrote:
> 8255675: Typo in java.net.HttpURLConnection
Hello All,
Could you please review this fix?
Bug: https://bugs.openjdk.java.net/browse/JDK-8255675
Problem description: In the getResponseCode method, the following comment was
unclear:
"If we
17 matches
Mail list logo
