RFR: 8255675: Typo in java.net.HttpURLConnection

2020-11-16 Thread ANUPAM DEV
8255675: Typo in java.net.HttpURLConnection - Commit messages: - Merge pull request #1 from anupamdev20/JDK-8255675 - 8255675: Typo in java.net.HttpURLConnection Changes: https://git.openjdk.java.net/jdk/pull/1250/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1250&ra

Re: RFR: 8256427: Test com/sun/jndi/dns/ConfigTests/PortUnreachable.java does not work on AIX [v2]

2020-11-16 Thread Jie Fu
On Tue, 17 Nov 2020 05:02:07 GMT, Christoph Langer wrote: >> The test com/sun/jndi/dns/ConfigTests/PortUnreachable.java is not working on >> AIX. >> >> It tests that when a DNS server is unreachable it fails quickly with a >> PortUnreachableException due to ICMP Destination Unreachable packets

Re: RFR: 8256427: Test com/sun/jndi/dns/ConfigTests/PortUnreachable.java does not work on AIX [v2]

2020-11-16 Thread Christoph Langer
On Tue, 17 Nov 2020 03:33:58 GMT, Jie Fu wrote: >> Christoph Langer has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains one commit: >> >> Test jdk/com/sun/jndi/dns/ConfigTests/PortUnreachable.java does not work >> on AIX > > test/j

Re: RFR: 8256427: Test com/sun/jndi/dns/ConfigTests/PortUnreachable.java does not work on AIX [v2]

2020-11-16 Thread Christoph Langer
> The test com/sun/jndi/dns/ConfigTests/PortUnreachable.java is not working on > AIX. > > It tests that when a DNS server is unreachable it fails quickly with a > PortUnreachableException due to ICMP Destination Unreachable packets received > and not having to wait for the full timeout interval

Re: RFR: 8256427: Test com/sun/jndi/dns/ConfigTests/PortUnreachable.java does not work on AIX

2020-11-16 Thread Jie Fu
On Mon, 16 Nov 2020 22:28:08 GMT, Christoph Langer wrote: > The test com/sun/jndi/dns/ConfigTests/PortUnreachable.java is not working on > AIX. > > It tests that when a DNS server is unreachable it fails quickly with a > PortUnreachableException due to ICMP Destination Unreachable packets rece

Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v8]

2020-11-16 Thread Daniel Fuchs
On Mon, 16 Nov 2020 15:54:18 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review our code for JDK-8252304: 'Seed an >> HttpRequest.Builder from an existing HttpRequest'? >> >> This RFR proposes a new factory method for creating a new `HttpRequest` >> builder from an existi

Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v6]

2020-11-16 Thread Patrick Concannon
On Fri, 13 Nov 2020 17:16:21 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/HttpRequestNewBuilderTest.java line 171: >> >>> 169: while (iter1.hasNext() && iter2.hasNext()) >>> 170: assertEquals(iter1.next(), iter2.next()); >>> 171: } >> >> This code doesn't see

Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v8]

2020-11-16 Thread Patrick Concannon
> Hi, > > Could someone please review our code for JDK-8252304: 'Seed an > HttpRequest.Builder from an existing HttpRequest'? > > This RFR proposes a new factory method for creating a new `HttpRequest` > builder from an existing `HttpRequest`. > This method can be used to build a new request eq

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-16 Thread Michael McMahon
On Mon, 16 Nov 2020 14:42:02 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> comm

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-16 Thread Daniel Fuchs
On Mon, 16 Nov 2020 13:29:26 GMT, Michael McMahon wrote: >> Minor spec changes from spec approved in initial CSR > > Michael McMahon has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-16 Thread Michael McMahon
On Sun, 15 Nov 2020 08:32:28 GMT, Alan Bateman wrote: > The clarification to the SecurityException looks good. > > The API docs specify that bind(null) will "bind to an automatically assigned > socket address". Would it be better to lead with that phrase in the > properties doc rather than swi

Re: RFR: 8255758: JEP 380 spec clarifications [v2]

2020-11-16 Thread Michael McMahon
> Minor spec changes from spec approved in initial CSR Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since th

Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v7]

2020-11-16 Thread Patrick Concannon
> Hi, > > Could someone please review our code for JDK-8252304: 'Seed an > HttpRequest.Builder from an existing HttpRequest'? > > This RFR proposes a new factory method for creating a new `HttpRequest` > builder from an existing `HttpRequest`. > This method can be used to build a new request eq