On Fri, 13 Nov 2020 16:45:31 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existi
On Fri, 13 Nov 2020 17:21:02 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> comm
> Hi,
>
> Could someone please review our code for JDK-8252304: 'Seed an
> HttpRequest.Builder from an existing HttpRequest'?
>
> This RFR proposes a new factory method for creating a new `HttpRequest`
> builder from an existing `HttpRequest`.
> This method can be used to build a new request eq
On Wed, 11 Nov 2020 16:45:49 GMT, Daniel Fuchs wrote:
> The HTTP/1.1 Header Parser of the new HttpClient currently assumes that all
> headers (names and value) are US-ASCII and as a result mis-decode any byte
> whose value is > 127; For instance, 0x80 (128) gets decoded as a U+FF80
> (65408) i
On Wed, 11 Nov 2020 16:45:49 GMT, Daniel Fuchs wrote:
> The HTTP/1.1 Header Parser of the new HttpClient currently assumes that all
> headers (names and value) are US-ASCII and as a result mis-decode any byte
> whose value is > 127; For instance, 0x80 (128) gets decoded as a U+FF80
> (65408) i
On Mon, 2 Nov 2020 17:14:28 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws
> IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is
> unspecifi
> Hi,
>
> Could someone please review our code for JDK-8252304: 'Seed an
> HttpRequest.Builder from an existing HttpRequest'?
>
> This RFR proposes a new factory method for creating a new `HttpRequest`
> builder from an existing `HttpRequest`.
> This method can be used to build a new request eq
On Wed, 11 Nov 2020 16:45:49 GMT, Daniel Fuchs wrote:
> The HTTP/1.1 Header Parser of the new HttpClient currently assumes that all
> headers (names and value) are US-ASCII and as a result mis-decode any byte
> whose value is > 127; For instance, 0x80 (128) gets decoded as a U+FF80
> (65408) i
