Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-19 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v6]

2020-10-19 Thread Michael McMahon
On Mon, 19 Oct 2020 17:36:25 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean >> up in HttpsExchange, HttpsParameters, and >> HttpsServer' ? >> This fix is set of formatting changes intended to clean up the javadoc of >> th

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v6]

2020-10-19 Thread Daniel Fuchs
On Mon, 19 Oct 2020 17:36:25 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean >> up in HttpsExchange, HttpsParameters, and >> HttpsServer' ? >> This fix is set of formatting changes intended to clean up the javadoc of >> th

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v6]

2020-10-19 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean > up in HttpsExchange, HttpsParameters, and > HttpsServer' ? > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.HttpsExchange` > `

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v4]

2020-10-19 Thread Patrick Concannon
On Mon, 19 Oct 2020 15:58:04 GMT, Michael McMahon wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains four additional

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v5]

2020-10-19 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean > up in HttpsExchange, HttpsParameters, and > HttpsServer' ? > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.HttpsExchange` > `

Integrated: 8254967: com.sun.net.HttpsServer spins on TLS session close

2020-10-19 Thread Michael McMahon
On Mon, 19 Oct 2020 15:50:32 GMT, Michael McMahon wrote: > This fixes a busy loop bug in the Http server which happens sometimes when an > SSL connection is closed by the client. > > There is no regression test as it is not easy to reproduce and the only > effect is that one executor thread ge

Re: RFR: 8254967: com.sun.net.HttpsServer spins on TLS session close

2020-10-19 Thread Daniel Fuchs
On Mon, 19 Oct 2020 15:50:32 GMT, Michael McMahon wrote: > This fixes a busy loop bug in the Http server which happens sometimes when an > SSL connection is closed by the client. > > There is no regression test as it is not easy to reproduce and the only > effect is that one executor thread ge

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v4]

2020-10-19 Thread Michael McMahon
On Mon, 19 Oct 2020 15:33:25 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean >> up in HttpsExchange, HttpsParameters, and >> HttpsServer' ? >> This fix is set of formatting changes intended to clean up the javadoc of >> th

RFR: 8254967: com.sun.net.HttpsServer spins on TLS session close

2020-10-19 Thread Michael McMahon
This fixes a busy loop bug in the Http server which happens sometimes when an SSL connection is closed by the client. There is no regression test as it is not easy to reproduce and the only effect is that one executor thread gets tied up. - Commit messages: - 8254967: com.sun.net.

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v4]

2020-10-19 Thread Daniel Fuchs
On Mon, 19 Oct 2020 15:33:25 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean >> up in HttpsExchange, HttpsParameters, and >> HttpsServer' ? >> This fix is set of formatting changes intended to clean up the javadoc of >> th

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v4]

2020-10-19 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean > up in HttpsExchange, HttpsParameters, and > HttpsServer' ? > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.HttpsExchange` > `

Re: RFR: 8245194: Unix domain socket channel implementation [v27]

2020-10-19 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v26]

2020-10-19 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use