> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to use
On Fri, 9 Oct 2020 09:14:33 GMT, Chris Hegarty wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> unixdomainchannels:
>> - updated property name
>> - added JFR unit test
>
> test/jdk/java/nio/channels/unixdomai
On Fri, 9 Oct 2020 11:49:30 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use
>> virtual-thread friendly locking instead of
>> synchronized monitors.
>> Most of the changes are mechanical - but there are still a numbers of subtle
>> no
On Fri, 9 Oct 2020 09:01:43 GMT, Chris Hegarty wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8229867: Re-examine synchronization usages in http and https protocol
>> handlers
>>
>> Incorporated review feedb
On Fri, 9 Oct 2020 08:49:54 GMT, Chris Hegarty wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8229867: Re-examine synchronization usages in http and https protocol
>> handlers
>>
>> Incorporated review feedb
> Hi,
>
> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use
> virtual-thread friendly locking instead of
> synchronized monitors.
> Most of the changes are mechanical - but there are still a numbers of subtle
> non-mechanical differences that are
> outlined below:
> 1. src/j
On Fri, 9 Oct 2020 09:17:48 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/sun/net/www/MeteredStream.java line 123:
>>
>>> 121: lock();
>>> 122: try {
>>> 123: if (closed) return -1;
>>
>> This double check of `closed` is kind of irritating. Is it really nee
On Fri, 9 Oct 2020 08:36:03 GMT, Chris Hegarty wrote:
>> Hi,
>>
>> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use
>> virtual-thread friendly locking instead of
>> synchronized monitors.
>> Most of the changes are mechanical - but there are still a numbers of subtle
>> n
On Tue, 6 Oct 2020 19:53:18 GMT, Michael McMahon wrote:
>> Continuing this review as a PR on github with the comments below
>> incorporated. I expect there will be a few more
>> iterations before integrating.
>> On 06/09/2020 19:47, Alan Bateman wrote:
>>> On 26/08/2020 15:24, Michael McMahon wr
On Thu, 8 Oct 2020 11:22:09 GMT, Daniel Fuchs wrote:
> Hi,
>
> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use
> virtual-thread friendly locking instead of
> synchronized monitors.
> Most of the changes are mechanical - but there are still a numbers of subtle
> non-mecha
On Wed, 7 Oct 2020 13:12:33 GMT, Daniel Fuchs wrote:
>> Continuing the review with a PR...
>>
>> 8252374: Add a new factory method to concatenate a sequence
>> of BodyPublisher instances into a single publisher.
>> https://bugs.openjdk.java.net/browse/JDK-8252374
>>
>>
>> Draft CSR:
>
On Thu, 8 Oct 2020 17:36:31 GMT, Daniel Fuchs wrote:
> Mostly that was a mechanical change since openServer was synchronized before.
> But I guess it seems also desirable for accessing host & port which are
> protected and not final;
Okay, I mis-read the old code. The syncrhonization to access
12 matches
Mail list logo
