On Wed, 30 Sep 2020 10:22:11 GMT, Conor Cleary wrote:
> This patch replaces a LinkedList data structure used in the
> net.http.Http2Connection class with an ArrayList. This
> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
> java.net](https://bugs.openjdk.java.net/browse/JDK
On Tue, 6 Oct 2020 17:04:01 GMT, Aleksey Shipilev wrote:
> I can sponsor this, but it is not clear what testing was done on this. At
> least `tier1`?
`tier1`, `tier2`, `jdk_net`, `test/jdk/java/net/httpclient` tests were
conducted with all passing.
-
PR: https://git.openjdk.java.
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to use
On Mon, 5 Oct 2020 09:09:17 GMT, Chris Hegarty wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improved the API documentation of BodyPublishers::concat
>
> Changes requested by chegar (Reviewer).
@ChrisHegarty As
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote:
>> This patch replaces a LinkedList data structure used in the
>> net.http.Http2Connection class with an ArrayList. This
>> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
>> java.net](https://bugs.openjdk.java.net/browse/
On Tue, 6 Oct 2020 17:02:37 GMT, Aleksey Shipilev wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8253179: Removed ArrayList copy of streams
>
> Marked as reviewed by shade (Reviewer).
I can sponsor this, but it i
> Continuing the review with a PR...
>
> 8252374: Add a new factory method to concatenate a sequence
> of BodyPublisher instances into a single publisher.
> https://bugs.openjdk.java.net/browse/JDK-8252374
>
>
> Draft CSR:
> https://bugs.openjdk.java.net/browse/JDK-8252382
Daniel Fuchs
On Tue, 6 Oct 2020 16:28:21 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8253475 - 'Javadoc clean
>> up in HttpExchange and HttpServer' ?
>>
>> This fix is set of formatting changes intended to clean up the javadoc of
>> the following classes
On Tue, 6 Oct 2020 08:54:29 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental
>> webrev excludes the unrelated changes brought in by the merge/rebase. The
>> pull request contains four additional comm
> Hi,
>
> Could someone please review my doc-only fix for JDK-8253475 - 'Javadoc clean
> up in HttpExchange and HttpServer' ?
>
> This fix is set of formatting changes intended to clean up the javadoc of the
> following classes :
>
> `com.sun.net.httpserver.HttpExchange`
> `com.sun.net.httpser
> Hi,
>
> Could someone please review my doc-only fix for JDK-8253475 - 'Javadoc clean
> up in HttpExchange and HttpServer' ?
>
> This fix is set of formatting changes intended to clean up the javadoc of the
> following classes :
>
> `com.sun.net.httpserver.HttpExchange`
> `com.sun.net.httpser
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote:
>> This patch replaces a LinkedList data structure used in the
>> net.http.Http2Connection class with an ArrayList. This
>> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
>> java.net](https://bugs.openjdk.java.net/browse/
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote:
>> This patch replaces a LinkedList data structure used in the
>> net.http.Http2Connection class with an ArrayList. This
>> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
>> java.net](https://bugs.openjdk.java.net/browse/
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote:
>> This patch replaces a LinkedList data structure used in the
>> net.http.Http2Connection class with an ArrayList. This
>> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
>> java.net](https://bugs.openjdk.java.net/browse/
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to use
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to use
On Tue, 6 Oct 2020 08:03:54 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8253475 - 'Javadoc clean
>> up in HttpExchange and HttpServer' ?
>>
>> This fix is set of formatting changes intended to clean up the javadoc of
>> the following classes
> Hi,
>
> Could someone please review my doc-only fix for JDK-8253475 - 'Javadoc clean
> up in HttpExchange and HttpServer' ?
>
> This fix is set of formatting changes intended to clean up the javadoc of the
> following classes :
>
> `com.sun.net.httpserver.HttpExchange`
> `com.sun.net.httpser
18 matches
Mail list logo
