RFR: 8251989: Hex formatting and parsing utility

2020-10-02 Thread Roger Riggs
java.util.HexFormat utility: - Format and parse hexadecimal strings, with parameters for delimiter, prefix, suffix and upper/lowercase - Static factories and builder methods to create HexFormat copies with modified parameters. - Consistent naming of methods for conversion of byte arrays to fo

Re: RFR: 8245194: Unix domain socket channel implementation [v13]

2020-10-02 Thread Michael McMahon
On Fri, 2 Oct 2020 12:58:02 GMT, Erik Joelsson wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> unixdomainchannels: error in the last commit in >> make/modules/java.base/Copy.gmk > > make/modules/java.base/Copy.

Re: RFR: 8245194: Unix domain socket channel implementation [v13]

2020-10-02 Thread Erik Joelsson
On Fri, 2 Oct 2020 11:28:49 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon wr

Integrated: 8253470: Javadoc clean up in Filter and Headers

2020-10-02 Thread Patrick Concannon
On Wed, 30 Sep 2020 10:02:06 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.su

Re: RFR: 8245194: Unix domain socket channel implementation [v13]

2020-10-02 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v5]

2020-10-02 Thread Michael McMahon
On Fri, 2 Oct 2020 08:52:53 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8245194: Unix domain socket channel implementation [v12]

2020-10-02 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

2020-10-02 Thread Patrick Concannon
On Thu, 1 Oct 2020 15:43:44 GMT, Daniel Fuchs wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java line 40: >> >>> 38: * are organised in chains, and are associated with {@link HttpContext} >>> instances. >>> 39: * >>> 40: * Each {@Filter} in the chain, invokes the

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v5]

2020-10-02 Thread Daniel Fuchs
On Fri, 2 Oct 2020 08:52:53 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean >> up in Filter and Headers' ? >> >> This fix is set of formatting changes intended to clean up the javadoc of >> the following classes : >> >>

Re: RFR: 8253470: Javadoc clean up in Filter and Headers [v5]

2020-10-02 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean > up in Filter and Headers' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.Filter` > `com.sun.net.httpserver.Filter.Chai

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-02 Thread Conor Cleary
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.Http2Connection class with an ArrayList. This >> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net](https://bugs.openjdk.java.net/browse/

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-02 Thread Conor Cleary
> This patch replaces a LinkedList data structure used in the > net.http.Http2Connection class with an ArrayList. This > issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in > java.net](https://bugs.openjdk.java.net/browse/JDK-8246048). Some > justifications for this change are a